Switch to new TestApplication with Sylius 1.14 (#379)

Author: NoResponseMate

.github/workflows/build.yaml

@@ -53,6 +53,7 @@ jobs:
             APP_ENV: test
             DATABASE_URL: ${{ matrix.database == 'mysql' && format('mysql://root:root@127.0.0.1/sylius?serverVersion={0}', matrix.mysql) || format('pgsql://postgres:postgres@127.0.0.1/sylius?serverVersion={0}', matrix.postgres) }}
             TEST_SYLIUS_STATE_MACHINE_ADAPTER: "${{ matrix.state_machine_adapter }}"
+            TEST_SYLIUS_INVOICING_PDF_GENERATION_DISABLED: ${{ matrix.wkhtmltopdf == false }}
 
         steps:
             -
@@ -113,11 +114,9 @@ jobs:
                     sudo dpkg -i wkhtmltox_${{ matrix.wkhtmltopdf }}.jammy_amd64.deb
 
             -
-                name: Disable PDF generation
+                name: Disable running Behat scenarios for PDF generation
                 if: matrix.wkhtmltopdf == false
-                run: |
-                    mv tests/Application/etc/sylius_invoicing_pdf_generation_disabled.yaml tests/Application/config/packages
-                    sed -i 's/pdf_generation_disabled/pdf_generation_enabled/g' behat.yml.dist
+                run: sed -i 's/pdf_generation_disabled/pdf_generation_enabled/g' behat.yml.dist
 
             -
                 name: Get Composer cache directory
@@ -166,27 +165,27 @@ jobs:
 
             -
                 name: Install JS dependencies
-                run: (cd tests/Application && yarn install)
+                run: (cd vendor/sylius/test-application && yarn install)
 
             -
                 name: Prepare test application database
                 run: |
-                    (cd tests/Application && bin/console doctrine:database:create -vvv)
-                    (cd tests/Application && bin/console doctrine:migrations:migrate -n -vvv -q)
+                    vendor/bin/console doctrine:database:create -vvv
+                    vendor/bin/console doctrine:migrations:migrate -n -vvv -q
 
             -
                 name: Prepare test application assets
                 run: |
-                    (cd tests/Application && bin/console assets:install public -vvv)
-                    (cd tests/Application && yarn build:prod)
+                    vendor/bin/console assets:install public -vvv
+                    (cd vendor/sylius/test-application && yarn build:prod)
 
             -
                 name: Prepare test application cache
-                run: (cd tests/Application && bin/console cache:warmup -vvv)
+                run: vendor/bin/console cache:warmup -vvv
 
             -
                 name: Load fixtures in test application
-                run: (cd tests/Application && bin/console sylius:fixtures:load -n)
+                run: vendor/bin/console sylius:fixtures:load -n
 
             -
                 name: Validate composer.json
@@ -221,6 +220,7 @@ jobs:
                 uses: actions/upload-artifact@v4
                 if: failure()
                 with:
-                    name: Behat logs
+                    name: Behat logs - ${{ github.run_id }}-${{ github.run_number }}
                     path: etc/build/
                     if-no-files-found: ignore
+                    overwrite: true

.gitignore

@@ -8,5 +8,6 @@
 /etc/build/*
 !/etc/build/.gitkeep
 
-/tests/Application/yarn.lock
-/tests/Application/private/invoices/*
+/tests/TestApplication/.env.local
+/tests/TestApplication/.env.*.local
+/var/

…plication/config/api_platform/.gitignore assets/admin/entrypoint.jstests/Application/config/api_platform/.gitignore renamed to assets/admin/entrypoint.js tests/Application/config/api_platform/.gitignore renamed to assets/admin/entrypoint.js

@@ -26,9 +26,9 @@ default:
             show_auto: false
 
         FriendsOfBehat\SymfonyExtension:
-            bootstrap: tests/Application/config/bootstrap.php
+            bootstrap: vendor/sylius/test-application/config/bootstrap.php
             kernel:
-                class: Tests\Sylius\InvoicingPlugin\Application\Kernel
+                class: Sylius\TestApplication\Kernel
 
         FriendsOfBehat\VariadicExtension: ~
 

tests/Application/config/jwt/.gitkeep assets/shop/entrypoint.jstests/Application/config/jwt/.gitkeep renamed to assets/shop/entrypoint.js

@@ -45,6 +45,7 @@
         "phpstan/phpstan-webmozart-assert": "^1.2",
         "phpunit/phpunit": "^9.5",
         "polishsymfonycommunity/symfony-mocker-container": "^1.0",
+        "sylius/test-application": "^1.14.0@alpha",
         "sylius-labs/coding-standard": "^4.4",
         "symfony/browser-kit": "^5.4.21 || ^6.4",
         "symfony/debug-bundle": "^5.4.21 || ^6.4",
@@ -61,7 +62,6 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Tests\\Sylius\\InvoicingPlugin\\Application\\": "tests/Application/src/",
             "Tests\\Sylius\\InvoicingPlugin\\Unit\\": "tests/Unit/"
         }
     },
@@ -78,13 +78,15 @@
             "php-http/discovery": true,
             "phpstan/extension-installer": true,
             "symfony/flex": true,
+            "symfony/runtime": false,
             "symfony/thanks": false
         }
     },
     "extra": {
         "branch-alias": {
             "dev-1.0": "1.0-dev"
-        }
+        },
+        "public-dir": "vendor/sylius/test-application/public"
     },
     "prefer-stable": true
 }

behat.yml.dist

@@ -1 +1 @@
-tests/Application/node_modules
+vendor/sylius/test-application/node_modules

composer.json

@@ -9,10 +9,6 @@ parameters:
         # Makes PHPStan crash
         - 'src/DependencyInjection/Configuration.php'
 
-        # Test dependencies
-        - 'tests/Application/app/**.php'
-        - 'tests/Application/src/**.php'
-
     ignoreErrors:
         - identifier: missingType.generics
         - identifier: missingType.iterableValue

node_modules

@@ -1,9 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/8.1/phpunit.xsd"
-         colors="true"
-         bootstrap="tests/Application/config/bootstrap.php">
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
+    colors="true"
+    bootstrap="vendor/sylius/test-application/config/bootstrap.php"
+>
     <testsuites>
         <testsuite name="SyliusInvoicingPlugin Test Suite">
             <directory>tests</directory>
@@ -16,6 +18,6 @@
         <env name="APP_ENV" value="test"/>
         <env name="SHELL_VERBOSITY" value="-1" />
 
-        <server name="KERNEL_CLASS" value="Tests\Sylius\InvoicingPlugin\Application\Kernel" />
+        <server name="KERNEL_CLASS" value="Sylius\TestApplication\Kernel" />
     </php>
 </phpunit>