Handle exceptions in InvoiceCreator while ensuring consistent flow

Author: tomkalon

src/Creator/InvoiceCreator.php

@@ -49,19 +49,17 @@ public function __invoke(string $orderNumber, \DateTimeInterface $dateTime): voi
 
         $invoice = $this->invoiceGenerator->generateForOrder($order, $dateTime);
 
-        if (!$this->hasEnabledPdfFileGenerator) {
+        try {
             $this->invoiceRepository->add($invoice);
+        } catch (\Throwable) {
+            return;
+        }
 
+        if (!$this->hasEnabledPdfFileGenerator) {
             return;
         }
 
         $invoicePdf = $this->invoicePdfFileGenerator->generate($invoice);
         $this->invoiceFileManager->save($invoicePdf);
-
-        try {
-            $this->invoiceRepository->add($invoice);
-        } catch (ORMException) {
-            $this->invoiceFileManager->remove($invoicePdf);
-        }
     }
 }