Skip to content

Commit 36548b0

Browse files
SirDominSirDomin
authored
bug #101 Temporarily remove 'items' from order creation API call (Zales0123)
This PR was merged into the 1.0-dev branch. Discussion ---------- They make it impossible to update the order with e.g. different taxes Commits ------- 7b82561 Temporarily remove 'items' from order creation API call 2d57e7b Remove items from spec
2 parents 69b779e + 2d57e7b commit 36548b0

File tree

2 files changed

+11
-52
lines changed

2 files changed

+11
-52
lines changed

‎spec/Api/CreateOrderApiSpec.php‎

Lines changed: 9 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,8 @@ function it_creates_pay_pal_order_based_on_given_payment(
9494
$data['purchase_units'][0]['amount']['value'] === 100 &&
9595
$data['purchase_units'][0]['amount']['currency_code'] === 'PLN' &&
9696
$data['purchase_units'][0]['amount']['breakdown']['shipping']['currency_code'] === 'PLN' &&
97-
$data['purchase_units'][0]['amount']['breakdown']['shipping']['value'] === 10 &&
98-
$data['purchase_units'][0]['items'][0]['name'] === 'PRODUCT_ONE' &&
99-
$data['purchase_units'][0]['items'][0]['quantity'] === 1 &&
100-
$data['purchase_units'][0]['items'][0]['unit_amount']['value'] === 90 &&
101-
$data['purchase_units'][0]['items'][0]['unit_amount']['currency_code'] === 'PLN';
97+
$data['purchase_units'][0]['amount']['breakdown']['shipping']['value'] === 10
98+
;
10299
})
103100
)->willReturn(['status' => 'CREATED', 'id' => 123]);
104101

@@ -169,11 +166,8 @@ function it_creates_pay_pal_order_with_shipping_address_based_on_given_payment(
169166
$data['purchase_units'][0]['shipping']['address']['address_line_1'] === 'Hobbit St. 123' &&
170167
$data['purchase_units'][0]['shipping']['address']['admin_area_2'] === 'Minas Tirith' &&
171168
$data['purchase_units'][0]['shipping']['address']['postal_code'] === '000' &&
172-
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US' &&
173-
$data['purchase_units'][0]['items'][0]['name'] === 'PRODUCT_ONE' &&
174-
$data['purchase_units'][0]['items'][0]['quantity'] === 1 &&
175-
$data['purchase_units'][0]['items'][0]['unit_amount']['value'] === 90 &&
176-
$data['purchase_units'][0]['items'][0]['unit_amount']['currency_code'] === 'PLN';
169+
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US'
170+
;
177171
})
178172
)->willReturn(['status' => 'CREATED', 'id' => 123]);
179173

@@ -255,15 +249,8 @@ function it_creates_pay_pal_order_with_more_than_one_product(
255249
$data['purchase_units'][0]['shipping']['address']['address_line_1'] === 'Hobbit St. 123' &&
256250
$data['purchase_units'][0]['shipping']['address']['admin_area_2'] === 'Minas Tirith' &&
257251
$data['purchase_units'][0]['shipping']['address']['postal_code'] === '000' &&
258-
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US' &&
259-
$data['purchase_units'][0]['items'][0]['name'] === 'PRODUCT_ONE' &&
260-
$data['purchase_units'][0]['items'][0]['quantity'] === 1 &&
261-
$data['purchase_units'][0]['items'][0]['unit_amount']['value'] === 90 &&
262-
$data['purchase_units'][0]['items'][0]['unit_amount']['currency_code'] === 'PLN' &&
263-
$data['purchase_units'][0]['items'][1]['name'] === 'PRODUCT_TWO' &&
264-
$data['purchase_units'][0]['items'][1]['quantity'] === 2 &&
265-
$data['purchase_units'][0]['items'][1]['unit_amount']['value'] === 40 &&
266-
$data['purchase_units'][0]['items'][1]['unit_amount']['currency_code'] === 'PLN';
252+
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US'
253+
;
267254
})
268255
)->willReturn(['status' => 'CREATED', 'id' => 123]);
269256

@@ -345,19 +332,8 @@ function it_creates_pay_pal_order_with_non_neutral_tax_and_changed_quantity(
345332
$data['purchase_units'][0]['shipping']['address']['address_line_1'] === 'Hobbit St. 123' &&
346333
$data['purchase_units'][0]['shipping']['address']['admin_area_2'] === 'Minas Tirith' &&
347334
$data['purchase_units'][0]['shipping']['address']['postal_code'] === '000' &&
348-
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US' &&
349-
$data['purchase_units'][0]['items'][0]['name'] === 'PRODUCT_ONE' &&
350-
$data['purchase_units'][0]['items'][0]['quantity'] === 1 &&
351-
$data['purchase_units'][0]['items'][0]['unit_amount']['value'] === 50 &&
352-
$data['purchase_units'][0]['items'][0]['unit_amount']['currency_code'] === 'PLN' &&
353-
$data['purchase_units'][0]['items'][0]['tax']['value'] === 10 &&
354-
$data['purchase_units'][0]['items'][0]['tax']['currency_code'] === 'PLN' &&
355-
$data['purchase_units'][0]['items'][1]['name'] === 'PRODUCT_ONE' &&
356-
$data['purchase_units'][0]['items'][1]['quantity'] === 1 &&
357-
$data['purchase_units'][0]['items'][1]['unit_amount']['value'] === 50 &&
358-
$data['purchase_units'][0]['items'][1]['unit_amount']['currency_code'] === 'PLN' &&
359-
$data['purchase_units'][0]['items'][1]['tax']['value'] === 10 &&
360-
$data['purchase_units'][0]['items'][1]['tax']['currency_code'] === 'PLN';
335+
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US'
336+
;
361337
})
362338
)->willReturn(['status' => 'CREATED', 'id' => 123]);
363339

@@ -451,25 +427,7 @@ function it_creates_pay_pal_order_with_more_than_one_product_with_different_tax_
451427
$data['purchase_units'][0]['shipping']['address']['address_line_1'] === 'Hobbit St. 123' &&
452428
$data['purchase_units'][0]['shipping']['address']['admin_area_2'] === 'Minas Tirith' &&
453429
$data['purchase_units'][0]['shipping']['address']['postal_code'] === '000' &&
454-
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US' &&
455-
$data['purchase_units'][0]['items'][0]['name'] === 'PRODUCT_ONE' &&
456-
$data['purchase_units'][0]['items'][0]['quantity'] === 1 &&
457-
$data['purchase_units'][0]['items'][0]['unit_amount']['value'] === 90 &&
458-
$data['purchase_units'][0]['items'][0]['unit_amount']['currency_code'] === 'PLN' &&
459-
$data['purchase_units'][0]['items'][0]['tax']['value'] === 2 &&
460-
$data['purchase_units'][0]['items'][0]['tax']['currency_code'] === 'PLN' &&
461-
$data['purchase_units'][0]['items'][1]['name'] === 'PRODUCT_TWO' &&
462-
$data['purchase_units'][0]['items'][1]['quantity'] === 1 &&
463-
$data['purchase_units'][0]['items'][1]['unit_amount']['value'] === 40 &&
464-
$data['purchase_units'][0]['items'][1]['unit_amount']['currency_code'] === 'PLN' &&
465-
$data['purchase_units'][0]['items'][1]['tax']['value'] === 1 &&
466-
$data['purchase_units'][0]['items'][1]['tax']['currency_code'] === 'PLN' &&
467-
$data['purchase_units'][0]['items'][2]['name'] === 'PRODUCT_TWO' &&
468-
$data['purchase_units'][0]['items'][2]['quantity'] === 1 &&
469-
$data['purchase_units'][0]['items'][2]['unit_amount']['value'] === 40 &&
470-
$data['purchase_units'][0]['items'][2]['unit_amount']['currency_code'] === 'PLN' &&
471-
$data['purchase_units'][0]['items'][2]['tax']['value'] === 1 &&
472-
$data['purchase_units'][0]['items'][2]['tax']['currency_code'] === 'PLN'
430+
$data['purchase_units'][0]['shipping']['address']['country_code'] === 'US'
473431
;
474432
})
475433
)->willReturn(['status' => 'CREATED', 'id' => 123]);

‎src/Api/CreateOrderApi.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ public function create(string $token, PaymentInterface $payment, string $referen
100100
],
101101
],
102102
'soft_descriptor' => 'Sylius PayPal Payment',
103-
'items' => $payPalItemData['items'],
103+
// TODO: figure out how to update items while updating PayPal order
104+
// 'items' => $payPalItemData['items'],
104105
],
105106
],
106107
'application_context' => [

0 commit comments

Comments
 (0)