[UPMERGE] 1.7 -> 2.0 (#411)

This PR has been generated automatically.
For more details see
[upmerge_pr.yaml](/Sylius/PayPalPlugin/blob/1.7/.github/workflows/upmerge_pr.yaml).

**Remember!** The upmerge should always be merged with using `Merge pull
request` button.

In case of conflicts, please resolve them manually with usign the
following commands:
```
git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/2.0 -m "Resolve conflicts between 1.7 and 2.0"
```

If you use other name for the upstream remote, please replace `upstream`
with the name of your remote pointing to the `Sylius/PayPalPlugin`
repository.

Once the conflicts are resolved, please run `git merge --continue` and
push the changes to this PR.

Author: NoResponseMate

.github/workflows/build.yaml

@@ -4,6 +4,7 @@ on:
     push:
         branches-ignore:
             - 'dependabot/**'
+            - 'upmerge/**'
     pull_request: ~
     release:
         types: [ created ]
@@ -202,8 +203,8 @@ jobs:
                 run: vendor/bin/console cache:warmup -vvv
 
             -
-                name: Load fixtures in test application
-                run: vendor/bin/console sylius:fixtures:load -n
+                name: Validate container
+                run: vendor/bin/console lint:container -vvv
 
             -   name: Run security check
                 run: symfony security:check
@@ -213,8 +214,8 @@ jobs:
                 run: composer validate --ansi --strict
 
             -
-                name: Validate container
-                run: vendor/bin/console lint:container
+                name: Load fixtures in test application
+                run: vendor/bin/console sylius:fixtures:load -n
 
             -
                 name: Run Non-unit PHPUnit tests

src/Controller/ProcessPayPalOrderAction.php

@@ -99,12 +99,13 @@ public function __invoke(Request $request): Response
             $address->setPostcode($purchaseUnit['shipping']['address']['postal_code']);
             $address->setCountryCode($purchaseUnit['shipping']['address']['country_code']);
 
+            $order->setShippingAddress(clone $address);
+            $order->setBillingAddress(clone $address);
+
             $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_ADDRESS);
 
             if ($this->stateMachineFactory->can($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SELECT_SHIPPING)) {
                 $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SELECT_SHIPPING);
-            } elseif ($this->stateMachineFactory->can($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SKIP_SHIPPING)) {
-                $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SKIP_SHIPPING);
             }
         } else {
             $address->setFirstName($customer->getFirstName());
@@ -117,16 +118,14 @@ public function __invoke(Request $request): Response
             $address->setPostcode($defaultAddress ? $defaultAddress->getPostcode() : '');
             $address->setCountryCode($data['payer']['address']['country_code']);
 
+            $order->setShippingAddress(clone $address);
+            $order->setBillingAddress(clone $address);
+
             $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_ADDRESS);
         }
 
-        $order->setShippingAddress(clone $address);
-        $order->setBillingAddress(clone $address);
-
         if ($this->stateMachineFactory->can($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SELECT_PAYMENT)) {
             $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SELECT_PAYMENT);
-        } elseif ($this->stateMachineFactory->can($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SKIP_PAYMENT)) {
-            $this->stateMachineFactory->apply($order, OrderCheckoutTransitions::GRAPH, OrderCheckoutTransitions::TRANSITION_SKIP_PAYMENT);
         }
 
         $this->orderManager->flush();

src/Form/Type/PayPalConfigurationType.php

@@ -19,6 +19,7 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\FormEvent;
 use Symfony\Component\Form\FormEvents;
+use Symfony\Component\Validator\Constraints\NotBlank;
 
 final class PayPalConfigurationType extends AbstractType
 {
@@ -48,9 +49,18 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 $form
                     ->add('sylius_merchant_id', HiddenType::class, ['data' => self::SANDBOX_SYLIUS_MERCHANT_ID, 'attr' => ['readonly' => true]])
                     ->add('partner_attribution_id', HiddenType::class, ['data' => self::SANDBOX_ATTRIBUTION_ID, 'attr' => ['readonly' => true]])
-                    ->add('client_id', TextType::class, ['label' => 'sylius_paypal.client_id'])
-                    ->add('client_secret', TextType::class, ['label' => 'sylius_paypal.client_secret'])
-                    ->add('merchant_id', TextType::class, ['label' => 'sylius_paypal.merchant_id'])
+                    ->add('client_id', TextType::class, [
+                        'label' => 'sylius_paypal.client_id',
+                        'constraints' => [new NotBlank(['groups' => 'sylius'])],
+                    ])
+                    ->add('client_secret', TextType::class, [
+                        'label' => 'sylius_paypal.client_secret',
+                        'constraints' => [new NotBlank(['groups' => 'sylius'])],
+                    ])
+                    ->add('merchant_id', TextType::class, [
+                        'label' => 'sylius_paypal.merchant_id',
+                        'constraints' => [new NotBlank(['groups' => 'sylius'])],
+                    ])
                 ;
             } else {
                 $form