Fix phpstan new errors

Author: Prometee

src/Action/Api/WebhookEvent/AbstractPaymentAction.php

@@ -30,6 +30,11 @@ public function execute($request): void
         RequestNotSupportedException::assertSupports($this, $request);
 
         $eventWrapper = $request->getEventWrapper();
+        // This should never be the case but phpstan don't know
+        // about the tests made in the `supports()` method
+        if (null === $eventWrapper) {
+            return;
+        }
         $event = $eventWrapper->getEvent();
 
         /** @var Session|PaymentIntent|SetupIntent $sessionModeObject */

src/Action/CaptureAction.php

@@ -5,9 +5,9 @@
 namespace Prometee\PayumStripe\Action;
 
 use ArrayAccess;
+use LogicException;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\Bridge\Spl\ArrayObject;
-use Payum\Core\Exception\LogicException;
 use Payum\Core\Exception\RequestNotSupportedException;
 use Payum\Core\GatewayAwareInterface;
 use Payum\Core\GatewayAwareTrait;
@@ -36,7 +36,7 @@ public function execute($request): void
 
         if (false === $model->offsetExists('id')) {
             // 0. Create another token to allow payment webhooks to use `Notify`
-            $token = $request->getToken();
+            $token = $this->getRequestToken($request);
             $notifyToken = $this->tokenFactory->createNotifyToken(
                 $token->getGatewayName(),
                 $token->getDetails()
@@ -144,4 +144,20 @@ protected function detectModeData(ArrayObject $model): string
 
         return 'payment_intent_data';
     }
+
+    /**
+     * @param Capture $request
+     *
+     * @return TokenInterface
+     */
+    private function getRequestToken(Capture $request): TokenInterface
+    {
+        $token = $request->getToken();
+
+        if (null === $token) {
+            throw new LogicException('The request token should not be null !');
+        }
+
+        return $token;
+    }
 }

src/Request/Api/ConstructEvent.php

@@ -4,41 +4,42 @@
 
 namespace Prometee\PayumStripe\Request\Api;
 
+use LogicException;
 use Payum\Core\Request\Generic;
 use Prometee\PayumStripe\Wrapper\EventWrapperInterface;
 
 class ConstructEvent extends Generic
 {
-    /** @var null|string */
+    /** @var string */
     private $webhookSecretKey;
     /** @var string */
     private $sigHeader;
 
     /**
      * @param string $payload
      * @param string $sigHeader
-     * @param string|null $webhookSecretKey
+     * @param string $webhookSecretKey
      */
     public function __construct(
         string $payload,
         string $sigHeader,
-        string $webhookSecretKey = null
+        string $webhookSecretKey
     ) {
         parent::__construct($payload);
         $this->sigHeader = $sigHeader;
         $this->webhookSecretKey = $webhookSecretKey;
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPayload(): ?string
+    public function getPayload(): string
     {
         if (is_string($this->getModel())) {
             return (string) $this->getModel();
         }
 
-        return null;
+        throw new LogicException('The payload is not a string !');
     }
 
     public function setPayload(string $payload): void
@@ -47,17 +48,17 @@ public function setPayload(string $payload): void
     }
 
     /**
-     * @param string|null $webhookSecretKey
+     * @param string $webhookSecretKey
      */
-    public function setWebhookSecretKey(?string $webhookSecretKey): void
+    public function setWebhookSecretKey(string $webhookSecretKey): void
     {
         $this->webhookSecretKey = $webhookSecretKey;
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getWebhookSecretKey(): ?string
+    public function getWebhookSecretKey(): string
     {
         return $this->webhookSecretKey;
     }

tests/Action/Api/ConstructEventActionTest.php

@@ -31,7 +31,7 @@ public function shouldThrowExceptionWhenInvalidPayloadIsRequested()
     {
         $payload = '';
         $sigHeader = '';
-        $webhookSecretKey = null;
+        $webhookSecretKey = '';
 
         $action = new ConstructEventAction();
 

tests/Request/Api/ConstructEventTest.php

@@ -15,7 +15,7 @@ final class ConstructEventTest extends TestCase
      */
     public function shouldBeSubClassOfGeneric()
     {
-        $constructEvent = new ConstructEvent('', '');
+        $constructEvent = new ConstructEvent('', '', '');
 
         $this->assertInstanceOf(Generic::class, $constructEvent);
     }
@@ -24,9 +24,9 @@ public function testSetWebhookSecretKey()
     {
         $constructEvent = new ConstructEvent('', '', '');
 
-        $constructEvent->setWebhookSecretKey(null);
+        $constructEvent->setWebhookSecretKey('my_whsec');
 
-        $this->assertEquals(null, $constructEvent->getWebhookSecretKey());
+        $this->assertEquals('my_whsec', $constructEvent->getWebhookSecretKey());
     }
 
     public function testGetWebhookSecretKey()