Prevent doubling Sylius prefix in plugin name

Author: Rafikooo

bin/rename-plugin.php

@@ -231,22 +231,26 @@ private function generateNameVariations(string $company, string $pluginName, boo
             ];
         }
 
-        $syliusPlugin = 'Sylius' . $plugin;
+        $hasSyliusPrefix = str_starts_with($pluginName, 'Sylius');
+        $syliusPlugin = $hasSyliusPrefix ? $plugin : 'Sylius' . $plugin;
+        $syliusPluginName = $hasSyliusPrefix ? $pluginName : 'Sylius' . $pluginName;
+
         $fullClass = $company . $syliusPlugin;
-        $extensionClass = $company . 'Sylius' . $pluginName . 'Extension';
+        $extensionClass = $company . $syliusPluginName . 'Extension';
 
         $companyKebab = $this->toKebabCase($company);
         $fullPluginKebab = $this->toKebabCase($syliusPlugin);
         $companySnake = $this->toSnakeCase($company);
+        $pluginSnakeForDb = $hasSyliusPrefix ? $pluginSnake : 'sylius_' . $pluginSnake;
 
         return [
             'company' => $company,
             'plugin' => $syliusPlugin,
             'fullClass' => $fullClass,
             'extensionClass' => $extensionClass,
             'package' => $companyKebab . '/' . $fullPluginKebab,
-            'db' => $companySnake . '_sylius_' . $pluginSnake . '_plugin',
-            'configKey' => $companySnake . '_sylius_' . $pluginSnake,
+            'db' => $companySnake . '_' . $pluginSnakeForDb . '_plugin',
+            'configKey' => $companySnake . '_' . $pluginSnakeForDb,
         ];
     }
 
@@ -382,6 +386,9 @@ private function updateComposerJson(SymfonyStyle $io, string $packageName, strin
         unset($composer['autoload-dev']['psr-4']['Tests\\Acme\\SyliusExamplePlugin\\']);
         $composer['autoload-dev']['psr-4']["Tests\\{$names['company']}\\{$names['plugin']}\\"] = ['tests/', 'tests/TestApplication/src/'];
 
+        unset($composer['scripts']['post-create-project-cmd']);
+        unset($composer['scripts']['post-root-package-install']);
+
         if ($dryRun) {
             $io->writeln('[DRY RUN] Would update composer.json with:');
             $io->writeln('  - name: ' . $packageName);

bin/show-success.php

@@ -0,0 +1,14 @@
+#!/usr/bin/env php
+<?php
+
+declare(strict_types=1);
+
+echo PHP_EOL;
+echo "  \033[42;30m DONE \033[0m Your plugin is ready!" . PHP_EOL;
+echo PHP_EOL;
+echo "  \033[1mNext steps:\033[0m" . PHP_EOL;
+echo "    1. Start the server:  \033[36msymfony serve -d\033[0m" . PHP_EOL;
+echo "    2. Open in browser:   \033[36mhttps://127.0.0.1:8000\033[0m" . PHP_EOL;
+echo PHP_EOL;
+
+unlink(__FILE__);

bin/validate-directory.php

@@ -4,19 +4,57 @@
 declare(strict_types=1);
 
 $dirName = basename(dirname(__DIR__));
+$isSyliusOfficial = getenv('SYLIUS') === '1';
 
-if (!preg_match('/^[A-Z][a-zA-Z0-9]*Plugin$/', $dirName)) {
-    fwrite(STDERR, "\n");
-    fwrite(STDERR, "  \033[41;37m ERROR \033[0m Directory name must end with 'Plugin' suffix\n");
-    fwrite(STDERR, "\n");
-    fwrite(STDERR, "  Current:  {$dirName}\n");
-    fwrite(STDERR, "  Expected: {$dirName}Plugin (or similar PascalCase name ending with Plugin)\n");
-    fwrite(STDERR, "\n");
-    fwrite(STDERR, "  Example:\n");
-    fwrite(STDERR, "    composer create-project sylius/plugin-skeleton WishlistPlugin\n");
-    fwrite(STDERR, "\n");
-
-    exit(1);
+if ($isSyliusOfficial) {
+    if (!preg_match('/^[A-Z][a-zA-Z0-9]*Plugin$/', $dirName) || str_starts_with($dirName, 'Sylius')) {
+        $hasPluginSuffix = str_ends_with($dirName, 'Plugin');
+
+        $suggestion = $dirName;
+        if (str_starts_with($suggestion, 'Sylius')) {
+            $suggestion = substr($suggestion, 6);
+        }
+        if (!$hasPluginSuffix) {
+            $suggestion .= 'Plugin';
+        }
+
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  \033[41;37m ERROR \033[0m Official Sylius plugin name must match pattern: {Feature}Plugin\n");
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  Current:  {$dirName}\n");
+        fwrite(STDERR, "  Expected: {$suggestion}\n");
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  Example:\n");
+        fwrite(STDERR, "    SYLIUS=1 composer create-project sylius/plugin-skeleton MailerLitePlugin\n");
+        fwrite(STDERR, "\n");
+
+        exit(1);
+    }
+} else {
+    if (!preg_match('/^Sylius[A-Z][a-zA-Z0-9]*Plugin$/', $dirName)) {
+        $hasSyliusPrefix = str_starts_with($dirName, 'Sylius');
+        $hasPluginSuffix = str_ends_with($dirName, 'Plugin');
+
+        $suggestion = $dirName;
+        if (!$hasSyliusPrefix) {
+            $suggestion = 'Sylius' . $suggestion;
+        }
+        if (!$hasPluginSuffix) {
+            $suggestion .= 'Plugin';
+        }
+
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  \033[41;37m ERROR \033[0m Community plugin name must match pattern: Sylius{Feature}Plugin\n");
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  Current:  {$dirName}\n");
+        fwrite(STDERR, "  Expected: {$suggestion}\n");
+        fwrite(STDERR, "\n");
+        fwrite(STDERR, "  Example:\n");
+        fwrite(STDERR, "    composer create-project sylius/plugin-skeleton SyliusWishlistPlugin\n");
+        fwrite(STDERR, "\n");
+
+        exit(1);
+    }
 }
 
 unlink(__FILE__);

composer.json

@@ -79,7 +79,11 @@
         ],
         "post-create-project-cmd": [
             "@php bin/rename-plugin.php",
-            "@test-app-init"
+            "@test-app-init",
+            "git init -q",
+            "git add -A",
+            "git commit -q -m 'Initial commit'",
+            "@php bin/show-success.php"
         ],
         "database-reset": [
             "vendor/bin/console doctrine:database:drop --force --if-exists",
@@ -93,8 +97,7 @@
         ],
         "test-app-init": [
             "@database-reset",
-            "@frontend-clear",
-            "echo '\nNow run:\n\n  symfony serve -d\n'"
+            "@frontend-clear"
         ]
     }
 }

tests/TestApplication/.env

@@ -1,7 +1 @@
 DATABASE_URL=mysql://root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment%
-
-BEHAT_BASE_URL="http://nginx/"
-
-SYLIUS_TEST_APP_BUNDLES_PATH="tests/TestApplication/config/bundles.php"
-SYLIUS_TEST_APP_CONFIGS_TO_IMPORT="@AcmeSyliusExamplePlugin/tests/TestApplication/config/config.yaml"
-SYLIUS_TEST_APP_ROUTES_TO_IMPORT="@AcmeSyliusExamplePlugin/tests/TestApplication/config/routes.yaml"