Catch more specific exceptions

Author: Zales0123

.travis.yml

@@ -13,6 +13,8 @@ jobs:
 
             sudo: false
 
+            env: SYLIUS_CACHE_DIR=$HOME/.sylius-cache SYLIUS_BUILD_DIR=etc/build
+
             cache:
                 yarn: true
                 directories:

src/Action/Admin/RefundUnitsAction.php

@@ -5,6 +5,7 @@
 namespace Sylius\RefundPlugin\Action\Admin;
 
 use Sylius\RefundPlugin\Creator\RefundUnitsCommandCreatorInterface;
+use Sylius\RefundPlugin\Exception\OrderNotFound;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -44,7 +45,7 @@ public function __invoke(Request $request): Response
             $this->commandBus->dispatch($this->commandCreator->fromRequest($request));
 
             $this->session->getFlashBag()->add('success', 'sylius_refund.units_successfully_refunded');
-        } catch (\Exception $exception) {
+        } catch (\InvalidArgumentException | OrderNotFound $exception) {
             $this->session->getFlashBag()->add('error', $exception->getMessage());
         }
 

tests/Behat/Context/Application/RefundingContext.php

@@ -104,7 +104,7 @@ public function decideToRefundPartFromProductWithPayment(
                 $paymentMethod->getId(),
                 ''
             ));
-        } catch (\Exception $exception) {
+        } catch(\InvalidArgumentException | OrderNotFound $exception) {
             return;
         }
     }
@@ -145,7 +145,7 @@ public function tryToRefundPartOfOrderShipment(int $amount, PaymentMethodInterfa
             $this->commandBus->dispatch(new RefundUnits(
                 $this->order->getNumber(), [], [new ShipmentRefund($shippingAdjustment->getId(), $amount)], $paymentMethod->getId(), ''
             ));
-        } catch (\Exception $exception) {
+        } catch(\InvalidArgumentException | OrderNotFound $exception) {
             return;
         }
     }
@@ -222,7 +222,7 @@ public function shouldNotBeAbleToRefundUnitWithProduct(int $unitNumber, string $
                 1,
                 ''
             ));
-        } catch (\Exception $exception) {
+        } catch(\InvalidArgumentException | OrderNotFound $exception) {
             return;
         }
 
@@ -245,7 +245,7 @@ public function shouldNotBeAbleToRefundOrderShipment(): void
                 1,
                 ''
             ));
-        } catch (\Exception $exception) {
+        } catch(\InvalidArgumentException | OrderNotFound $exception) {
             return;
         }
 
@@ -265,7 +265,7 @@ public function shouldStillBeAbleToRefundOrderShipment(PaymentMethodInterface $p
             $this->commandBus->dispatch(new RefundUnits(
                 $this->order->getNumber(), [], [new ShipmentRefund($shippingAdjustment->getId(), $remainingTotal)], $paymentMethod->getId(), ''
             ));
-        } catch (\Exception $exception) {
+        } catch(\InvalidArgumentException | OrderNotFound $exception) {
             throw new \Exception('RefundUnits command should not fail');
         }
     }