[ContentBundle] Static page saving is broken

[psyray]

Hi,

Seems there is a problem with static content.

I'm experiencing a problem while saving static content with route or while saving route or while saving menu linked with static content.
Or in short while a CMS form use the ContentChoiceType form element.

The error is not exactly the same as @antonioperic in the #2682 issue, but I'm sure this is the same bug.

Problem is :
I can't update a page if a route has been defined.
If no route, no problem. Tried to directly save a route and error ("This value is not valid").

After a Xdebug day :( I found that CMF save the static content linked with route using the id (eg: /cms/pages/test, generated by the ContentChoiceType choice list), but before saving the route content it makes a query in the document manager to check if a static page with the id exists, but in the document props (in mysql db table phpcr_nodes), there is no "sv:property" with "sv:name" : id.
If I create a node elsewhere in the props db field like this :

    <sv:property sv:name="id" sv:type="String" sv:multi-valued="0">
        <sv:value length="15">/cms/pages/test</sv:value>
    </sv:property>

no problem, route is correctly saved with linked content.

Maybe there is a modification in CMF that introduce a change in the way CMF documents are saved, and the ContentChoiceType form element need to be updated.
I searched an entire day without success. Maybe someone more experienced than me with Symfony can tell me where the bug is.

Does anyone can confirm this bug ?

• Can't save a static content with a route,
• Can't save a route with a linked static content,
• Can't save a menu element with a linked static content.

It's an annoying bug which break the CMS functionnality.
I will try to search & resolve this bug, but help is appreciated ;)

[nicolasricci]

Yes I can confirm I have the same issue. I will have a look into this as well and let you know if I find anything.

[psyray]

@nicolasricci Thx ;)

Here is the faulty PHPCR Mysql query

doctrine.DEBUG:
SELECT n0.id AS n0_id, n0.path AS n0_path, n0.parent AS n0_parent, n0.local_name AS n0_local_name, n0.namespace AS n0_namespace, n0.workspace_name AS n0_workspace_name, n0.identifier AS n0_identifier, n0.type AS n0_type, n0.props AS n0_props, n0.depth AS n0_depth, n0.sort_order AS n0_sort_order
FROM phpcr_nodes n0 
WHERE n0.workspace_name = ? 
AND n0.type IN ('nt:unstructured', 'rep:root') 
AND (EXTRACTVALUE(n0.props, 'count(//sv:property[@sv:name="id"]/sv:value[text()="/cms/pages/test"]) > 0') 
AND (EXTRACTVALUE(n0.props, 'count(//sv:property[@sv:name="phpcr:class"]/sv:value[text()="Symfony\\Cmf\\Bundle\\ContentBundle\\Doctrine\\Phpcr\\StaticContent"]) > 0') 
OR EXTRACTVALUE(n0.props, 'count(//sv:property[@sv:name="phpcr:classparents"]/sv:value[text()="Symfony\\Cmf\\Bundle\\ContentBundle\\Doctrine\\Phpcr\\StaticContent"]) > 0'))) ["default"] []

This query doesn't return anything because it search an inexistant id in the props field, and cause the "This value is not valid" error message.

[antonioperic]

Is there any progress regarding this bug?

[psyray]

Hi,
No progress, can't found what's wrong with PHPCR nodes ID....

[antonioperic]

Maybe @dbu, @smith77 or @dantleech can help

[dantleech]

Maybe an incorrect mapping somewhere? In the DBAL implementation the identifiers are kept in separate columns to the properties..

[dantleech]

This seems to be the culprit:

at DocumentRepository->findBy(array('id' => array('/cms/pages/Dostava'))) in /var/www/sylius/vendor/symfony/symfony/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php line 224
    at EntityChoiceList->getChoicesForValues(array('/cms/pages/Dostava')) in /var/www/sylius/vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/DataTransformer/ChoiceToValueTransformer.php line 52
    at ChoiceToValueTransformer->reverseTransform('/cms/pages/Dostava') in /var/www/sylius/vendor/symfony/symfony/src/Symfony/Component/Form/Form.php line 1105
    at Form->viewToNorm('/cms/pages/Dostava') in /var/www/sylius/vendor/symfony/symfony/src/Symfony/Component/Form/Form.php line 632
    at Form->submit('/cms/pages/Dostava', true) in 

i.e. the DataTransformer is specifying id, which does not exist in PHPCR (it should use DocumentManager#find(null, $id) in this case).

Maybe @dbu knows something about this?

[dbu]

this looks similar to the issue we struggle with in doctrine/DoctrinePHPCRBundle#193 . somehow different symfony versions behave differently with regards to the form types. unfortunately i did not manage to dig to the root of the problems and am short on time to do that right now. but maybe this is a pointer for somebody?

[psyray]

Thanks for your reply @dbu .
I tried to use different version of Symfony, same error.

I'm not experienced enough to find the solution.
If you do not manage to find, I do not see how I can be useful ...

I don't understand why, like you, without modify anything, the save failed.
A vendor must have changed in a certain way to produce this error.

[duanesteel]

This was a big roadblock on a project I'm working on so I made this change for now. Seems to work for me, but not sure it would be a proper fix or just a hack to keep things moving. Although this is my first time using the ODM rather than the ORM it seems like the existing method was just plain broken. Let me know if my inexperience here is sending me barking up the wrong tree.

I made the following change:

In phpcr-bundle/Form/ChoiceList/PhpcrOdmQueryBuilderLoader.php changed getEntitiesByIds to:

public function getEntitiesByIds($identifier, array $values)
{
    $qb = clone $this->queryBuilder;
    $alias = $qb->getPrimaryAlias();

    foreach ($values as $val) {
            $qb->orWhere()->same($val,'e');
    }
    return $this->getResult($qb);
}

[psyray]

Good catch !!
Your workaround is working.
But I think this should introduce another bug somewhere, because you're not using the identifier var which should be important.
Anyway this could help to unblock things before an official patch is released.

We should ask to @dbu what he is thinking about this.

[duanesteel]

I forgot i left out the identifier was I was just testing different ideas. I think if we add back the identifier check it should still work the same and be a more complete solution.

quick edit: Took another look and , correct me if I'm wrong, but wouldn't the path always be the identifier in this case? Maybe the identifier parameter is not important. I'm not really clear on this.

[dantleech]

I think the issue is that id does not exist, to query by the PHPCR id you must use the field jcr:uuid. So it might be that the query builder converter should handle this mapping (i.e. the designated Id field to jcr:uuid). @dbu wdyt?