Skip to content

Commit 2fa38d2

Browse files
Apply suggestions from code review
Co-authored-by: Jan Góralski <jan.wojciech.goralski@gmail.com>
1 parent 6e34d39 commit 2fa38d2

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/Component/src/Symfony/Routing/Factory/Resource/ResourceRouteCollectionFactory.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,16 @@ private function createRoutesForResource(RouteCollection $routeCollection, Resou
6363
private function addRouteForOperation(RouteCollection $routeCollection, ResourceMetadata $resource, HttpOperation $operation): void
6464
{
6565
$alias = $resource->getAlias();
66-
Assert::notNull($alias);
66+
Assert::notNull($alias, sprintf('Resource of %s has no alias.', $resource->getClass() ?? ''));
6767

6868
$metadata = $this->resourceRegistry->get($alias);
6969
$routeName = $operation->getRouteName();
7070

71-
Assert::notNull($routeName, sprintf('Operation %s has no route name. Please define one.', $operation::class));
71+
Assert::notNull($routeName, sprintf(
72+
'Operation %s of %s has no route name. Please define one.',
73+
$operation::class,
74+
$alias,
75+
));
7276

7377
$route = $this->createRoute($metadata, $resource, $operation);
7478
$routeCollection->add($routeName, $route);

src/Component/src/Symfony/Routing/Loader/ResourceLoader.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ public function __invoke(): RouteCollection
3434
$routeCollection = new RouteCollection();
3535
$resourceClasses = $this->resourceClassListFactory->create();
3636

37-
/**
38-
* @var class-string $class
39-
*/
37+
/** @var class-string $class */
4038
foreach ($resourceClasses as $class) {
4139
$routeCollection->addCollection($this->resourceRouteCollectionFactory->createRouteCollectionForClass($class));
4240
}

0 commit comments

Comments
 (0)