Skip to content

Commit b7081a7

Browse files
Fix implicit nullable parameter + add ECS rule (#1024)
| Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT
2 parents 9bd1010 + fc96543 commit b7081a7

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

ecs.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
use PhpCsFixer\Fixer\ClassNotation\VisibilityRequiredFixer;
44
use PhpCsFixer\Fixer\Comment\HeaderCommentFixer;
55
use PhpCsFixer\Fixer\FunctionNotation\MethodArgumentSpaceFixer;
6+
use PhpCsFixer\Fixer\FunctionNotation\NullableTypeDeclarationForDefaultNullValueFixer;
67
use PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer;
78
use SlevomatCodingStandard\Sniffs\Commenting\InlineDocCommentDeclarationSniff;
89
use Symplify\EasyCodingStandard\Config\ECSConfig;
@@ -27,6 +28,7 @@
2728
])
2829
;
2930
$ecsConfig->ruleWithConfiguration(NoSuperfluousPhpdocTagsFixer::class, ['allow_mixed' => true]);
31+
$ecsConfig->ruleWithConfiguration(NullableTypeDeclarationForDefaultNullValueFixer::class, ['use_nullable_type_declaration' => true]);
3032

3133
$ecsConfig->skip([
3234
InlineDocCommentDeclarationSniff::class . '.MissingVariable',

src/Bundle/Doctrine/ODM/MongoDB/TranslatableRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*/
2424
class TranslatableRepository extends DocumentRepository implements TranslatableRepositoryInterface
2525
{
26-
protected function applyCriteria(QueryBuilder $queryBuilder, array $criteria = null): void
26+
protected function applyCriteria(QueryBuilder $queryBuilder, ?array $criteria = null): void
2727
{
2828
if (null === $criteria) {
2929
return;
@@ -42,7 +42,7 @@ protected function applyCriteria(QueryBuilder $queryBuilder, array $criteria = n
4242
}
4343
}
4444

45-
protected function applySorting(QueryBuilder $queryBuilder, array $sorting = null): void
45+
protected function applySorting(QueryBuilder $queryBuilder, ?array $sorting = null): void
4646
{
4747
if (null === $sorting) {
4848
return;

src/Component/src/Exception/StorageUnavailableException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
class StorageUnavailableException extends RuntimeException
1717
{
18-
public function __construct(string $message = '', \Exception $previous = null)
18+
public function __construct(string $message = '', ?\Exception $previous = null)
1919
{
2020
parent::__construct($message, 0, $previous);
2121
}

src/Component/src/Symfony/Validator/Exception/ValidationException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*/
2323
final class ValidationException extends \RuntimeException implements ConstraintViolationListAwareExceptionInterface
2424
{
25-
public function __construct(private ConstraintViolationListInterface $constraintViolationList, string $message = '', int $code = 0, \Exception $previous = null)
25+
public function __construct(private ConstraintViolationListInterface $constraintViolationList, string $message = '', int $code = 0, ?\Exception $previous = null)
2626
{
2727
parent::__construct($message ?: $this->__toString(), $code, $previous);
2828
}

0 commit comments

Comments
 (0)