Skip to content

Commit cbffe74

Browse files
loic425diimpp
andcommitted
Apply suggestions from code review
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
1 parent a866510 commit cbffe74

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/Component/src/Metadata/Resource/Factory/AttributesResourceClassListFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use Sylius\Resource\Reflection\ClassReflection;
1919

2020
/**
21-
* Creates a resource name collection from {@see AsResource} attributes.
21+
* Creates a resource class list from {@see AsResource} attributes.
2222
*
2323
* @experimental
2424
*/

src/Component/src/Metadata/Resource/Factory/ResourceClassListFactoryInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
interface ResourceClassListFactoryInterface
2424
{
2525
/**
26-
* Creates the resource name collection.
26+
* Creates the resource class list.
2727
*/
2828
public function create(): ResourceClassList;
2929
}

src/Component/tests/Metadata/Resource/Factory/AttributesResourceClassListFactoryTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ final class AttributesResourceClassListFactoryTest extends TestCase
2222
{
2323
public function testCreateAResourceClassListForResourcesWithAsResourceAttribute(): void
2424
{
25-
$attributesResourceNameCollectionFactory = new AttributesResourceClassListFactory(
25+
$attributesResourceClassListFactory = new AttributesResourceClassListFactory(
2626
mapping: ['paths' => [dirname(__DIR__, 3) . '/Dummy']],
2727
);
2828

29-
$collection = $attributesResourceNameCollectionFactory->create();
29+
$list = $attributesResourceClassListFactory->create();
3030

31-
$this->assertContains(DummyResource::class, $collection->getIterator());
32-
$this->assertNotContains(PullRequest::class, $collection->getIterator());
31+
$this->assertContains(DummyResource::class, $list->getIterator());
32+
$this->assertNotContains(PullRequest::class, $list->getIterator());
3333
}
3434
}

src/Component/tests/Metadata/Resource/ResourceClassListTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,21 @@ final class ResourceClassListTest extends TestCase
2020
{
2121
public function testItIsAnIteratorAggregate(): void
2222
{
23-
$collection = new ResourceClassList();
23+
$list = new ResourceClassList();
2424

25-
$this->assertInstanceOf(\IteratorAggregate::class, $collection);
25+
$this->assertInstanceOf(\IteratorAggregate::class, $list);
2626
}
2727

2828
public function testItIsCountable(): void
2929
{
30-
$collection = new ResourceClassList();
30+
$list = new ResourceClassList();
3131

32-
$this->assertInstanceOf(\Countable::class, $collection);
32+
$this->assertInstanceOf(\Countable::class, $list);
3333
}
3434

3535
public function testItIsAListOfResourceClassNames(): void
3636
{
37-
$collection = new ResourceClassList(['first_resource', 'second_resource']);
37+
$list = new ResourceClassList(['first_resource', 'second_resource']);
3838

3939
$this->assertCount(2, $collection);
4040
$this->assertEquals('first_resource', $collection->getIterator()[0]);

0 commit comments

Comments
 (0)