sylius:theme:assets:install not generating public/_themes directory

[mbabker]

With Sylius 1.9.0 and sylius/theme-bundle 2.1.1, when I run the bin/console sylius:theme:assets:install command (without symlinks due to #79), I am not getting a version of the assets in the public/_themes directory. public/bundles does generate correctly.

For our client, we overloaded some admin field types to use CKEditor through FOSCKEditorBundle and are installing its assets via bin/console ckeditor:install --clear=drop. After running the CKEditor install command then the asset install command and going to any admin page where we have CKEditor in use, the asset URL (as determined with the PathResolver class) is /_themes/<theme_composer_name>/bundles/fosckeditor/ckeditor.js. With Sylius 1.8 and the 1.x version of this bundle, the asset URL is /bundles/_themes/<theme_composer_name>/fosckeditor/ckeditor.js and this is working OK (note, public/bundles/_themes doesn't exist on the new version either, just to be sure there wasn't anything strange here).

[mbabker]

I'm in over my head at this point but basically, it is failing because of the path resolver.

With 1.5.1, this call to the resolver is correctly building the public/bundles/_themes path. With 2.1.1, this call is not. It looks like there is a discrepancy between how the resolver is used in the asset installer versus its use in the PathPackage class, more specifically at the point it's used in the installer it looks to be processing a relative folder name whereas with the PathPackage (and the test cases in the resolver's spec) it expects a full asset path.

The quickest band-aid fix for anyone using a single theme application would probably be to get rid of the assets.path_package service override from this bundle and restore the original service definition from the FrameworkBundle.

[LucaGallinari]

Hi guys, i saw that the version 2.2.0 has been released but we are still having this issue

[pamil]

v2.2.0 includes support for PHP 8 and the new public resources directory in bundles, I haven't got enough time to debug this one - I'll be happy to review any PR that helps to solve it though.

[mbabker]

Unfortunately, I reached the end of what I could do yesterday. What drives me bonkers is that AssetTest::it_dumps_assets() actually produces the right result, yet in my production application I can't make the thing work to save my life. All I really worked out for sure is that there's something wonky with how the path resolver is used in the installer versus from Symfony's Asset API. Even if I change my commands to use absolute paths instead of relative, it changes nothing.

Hopefully, someone can kind of work out where to go with the extra info I stumbled across.

[jbcr]

Hi,

In my case, all assets stored in the public folder public/bundles cannot be linked with path() twig method.

All URL are prefixed by _themes/my/theme and all of these URLs return a 404 error.

When I run sylius:theme:assets:install, only Installing assets as hard copies. is displayed but nothing changes in the public directory.

EDIT: In the administration, if I select a channel with the default theme, no prefix has been added on the assets path. Why?

Symfony: 5.2.5
Sylius: 1.9.1
ThemeBundle: 2.2.0
LegacyMode: true

[jbcr]

In my case, I don't have assets on my themes.

To solve this issue, I have disabled assets on themes

sylius_theme:
    assets: 
        enabled: false

[maximehuran]

This issue is really important I think.
We cannot install our plugins assets on Sylius projects which are using themes.
We have 404 on resources, so no JS or CSS are loaded.

[maxperei]

hi guys,

what i thought to understand since this bundle's upgrade :

• ./themes/ directory at project root must have a public/ folder inside to replicate the structure _themes/[author]/[theme-name]/bundles/**/... in ./public/ directory (cf. ./src/Asset/Installer/AssetsProvider.php:44)

but this induces several disappointments during bin/console syl:the:ass:ins

1. because [--relative|--symlink] option loses assets (cf. Command sylius:theme:assets:install --symlink --relative sometimes remove origin files #79)
2. whereas all your custom theme content is disposed or duplicated at the wrong place (inside ./public/_themes/...)
3. sometimes in particular cases it breaks the way bundle's assets are loaded eg.

so i think this is more a regression than a discovery, and btw in my opinion i'd rather delete the pathResolver->resolve() call at ./src/Asset/Package/PathPackage.php:57 but maybe its a bit agressive and not justified.. 😅

[jacquesbh]

@pamil We really have an issue here 🙃.

It's driving me crazy as well. Something is wrong and has to be fixed.

Why is the theme used in admin?

[jacquesbh]

Here is a quick fix for those who can't wait:

<?php

declare(strict_types=1);

namespace App\Sylius\Core\Theme;

use Exception;
use Sylius\Bundle\ThemeBundle\Context\ThemeContextInterface;
use Sylius\Bundle\ThemeBundle\Model\ThemeInterface;
use Sylius\Bundle\ThemeBundle\Repository\ThemeRepositoryInterface;
use Sylius\Component\Channel\Context\ChannelContextInterface;
use Sylius\Component\Channel\Context\ChannelNotFoundException;
use Sylius\Component\Core\Model\ChannelInterface;
use Symfony\Component\HttpFoundation\RequestStack;

final class ChannelBasedThemeContext implements ThemeContextInterface
{
    private RequestStack $requestStack;
    private ChannelContextInterface $channelContext;
    private ThemeRepositoryInterface $themeRepository;

    public function __construct(
        RequestStack $requestStack,
        ChannelContextInterface $channelContext,
        ThemeRepositoryInterface $themeRepository
    ) {
        $this->requestStack = $requestStack;
        $this->channelContext = $channelContext;
        $this->themeRepository = $themeRepository;
    }

    public function getTheme(): ?ThemeInterface
    {
        if ($this->isAdmin()) {
            return null;
        }
        try {
            /** @var ChannelInterface $channel */
            $channel = $this->channelContext->getChannel();
            $themeName = $channel->getThemeName();

            if (null === $themeName) {
                return null;
            }

            return $this->themeRepository->findOneByName($themeName);
        } catch (ChannelNotFoundException $exception) {
            return null;
        } catch (Exception $exception) {
            return null;
        }
    }

    private function isAdmin(): bool
    {
        if (null === $masterRequest = $this->requestStack->getMasterRequest()) {
            return false;
        }
        $syliusParameters = $masterRequest->get('_sylius', []);
        return array_key_exists('section', $syliusParameters) && 'admin' === $syliusParameters['section'];
    }
}

services:
    # the class App\Sylius\Core\Theme\ChannelBasedThemeContext is autowired.
    sylius.theme.context.channel_based: '@App\Sylius\Core\Theme\ChannelBasedThemeContext'

[maximehuran]

@jacquesbh @pamil see #102

[LucaGallinari]

If it can help someone, we temporarily solved this by using this work around:

composer.json

{
...

    "scripts": {
        "post-install-cmd": [
            ...
            "@symlink-themes"
        ],
        "post-update-cmd": [
            ...
            "@symlink-themes"
        ],
        "symlink-themes": "mkdir -p public/_themes/[THEME_VENDOR]/[THEME_NAME] && ln -s ../../../bundles public/_themes/[THEME_VENDOR]/[THEME_NAME]/bundles",
    }
...
}

[0mars]

On a side-note if you're trying to debug this with docker-compose packed with Sylius 1.9 then add this to the php container to stall a bit and not shutdown while failing

# Dockerfile
APK add vim bash

# docker-compose.yml
services:
  php:
    command: bash -c "sleep 5000"