Add test for pre-telemetry Sylius guard

Author: Rafikooo

src/TelemetryCompilerPass.php

@@ -4,15 +4,18 @@
 
 namespace Sylius\Telemetry;
 
+use Sylius\Bundle\CoreBundle\SyliusCoreBundle;
+use Sylius\Component\Core\Telemetry\TelemetrySendManagerInterface;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Loader\DelegatingLoader;
 use Symfony\Component\Config\Loader\LoaderResolver;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\DirectoryLoader;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
+use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 
-final class TelemetryCompilerPass implements CompilerPassInterface
+class TelemetryCompilerPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container): void
     {
@@ -32,14 +35,14 @@ public function process(ContainerBuilder $container): void
         $this->loadTelemetryServices($container);
     }
 
-    private function isTelemetrySupported(): bool
+    protected function isTelemetrySupported(): bool
     {
-        return interface_exists(\Sylius\Component\Core\Telemetry\TelemetrySendManagerInterface::class);
+        return interface_exists(TelemetrySendManagerInterface::class);
     }
 
     private function loadTelemetryServices(ContainerBuilder $container): void
     {
-        $bundleDir = dirname((new \ReflectionClass(\Sylius\Bundle\CoreBundle\SyliusCoreBundle::class))->getFileName());
+        $bundleDir = dirname((new \ReflectionClass(SyliusCoreBundle::class))->getFileName());
         $configDir = $bundleDir . '/Resources/config/services/telemetry';
 
         $locator = new FileLocator($configDir);
@@ -49,8 +52,8 @@ private function loadTelemetryServices(ContainerBuilder $container): void
             new DirectoryLoader($container, $locator),
         ];
 
-        if (class_exists(\Symfony\Component\DependencyInjection\Loader\XmlFileLoader::class)) {
-            $loaders[] = new \Symfony\Component\DependencyInjection\Loader\XmlFileLoader($container, $locator);
+        if (class_exists(XmlFileLoader::class)) {
+            $loaders[] = new XmlFileLoader($container, $locator);
         }
 
         $loader = new DelegatingLoader(new LoaderResolver($loaders));

tests/Unit/TelemetryCompilerPassTest.php

@@ -40,6 +40,21 @@ public function testItSkipsInTestEnvironment(): void
         $this->assertFalse($container->has('sylius.telemetry.send_manager'));
     }
 
+    public function testItSkipsWhenSyliusDoesNotSupportTelemetry(): void
+    {
+        $container = $this->createContainer('prod');
+
+        $pass = new class () extends TelemetryCompilerPass {
+            protected function isTelemetrySupported(): bool
+            {
+                return false;
+            }
+        };
+        $pass->process($container);
+
+        $this->assertFalse($container->has('sylius.telemetry.send_manager'));
+    }
+
     public function testItLoadsTelemetryServicesInProd(): void
     {
         $container = $this->createContainer('prod');