Merge branch 'runner' into logging_patch

Author: Synicix

.clippy.toml

@@ -1,3 +1,3 @@
-excessive-nesting-threshold = 4
+excessive-nesting-threshold = 6
 too-many-arguments-threshold = 10
 allowed-idents-below-min-chars = ["..", "k", "v", "f", "re", "id", "Ok", "'_"]

.github/workflows/tests.yaml

@@ -17,7 +17,7 @@ jobs:
       - name: Install Rust + components
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.87
+          toolchain: 1.89
           components: rustfmt,clippy
       - name: Install code coverage
         uses: taiki-e/install-action@cargo-llvm-cov

.vscode/settings.json

@@ -9,7 +9,6 @@
     ],
     "files.autoSave": "off",
     "files.insertFinalNewline": true,
-    "gitlens.showWelcomeOnInstall": false,
     "gitlens.showWhatsNewAfterUpgrades": false,
     "lldb.consoleMode": "evaluate",
     "rust-analyzer.cargo.features": [

Cargo.toml

@@ -55,6 +55,7 @@ glob = "0.3.1"
 heck = "0.5.0"
 # convert bytes to hex strings
 hex = "0.4.3"
+hostname = "0.4.1"
 # hashmaps that preserve insertion order
 indexmap = { version = "2.9.0", features = ["serde"] }
 # utilities for iterables e.g. cartesian products

cspell.json

@@ -80,7 +80,9 @@
         "wasi",
         "patchelf",
         "itertools",
-        "colinianking"
+        "colinianking",
+        "itertools",
+        "pathset",
     ],
     "useGitignore": false,
     "ignorePaths": [

src/core/crypto.rs

@@ -50,11 +50,9 @@ pub fn hash_buffer(buffer: impl AsRef<[u8]>) -> String {
 ///
 /// Will return error if unable to access file.
 pub fn hash_file(filepath: impl AsRef<Path>) -> Result<String> {
-    hash_stream(
-        &mut File::open(&filepath).context(selector::InvalidFilepath {
-            path: filepath.as_ref(),
-        })?,
-    )
+    hash_stream(&mut File::open(&filepath).context(selector::InvalidPath {
+        path: filepath.as_ref(),
+    })?)
 }
 /// Evaluate checksum hash of a directory.
 ///
@@ -64,7 +62,10 @@ pub fn hash_file(filepath: impl AsRef<Path>) -> Result<String> {
 pub fn hash_dir(dirpath: impl AsRef<Path>) -> Result<String> {
     let summary: BTreeMap<String, String> = dirpath
         .as_ref()
-        .read_dir()?
+        .read_dir()
+        .context(selector::InvalidPath {
+            path: dirpath.as_ref(),
+        })?
         .map(|path| {
             let access_path = path?.path();
             Ok((

src/core/error.rs

@@ -124,8 +124,14 @@ impl fmt::Debug for OrcaError {
             | Kind::FailedToStartPod { backtrace, .. }
             | Kind::FailedToExtractRunInfo { backtrace, .. }
             | Kind::IncompletePacket { backtrace, .. }
-            | Kind::InvalidFilepath { backtrace, .. }
+            | Kind::InvalidPath { backtrace, .. }
+            | Kind::InvalidIndex { backtrace, .. }
+            | Kind::KeyMissing { backtrace, .. }
             | Kind::MissingInfo { backtrace, .. }
+            | Kind::FailedToGetPodJobOutput { backtrace, .. }
+            | Kind::PodJobProcessingError { backtrace, .. }
+            | Kind::PodJobSubmissionFailed { backtrace, .. }
+            | Kind::UnexpectedPathType { backtrace, .. }
             | Kind::BollardError { backtrace, .. }
             | Kind::ChronoParseError { backtrace, .. }
             | Kind::DOTError { backtrace, .. }

src/core/graph.rs

@@ -1,5 +1,5 @@
 use crate::{
-    core::{pipeline::PipelineNode, util::get},
+    core::{model::pipeline::PipelineNode, util::get},
     uniffi::{error::Result, model::pipeline::Kernel},
 };
 use dot_parser::ast::Graph as DOTGraph;
@@ -25,7 +25,7 @@ pub fn make_graph(
     let graph =
         DiGraph::<DotNodeWeight, DotAttrList>::from_dot_graph(DOTGraph::try_from(input_dot)?).map(
             |_, node| PipelineNode {
-                name: node.id.clone(),
+                id: node.id.clone(),
                 kernel: get(&metadata, &node.id)
                     .unwrap_or_else(|error| panic!("{error}"))
                     .clone(),

src/core/mod.rs

@@ -9,7 +9,6 @@ macro_rules! inner_attr_to_each {
 
 pub(crate) mod error;
 pub(crate) mod graph;
-pub(crate) mod pipeline;
 pub(crate) mod store;
 pub(crate) mod util;
 pub(crate) mod validation;
@@ -20,6 +19,7 @@ inner_attr_to_each! {
     pub(crate) mod model;
     pub(crate) mod operator;
     pub(crate) mod orchestrator;
+    pub(crate) mod pipeline_runner;
 }
 
 #[cfg(feature = "test")]
@@ -35,6 +35,7 @@ inner_attr_to_each! {
     )]
     pub mod crypto;
     pub mod model;
-    pub mod operator;
     pub mod orchestrator;
+    pub mod pipeline_runner;
+    pub mod operator;
 }

src/core/model/mod.rs

@@ -57,4 +57,5 @@ where
     sorted.serialize(serializer)
 }
 
+pub mod pipeline;
 pub mod pod;