Skip to content

Commit 5ea5735

Browse files
committed
Fix: Improve beta property to handle None and empty report_url
1 parent 2b4012b commit 5ea5735

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

spkrepo/models.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ def version_string(self):
462462

463463
@hybrid_property
464464
def beta(self):
465-
return self.report_url != None # noqa: E711
465+
return bool(self.report_url) # Treats None and "" as False
466466

467467
@hybrid_property
468468
def all_builds_active(self):
@@ -484,6 +484,10 @@ def all_builds_active(cls):
484484
.label("total_builds")
485485
)
486486

487+
@beta.expression
488+
def beta(cls):
489+
return db.and_(cls.report_url.isnot(None), cls.report_url != "")
490+
487491
@property
488492
def path(self):
489493
return os.path.join(self.package.name, str(self.version))

0 commit comments

Comments
 (0)