Commit b0725c6
authored
Remove importExcelModel and convert tutorial models to YAML (#631)
* Remove importExcelModel and convert tutorial models to YAML
- Remove io/importExcelModel.m and its generated documentation
- Convert tutorial models small, smallYeast and smallYeastBad from Excel
to YAML; rewrite tutorials 1-4 and their solutions to load models via
importModel/readYAMLmodel instead of importExcelModel
- Drop the smallYeastBad2 section of tutorial 4 (duplicate metabolite
names cannot be represented in SBML/YAML)
- readYAMLmodel: keep rxnGeneMat dimensionally consistent for gene-less
models, which were left with an empty matrix that broke removeReactions
- followChanged: handle the case where no reactions differ, where the
empty reaction list was expanded to all reactions by constructEquations
- fillGaps: guard against an empty toCheck list, which haveFlux otherwise
interprets as all reactions
- tutorial3_solutions: set upper bounds before lower bounds so a lower
bound never transiently exceeds the previous upper bound
- tutorial4: define the reference model before it is used
- Remove Excel import coverage from tIO and importExportTests
* Remove orphaned Excel model files from tutorial
With importExcelModel gone, nothing can read the Excel source models, so
the now-unreferenced tutorial/{small,smallYeast,smallYeastBad,
smallYeastBad2}.xlsx and "iAL1006 v1.00.xlsx" are removed. The small,
smallYeast and smallYeastBad models remain as YAML; iAL1006 remains as
SBML. The empty.{xml,xlsx,yml,mat} set is kept on purpose, as each format
is used to test a different importer (importModel, loadWorkbook/loadSheet,
readYAMLmodel/parseYAML and the MAT-based importExportTests). Update the
tutorial1 header that referred to the removed Excel file.1 parent 4fa69ee commit b0725c6
22 files changed
Lines changed: 3482 additions & 2170 deletions
File tree
- analysis
- doc/io
- gapfilling
- io
- testing
- function_tests
- unit_tests
- tutorial
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
104 | 110 | | |
105 | 111 | | |
106 | 112 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
198 | 203 | | |
199 | 204 | | |
200 | 205 | | |
| |||
0 commit comments