Fix incorrect traversal into externals for read/write buffered regs. #169

Author: amykyta3

src/peakrdl_regblock/read_buffering/storage_generator.py

@@ -1,8 +1,13 @@
-from systemrdl.node import FieldNode, RegNode
+from systemrdl.node import FieldNode, RegNode, AddressableNode
+from systemrdl.walker import WalkerAction
 
 from ..struct_generator import RDLStructGenerator
 
 class RBufStorageStructGenerator(RDLStructGenerator):
+    def enter_AddressableComponent(self, node: AddressableNode) -> WalkerAction:
+        if node.external :
+            return WalkerAction.SkipDescendants
+        return WalkerAction.Continue
 
     def enter_Field(self, node: FieldNode) -> None:
         # suppress parent class's field behavior

src/peakrdl_regblock/write_buffering/storage_generator.py

@@ -1,6 +1,7 @@
 from typing import TYPE_CHECKING
 
-from systemrdl.node import FieldNode, RegNode
+from systemrdl.node import FieldNode, RegNode, AddressableNode
+from systemrdl.walker import WalkerAction
 
 from ..struct_generator import RDLStructGenerator
 
@@ -12,6 +13,11 @@ def __init__(self, wbuf: 'WriteBuffering') -> None:
         super().__init__()
         self.wbuf = wbuf
 
+    def enter_AddressableComponent(self, node: AddressableNode) -> WalkerAction:
+        if node.external :
+            return WalkerAction.SkipDescendants
+        return WalkerAction.Continue
+
     def enter_Field(self, node: FieldNode) -> None:
         # suppress parent class's field behavior
         pass

tests/test_validation_errors/testcase.py

@@ -10,10 +10,6 @@ def setUp(self) -> None:
         # Stub usual pre-test setup
         pass
 
-    def tearDown(self):
-        # Delete any cruft that may get generated
-        self.delete_run_dir()
-
     def assert_validate_error(self, rdl_file: str, err_regex: str) -> None:
         self.rdl_file = rdl_file
         f = io.StringIO()