lint cleanup

Author: amykyta3

src/peakrdl_systemrdl/exporter.py

@@ -8,8 +8,7 @@
     from systemrdl.messages import MessageHandler
 
 class SystemRDLExporter:
-    def __init__(self) -> None:
-        self.msg = None # type: MessageHandler
+    msg: "MessageHandler"
 
     def export(self, node: Union[AddrmapNode, RootNode], path: str) -> None:
         self.msg = node.env.msg

src/peakrdl_systemrdl/stringify.py

@@ -7,13 +7,13 @@ def stringify_rdl_value(value: Any) -> str:
     Convert value into its RDL string.
     """
 
-    if type(value) == int:
-        return stringify_int(value)
-    elif type(value) == bool:
+    if isinstance(value, bool):
         return stringify_boolean(value)
-    elif type(value) == str:
+    elif isinstance(value, int):
+        return stringify_int(value)
+    elif isinstance(value, str):
         return stringify_string(value)
-    elif type(value) == list:
+    elif isinstance(value, list):
         return stringify_array(value)
     elif isinstance(value, rdltypes.BuiltinEnum):
         return stringify_builtin_enum(value)
@@ -57,7 +57,7 @@ def stringify_builtin_enum(value: rdltypes.BuiltinEnum) -> str:
 
 
 def stringify_user_enum_member(value: rdltypes.UserEnum) -> str:
-    return "%s::%s" % (type(value).type_name, value.name)
+    return "%s::%s" % (type(value).type_name, value.name) # type: ignore
 
 
 def stringify_struct(value: rdltypes.UserStruct) -> str:
@@ -66,4 +66,4 @@ def stringify_struct(value: rdltypes.UserStruct) -> str:
 
 
 def stringify_user_enum_type(value: rdltypes.UserEnum) -> str:
-    return value.type_name
+    return value.type_name # type: ignore

test/pylint.rc

@@ -88,6 +88,7 @@ disable=
         too-many-statements,
         too-many-instance-attributes,
         too-many-function-args,
+        too-many-positional-arguments,
         line-too-long,
 
         # Noise / Don't care
@@ -98,10 +99,7 @@ disable=
         abstract-method,
         protected-access,
         duplicate-code,
-        cyclic-import,
-        unidiomatic-typecheck,
-
-        # Can't do until py35 support is dropped
+        unused-argument,
         consider-using-f-string
 
 # Enable the message, report, category or checker with the given id(s). You can
@@ -145,7 +143,7 @@ max-nested-blocks=5
 # inconsistent-return-statements if a never returning function is called then
 # it will be considered as an explicit return statement and no message will be
 # printed.
-never-returning-functions=sys.exit
+never-returning-functions=sys.exit,argparse.parse_error
 
 
 [STRING]
@@ -495,7 +493,7 @@ valid-metaclass-classmethod-first-arg=cls
 ignored-parents=
 
 # Maximum number of arguments for function / method.
-max-args=8
+max-args=16
 
 # Maximum number of attributes for a class (see R0902).
 max-attributes=7
@@ -570,5 +568,5 @@ preferred-modules=
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "BaseException, Exception".
-overgeneral-exceptions=BaseException,
-                       Exception
+overgeneral-exceptions=builtin.BaseException,
+                       builtin.Exception