From f4059a90b9002233ec76073c70b8a3ccaa3f7b87 Mon Sep 17 00:00:00 2001 From: Alex Mykyta Date: Mon, 6 Jan 2025 22:54:14 -0800 Subject: [PATCH] Remove incorrect inheritence of external for signals. --- src/systemrdl/__about__.py | 2 +- src/systemrdl/core/elaborate.py | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/systemrdl/__about__.py b/src/systemrdl/__about__.py index b6252b3..a1fbe6d 100644 --- a/src/systemrdl/__about__.py +++ b/src/systemrdl/__about__.py @@ -1 +1 @@ -__version__ = "1.29.1" +__version__ = "1.29.2" diff --git a/src/systemrdl/core/elaborate.py b/src/systemrdl/core/elaborate.py index be5b338..e8dc709 100644 --- a/src/systemrdl/core/elaborate.py +++ b/src/systemrdl/core/elaborate.py @@ -565,12 +565,8 @@ def enter_Field(self, node: FieldNode) -> None: node.inst.external = node.parent.inst.external def enter_Signal(self, node: SignalNode) -> None: - if isinstance(node.parent, RootNode): - # In root scope. External is meaningless, so assign it to False - node.inst.external = False - else: - assert node.parent is not None - node.inst.external = node.parent.inst.external + # External is meaningless for signals. Always False + node.inst.external = False def enter_Regfile(self, node: RegfileNode) -> None: if self.coerce_external_to is not None: