chore(lint): change linting (#613)

* chore(lint): change linting

fixes #600

* add some more options to change

impacts #169

* reset values to standard

* remove warnings

* add tslint to workspace

* auto fix

* add better tslint rules

* fix some tslint errors

* Restyled by prettier (#621)

Co-authored-by: Restyled.io <commits@restyled.io>

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: 3 people

Phonebook.Frontend/src/app/app.component.ts

@@ -133,7 +133,7 @@ export class AppComponent implements OnInit, OnDestroy {
 
     if (
       DisplayNotificationDialog.version >
-      (this.store.selectSnapshot(AppState.displayedNotificationVersion) | 0)
+      (this.store.selectSnapshot(AppState.displayedNotificationVersion) || 0)
     ) {
       this.matDialog.open(DisplayNotificationDialog, {
         height: '90vh',

Phonebook.Frontend/src/app/modules/feature-flag/feature-flag.service.ts

@@ -38,7 +38,7 @@ export class FeatureFlagService {
    * @param flag The name of the Flag specfied in the FeatureFlags.json
    */
   public get(flag: string): Observable<boolean> {
-    return combineLatest(this.getFlags(), this.flagOverwriteEmitter.pipe(startWith(0))).pipe(
+    return combineLatest([this.getFlags(), this.flagOverwriteEmitter.pipe(startWith(0))]).pipe(
       map(([flags, emitter]) => {
         return this.isEnabled(flag, flags[flag]);
       }),
@@ -113,6 +113,6 @@ export class FeatureFlagService {
 
   public static isFirstApril(date: Date): boolean {
     const firstApril = new Date('2020-04-01T00:00:00');
-    return date.getDate() == firstApril.getDate() && date.getMonth() == firstApril.getMonth();
+    return date.getDate() === firstApril.getDate() && date.getMonth() === firstApril.getMonth();
   }
 }

Phonebook.Frontend/src/app/modules/profile-picture/components/change-profile-picture/change-profile-picture.component.spec.ts

@@ -52,5 +52,5 @@ export class mockCurrentUserService {
   template: '<app-change-profile-picture [userId]="id"></app-change-profile-picture>',
 })
 class TestComponentWrapper {
-  public id = 'test';
+  public id: string = 'test';
 }

Phonebook.Frontend/src/app/modules/profile-picture/components/change-profile-picture/change-profile-picture.component.ts

@@ -16,7 +16,7 @@ export class ChangeProfilePictureComponent implements OnInit {
   @Input()
   public userId: string;
   public currentUserId: string = '';
-  public uploading = false;
+  public uploading: boolean = false;
 
   constructor(
     private profilePictureService: ProfilePictureService,
@@ -47,7 +47,9 @@ export class ChangeProfilePictureComponent implements OnInit {
       .subscribe((upload) => {
         if (upload) {
           this.uploading = true;
-          // This is import because of firefox https://stackoverflow.com/questions/5301643/how-can-i-make-event-srcelement-work-in-firefox-and-what-does-it-mean
+          // This is important because of firefox
+          // https://stackoverflow.com/questions/5301643/how-can-i-make-event-srcelement-work-in-firefox-and-what-does-it-mean
+          // tslint:disable-next-line
           const eventElement = event.target || event.srcElement;
           const files = (eventElement as HTMLInputElement).files;
           if (files != null && files.length > 0) {

Phonebook.Frontend/src/app/modules/profile-picture/components/profile-picture/profile-picture.component.ts

@@ -66,7 +66,7 @@ export class ProfilePictureComponent implements OnInit, OnDestroy {
       });
   }
   private getAprilProfilePictureUrl() {
-    var random = Math.floor(Math.random() * Math.floor(9));
+    const random = Math.floor(Math.random() * Math.floor(9));
     switch (random) {
       case 0:
         return 'assets/img/firstApril/unicorn_1.png';

Phonebook.Frontend/src/app/shared/components/address/address.component.ts

@@ -15,7 +15,5 @@ export class AddressComponent implements OnInit {
     return this.location.RoomCollection[0].Description.split(',');
   }
 
-  constructor() {}
-
   public ngOnInit() {}
 }

Phonebook.Frontend/src/environments/runtime-environment.ts

@@ -1,3 +1,4 @@
+/* tslint:disable:no-invalid-template-strings */
 import { Environment, RuntimeEnvironmentInterface } from 'src/environments/EnvironmentInterfaces';
 
 declare const ENV: RuntimeEnvironmentInterface;

Phonebook.Frontend/src/polyfills.ts

@@ -1,3 +1,4 @@
+/* tslint:disable:no-import-side-effect */
 /**
  * This file includes polyfills needed by Angular and is loaded before the app.
  * You can add your own extra polyfills to this file.

Phonebook.Frontend/src/test.ts

@@ -1,3 +1,4 @@
+/* tslint:disable:no-import-side-effect */
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files
 
 import 'zone.js/dist/long-stack-trace-zone';
@@ -17,6 +18,7 @@ declare const __karma__: any;
 declare const require: any;
 
 // Prevent Karma from running prematurely.
+// tslint:disable-next-line
 __karma__.loaded = function () {};
 
 // First, initialize the Angular testing environment.

Phonebook.Frontend/tsconfig.app.json

@@ -5,7 +5,9 @@
     "types": ["node"],
     "strict": true,
     "strictNullChecks": true,
-    "noImplicitAny": false
+    "noImplicitAny": false,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false
   },
   "angularCompilerOptions": {
     "fullTemplateTypeCheck": true,