fix(no-ie): remove AxtiveX elements

add download links for modern browsers

Author: VanLampe

Phonebook.Frontend/src/index.html

@@ -48,35 +48,27 @@
     }
     msieversion();
 
-    function openURL(e) {
-      browser = e.getAttribute('value');
-      if (browser == 'microsoft-edge') {
-        //edge can not be opened via shell
-        window.open((browser = e.getAttribute('value') + ':' + window.location.href));
-      } else {
-        new ActiveXObject('WScript.Shell').run(browser + ' ' + window.location.href);
-      }
-    }
-
     function msieversion() {
       var browserList = {
-        //list of browser-links where app can be openend in: key=browser name, value=shell-command to open browser
-        'Microsoft Edge': 'microsoft-edge',
-        'Google Chrome': 'chrome',
-        'Mozilla Firefox': 'firefox',
-        Opera: 'opera'
+        //list of browser-links where app can be openend in: key=browser name, value=link for browser download
+        'Google Chrome': 'https://www.google.de/chrome/',
+        'Mozilla Firefox': 'https://www.mozilla.org',
+        Opera: 'https://www.opera.com'
       };
       var ua = window.navigator.userAgent;
       var msie = ua.indexOf('MSIE ');
 
       if (msie > 0 || !!navigator.userAgent.match(/Trident.*rv\:11\./)) {
         // stone age browser IE
         var html =
-          '<div class="pb-no-ie"><p><strong>This application does not support Internet Explorer!</strong></p><p>To run the Phonebook, please use one of the following modern browsers:</p><ul>';
+          '<div class="pb-no-ie"><h1>This application does not support Internet Explorer!</h1><p>To run the Phonebook, please <a href="microsoft-edge:' +
+          window.location.href +
+          '">open it in Microsoft Edge</a></strong> or use one of the following modern browsers:</p><ul><strong>';
         for (var key in browserList) {
-          html += '<li onclick="openURL(this)" value="' + browserList[key] + '"><strong>' + key + '</strong></li>';
+          html += '<li><strong><a href="' + browserList[key] + '" target="_blank">' + key + '</a></strong></li>';
         }
-        html += '</ul><p>If this was detected by mistake consider <a href="https://github.com/T-Systems-MMS/phonebook/issues/new/choose">opening an issue</a>.</p> </div>';
+        html +=
+          '</ul><p>If this was detected by mistake consider <a href="https://github.com/T-Systems-MMS/phonebook/issues/new/choose">opening an issue</a>.</p> </div>';
 
         document.getElementsByTagName('body')[0].innerHTML = html;
       }

Phonebook.Frontend/src/styles.scss

@@ -186,8 +186,9 @@ app-root {
   left: 38%;
   position: absolute;
 }
-.pb-no-ie li {
+.pb-no-ie a {
   cursor: pointer;
+  text-decoration: none;
   &:hover {
     color: #9b9e9e;
   }