fix(app): make rocketChat Link work (#429)

* fix(app): make rocketChat Link work

Fixes: #270

* build(helm): freeze helm version

Author: DanielHabenicht

.azure/pipelines/pr/Phonebook.pr.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - task: HelmInstaller@1
         inputs:
-          helmVersionToInstall: 'latest'
+          helmVersionToInstall: '2.14.2'
       - script: helm dep update
         workingDirectory: 'Phonebook/phonebook/'
       - task: HelmDeploy@0

Phonebook.Demo/values.yml

@@ -12,6 +12,7 @@ employeePictureEndpoint: null
 assetsEndpoint: 'https://demo-phonebook.me/assets'
 environment: 'preview'
 environmentTag: 'demo'
+rocketChatUrl: 'https://open.rocket.chat'
 
 frontend:
   replicaCount: 1

Phonebook.Frontend/src/app/shared/components/user/user-detail/user-detail.component.html

@@ -71,8 +71,7 @@
               >Download Contact</span
             >
           </button>
-          <!-- TODO: Add Chat Link -->
-          <a mat-menu-item target="_blank" rel="noopener" [href]="'example.com/chat' + person.Id.toLowerCase()">
+          <a *ngIf="rocketChatLink" mat-menu-item target="_blank" rel="noopener" [href]="rocketChatLink">
             <mat-icon>chat</mat-icon>
             <span i18n="User-detailComponent|Share Menu: Rocket Chat Option@@UserDetailComponentShareRocketChat"
               >Rocket Chat</span

Phonebook.Frontend/src/app/shared/components/user/user-detail/user-detail.component.ts

@@ -10,6 +10,7 @@ import { WindowRef } from 'src/app/services/windowRef.service';
 import { ColumnDefinitions } from 'src/app/shared/config/columnDefinitions';
 import { Person, PersonStatus } from 'src/app/shared/models';
 import { BookmarksState, ToggleBookmark } from 'src/app/shared/states';
+import { runtimeEnvironment } from 'src/environments/runtime-environment';
 
 @Component({
   selector: 'app-user-detail',
@@ -34,6 +35,7 @@ export class UserDetailComponent implements OnInit, OnDestroy {
 
   @Input()
   public previewView: boolean = false;
+  public rocketChatLink: string | null = null;
   constructor(
     private snackBar: MatSnackBar,
     private mailService: MailService,
@@ -44,6 +46,7 @@ export class UserDetailComponent implements OnInit, OnDestroy {
 
   public ngOnInit() {
     this.getRandomMoney();
+    this.rocketChatLink = this.getRocketChatLink();
     this.bookmarks$.pipe(untilComponentDestroyed(this)).subscribe(bookmarks => {
       const index = bookmarks.findIndex(p => p.Id === this.person.Id);
       if (index > -1) {
@@ -94,6 +97,10 @@ export class UserDetailComponent implements OnInit, OnDestroy {
     this.store.dispatch(new ToggleBookmark(this.person));
   }
 
+  public getRocketChatLink(): string | null {
+    return runtimeEnvironment.rocketChatUrl !== undefined ? runtimeEnvironment.rocketChatUrl + '/direct/' + this.person.Id.toLowerCase() : null;
+  }
+
   public ngOnDestroy() {}
 
   @HostListener('click')

Phonebook.Frontend/src/environments/EnvironmentInterfaces.ts

@@ -50,6 +50,10 @@ export interface RuntimeEnvironmentInterface {
    * Your Companies Room Planning Tool Url, that users can use to book rooms for meetings etc.
    **/
   readonly roomPlanningToolUrl?: string;
+  /**
+   * The Base Url of the RocketChat Messenger
+   */
+  readonly rocketChatUrl?: string;
 }
 
 export enum Environment {

Phonebook.Frontend/src/environments/runtime-environment.ts

@@ -10,5 +10,6 @@ export const runtimeEnvironment: RuntimeEnvironmentInterface = {
   assetsEndpoint: ENV.assetsEndpoint !== '${ASSETS_ENDPOINT}' ? ENV.assetsEndpoint : '/external_assets',
   contactEmail: ENV.contactEmail !== '${CONTACT_EMAIL}' ? ENV.contactEmail : undefined,
   roomPlanningToolUrl: ENV.roomPlanningToolUrl !== '${ROOMPLANNINGTOOL_URL}' ? ENV.roomPlanningToolUrl : undefined,
-  contactUrl: ENV.contactUrl !== '${CONTACT_URL}' ? ENV.contactUrl : undefined
+  contactUrl: ENV.contactUrl !== '${CONTACT_URL}' ? ENV.contactUrl : undefined,
+  rocketChatUrl: ENV.rocketChatUrl !== '${ROCKETCHAT_URL}' ? ENV.rocketChatUrl : undefined
 };

Phonebook.Frontend/src/index.html

@@ -15,7 +15,8 @@
         assetsEndpoint: '${ASSETS_ENDPOINT}',
         contactEmail: '${CONTACT_EMAIL}',
         roomPlanningToolUrl: '${ROOMPLANNINGTOOL_URL}',
-        contactUrl: '${CONTACT_URL}'
+        contactUrl: '${CONTACT_URL}',
+        rocketChatUrl: '${ROCKETCHAT_URL}'
       };
     </script>
     <base href="/" />

Phonebook.Frontend/substitute_variables.sh

@@ -4,7 +4,7 @@
 requiredVariables=( BASE_URL SERVER_NAME ENVIRONMENT ENVIRONMENT_TAG ASSETS_ENDPOINT CONTACT_EMAIL CONTACT_URL)
 
 # State all optional variables here
-optionalVariables=( RAVEN_URL EMPLOYEE_PICTURES_ENDPOINT ROOMPLANNINGTOOL_URL)
+optionalVariables=( RAVEN_URL EMPLOYEE_PICTURES_ENDPOINT ROOMPLANNINGTOOL_URL ROCKETCHAT_URL)
 
 # BASE_URL - used througout the whole app (e.g. opensearch.xml) - example: https://example.com/
 

Phonebook/phonebook/templates/frontend-deployment.yaml

@@ -60,6 +60,8 @@ spec:
               value: "{{ .Values.employeePictureEndpoint }}"
             - name: ASSETS_ENDPOINT
               value: "{{ .Values.assetsEndpoint }}"
+            - name: ROCKETCHAT_URL
+              value: "{{ .Values.rocketChatUrl }}"
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
       {{- with .Values.nodeSelector }}

Phonebook/phonebook/values.yaml

@@ -2,7 +2,6 @@
 
 # General Variables
 host: &host 'localhost'
-contactUrl: 'https://github.com/T-Systems-MMS/phonebook/issues'
 
 # Frontend Variables
 frontend: