Support for web API controllers in asp.net core?

[mmoore99]

I have an asp.net core project that includes Web API controllers that inherit from ControllerBase, for example:

[Route("api/customers")]
[ApiController]
public class CustomersController : ControllerBase
{}

R4MVC does not seem to recognize these controllers and does not generate code for them. Is this intentional? If I change the code to inherit from Controller instead of ControllerBase R4MVC includes the controller.

Is there any way to force R4MVC to include these controllers in the code generation process?

[kevinkuszyk]

Hello @mmoore99, thanks for the question and apologies for the delay in getting back to you.

Does your ControllerBase derive from the MVC's Controller class? If so it sounds like we have a bug in the code which discovers controllers:

https://github.com/T4MVC/R4MVC/blob/develop/src/R4Mvc.Tools/ControllerRewriter.cs#L51-L55

If not, then it sounds like we have a gap in our discovery logic. From a quick Google, it looks like we are missing classes annotated with the new [Controller] and [ApiController] attributes.

Either way, we would gladly take a pull request to fix it.

[artiomchi]

Hi Mike,

That's a very good ovservation! Seems like we've missed the fact that for WebAPI controllers, you don't have to inherit from the full controller, as inheriting from ControllerBase is enough.

I'll update the codebase to look at the base class instead.

Note: The [ApiController] attributes are mostly used to enhance some API behaviours, but I don't think they'd affect R4MVC, since the controllers will still handle requests without them.

[artiomchi]

I forgot to mention that after releasing a patch in the CI build, I pushed a new build to NuGet that has this patch deployed.

Could you take a look and confirm that it's working for you as well, @mmoore99?