Skip to content

Commit 362ffd1

Browse files
committed
Improve first-launch profile config UX
see a351dcc
1 parent 0c9f816 commit 362ffd1

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

src/BizHawk.Client.Common/DisplayManager/OSDManager.cs

+4
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ private string MakeFrameCounter()
8383
private readonly List<UIDisplay> _guiTextList = [ ];
8484
private readonly List<UIDisplay> _ramWatchList = [ ];
8585

86+
/// <summary>Clears the queue used by <see cref="AddMessage"/>. You probably don't want to do this.</summary>
87+
public void ClearRegularMessages()
88+
=> _messages.Clear();
89+
8690
public void AddMessage(string message, int? duration = null)
8791
=> _messages.Add(new() {
8892
Message = message,

src/BizHawk.Client.EmuHawk/MainForm.Designer.cs

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/BizHawk.Client.EmuHawk/MainForm.Events.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -1514,12 +1514,13 @@ private void FreezeStatus_Click(object sender, EventArgs e)
15141514

15151515
private void ProfileFirstBootLabel_Click(object sender, EventArgs e)
15161516
{
1517-
// We do not check if the user is actually setting a profile here.
1518-
// This is intentional.
15191517
using var profileForm = new ProfileConfig(Config, this);
1520-
this.ShowDialogWithTempMute(profileForm);
1518+
_ = this.ShowDialogWithTempMute(profileForm); // interpret Cancel as user acklowledgement (there are instructions for re-opening the dialog anyway)
15211519
Config.FirstBoot = false;
15221520
ProfileFirstBootLabel.Visible = false;
1521+
OSD.ClearRegularMessages();
1522+
AddOnScreenMessage("You can find that again at Config > Profiles", duration: 10/*seconds*/); // intentionally left off the ellipsis from the menu item's name as it could be misinterpreted as the message being truncated
1523+
AddOnScreenMessage("All done! Drag+drop a rom to start playing", duration: 10/*seconds*/);
15231524
}
15241525

15251526
private void LinkConnectStatusBarButton_Click(object sender, EventArgs e)

0 commit comments

Comments
 (0)