Remove speed hack on sound off for NES core, I've been told bypassing the APU isn't TAS safe

adelikat · adelikat · commit 9a86b483d77b · 2012-07-05T19:27:07.000Z
diff --git a/BizHawk.MultiClient/Sound.cs b/BizHawk.MultiClient/Sound.cs
@@ -185,6 +185,7 @@ public void UpdateSoundSettings()
 			else
 				DSoundBuffer.Volume = 0 - ((100 - Global.Config.SoundVolume) * 15);
 
+			/* //adelikat: I've been told this isn't TAS safe, so I'm disabling this speed hack
 			if (Global.Emulator is NES)
 			{
 				NES n = Global.Emulator as NES;
@@ -193,6 +194,7 @@ public void UpdateSoundSettings()
 				else
 					n.SoundOn = true;
 			}
+			*/
 		}
 	}
 #else

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,7 @@ public void UpdateSoundSettings()`
`185`	`185`	`else`
`186`	`186`	`DSoundBuffer.Volume = 0 - ((100 - Global.Config.SoundVolume) * 15);`
`187`	`187`
	`188`	`+ /* //adelikat: I've been told this isn't TAS safe, so I'm disabling this speed hack`
`188`	`189`	`if (Global.Emulator is NES)`
`189`	`190`	`{`
`190`	`191`	`NES n = Global.Emulator as NES;`
`@@ -193,6 +194,7 @@ public void UpdateSoundSettings()`
`193`	`194`	`else`
`194`	`195`	`n.SoundOn = true;`
`195`	`196`	`}`
	`197`	`+ */`
`196`	`198`	`}`
`197`	`199`	`}`
`198`	`200`	`#else`