Change voice permissions (#167)

* Remove walled voice section,
* make voice passive by default, restrict active participation to
members with voice or Intermediate+ as well as server boosters,
* allow voice moderators to change voice status,
* cleanup moderator permissions.

Author: michael-kenzel

src/modules/tccpp/components/permissions-manager.ts

@@ -70,7 +70,14 @@ export default class PermissionManager extends BotComponent {
                 deny: [Discord.PermissionsBitField.Flags.EmbedLinks, Discord.PermissionsBitField.Flags.AttachFiles],
             },
             [this.wheatley.roles.moderators.id]: {
-                allow: [Discord.PermissionsBitField.Flags.ManageThreads, Discord.PermissionsBitField.Flags.ViewChannel],
+                allow: [
+                    Discord.PermissionsBitField.Flags.ViewChannel,
+                    Discord.PermissionsBitField.Flags.ManageThreads,
+                    Discord.PermissionsBitField.Flags.Connect,
+                    Discord.PermissionsBitField.Flags.Speak,
+                    Discord.PermissionsBitField.Flags.Stream,
+                    SET_VOICE_STATUS_PERMISSION_BIT,
+                ],
             },
         };
         const off_topic_permissions: permission_overwrites = {
@@ -111,32 +118,26 @@ export default class PermissionManager extends BotComponent {
                 ],
             },
         };
+        const acive_voice_permissions = [
+            Discord.PermissionsBitField.Flags.Speak,
+            Discord.PermissionsBitField.Flags.Stream,
+        ];
         const voice_permissions: permission_overwrites = {
             ...default_permissions,
             [this.wheatley.guild.roles.everyone.id]: {
-                deny: [SET_VOICE_STATUS_PERMISSION_BIT],
+                deny: [...acive_voice_permissions, SET_VOICE_STATUS_PERMISSION_BIT],
             },
+            [this.wheatley.roles.voice.id]: { allow: acive_voice_permissions },
+            [this.wheatley.skill_roles.intermediate.id]: { allow: acive_voice_permissions },
+            [this.wheatley.skill_roles.proficient.id]: { allow: acive_voice_permissions },
+            [this.wheatley.skill_roles.advanced.id]: { allow: acive_voice_permissions },
+            [this.wheatley.skill_roles.expert.id]: { allow: acive_voice_permissions },
+            [this.wheatley.roles.server_booster.id]: { allow: acive_voice_permissions },
             [this.wheatley.roles.no_voice.id]: no_interaction_at_all,
             [this.wheatley.roles.no_off_topic.id]: no_interaction_at_all,
-            [this.wheatley.roles.moderators.id]: {
-                allow: [
-                    Discord.PermissionsBitField.Flags.ViewChannel,
-                    Discord.PermissionsBitField.Flags.Connect,
-                    SET_VOICE_STATUS_PERMISSION_BIT,
-                ],
-            },
-        };
-        const member_voice_channel: permission_overwrites = {
-            ...voice_permissions,
-            [this.wheatley.guild.roles.everyone.id]: {
-                deny: [Discord.PermissionsBitField.Flags.ViewChannel, SET_VOICE_STATUS_PERMISSION_BIT],
+            [this.wheatley.roles.voice_deputy.id]: {
+                allow: [...acive_voice_permissions, SET_VOICE_STATUS_PERMISSION_BIT],
             },
-            [this.wheatley.roles.voice_deputy.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
-            [this.wheatley.skill_roles.intermediate.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
-            [this.wheatley.skill_roles.proficient.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
-            [this.wheatley.skill_roles.advanced.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
-            [this.wheatley.skill_roles.expert.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
-            [this.wheatley.roles.server_booster.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] },
         };
         const mod_only_channel: permission_overwrites = {
             [this.wheatley.guild.roles.everyone.id]: {
@@ -308,9 +309,6 @@ export default class PermissionManager extends BotComponent {
         // bot dev overrides
         this.add_channel_overwrite(this.wheatley.channels.bot_dev_internal, mod_only_channel);
         // voice overrides
-        this.add_channel_overwrite(this.wheatley.channels.chill, member_voice_channel);
-        this.add_channel_overwrite(this.wheatley.channels.work_3, member_voice_channel);
-        this.add_channel_overwrite(this.wheatley.channels.work_4, member_voice_channel);
         this.add_channel_overwrite(this.wheatley.channels.afk, {
             [this.wheatley.guild.roles.everyone.id]: {
                 deny: [