Fixes for new eslint

Author: jeremy-rifkin

src/bot-utilities.ts

@@ -157,7 +157,7 @@ export class BotUtilities {
                             type: "image",
                             attachment: {
                                 attachment: unwrap(e.image ? e.image : e.thumbnail).url,
-                            } as Discord.AttachmentPayload,
+                            },
                         };
                     } else if (e.video) {
                         // video but no thumbnail? just fallthrough...

src/command-abstractions/button.ts

@@ -175,12 +175,7 @@ export class ButtonInteractionBuilder<
             return undefined as ConditionalOptional<HasHandler, BotButtonHandler<Args>>;
         }
 
-        return new BotButtonHandler(
-            this.base_custom_id,
-            this.handler,
-            this.permissions,
-            this.metadata_fields,
-        ) as ConditionalOptional<HasHandler, BotButtonHandler<Args>>;
+        return new BotButtonHandler(this.base_custom_id, this.handler, this.permissions, this.metadata_fields);
     }
 
     build_button(): BotButton<Args> {

src/command-abstractions/modal.ts

@@ -373,7 +373,7 @@ export class ModalInteractionBuilder<
             this.permissions,
             this.metadata_fields,
             this.field_configs,
-        ) as ConditionalOptional<HasHandler, BotModalHandler<Args>>;
+        );
     }
 
     build_modal(): BotModal<Args> {

src/command-abstractions/text-based-command.ts

@@ -205,9 +205,7 @@ export class TextBasedCommand {
 
     make_message_options(
         raw_message_options:
-            | string
-            | (Discord.BaseMessageOptions & CommandAbstractionReplyOptions)
-            | Discord.MessageEditOptions,
+            string | (Discord.BaseMessageOptions & CommandAbstractionReplyOptions) | Discord.MessageEditOptions,
         positional_ephemeral_if_possible = false,
         positional_should_text_reply = false,
     ) {

src/modules/tccpp/components/starboard.ts

@@ -252,9 +252,9 @@ export default class Starboard extends BotComponent {
             } else {
                 return reaction.count >= star_threshold;
             }
-        } else if (
-            !(this.negative_emojis.includes(reaction.emoji.name) || this.ignored_emojis.includes(reaction.emoji.name))
-        ) {
+        } else if (!(
+            this.negative_emojis.includes(reaction.emoji.name) || this.ignored_emojis.includes(reaction.emoji.name)
+        )) {
             if (parent_channel_id == this.channels.memes.id) {
                 return reaction.count >= memes_other_threshold;
             } else {

src/modules/wheatley/components/username-manager.ts

@@ -22,7 +22,7 @@ function is_all_ascii(str: string) {
 function has_three_continuous_valid_asciis(str: string) {
     let index: number;
     let consecutive_count = 0;
-    for (index = 0; index < str.length; ) {
+    for (index = 0; index < str.length;) {
         let point = str.codePointAt(index);
         assert(point !== undefined);
         if (point > 32 && point < 127) {

src/modules/wheatley/components/wiki.ts

@@ -641,14 +641,12 @@ export default class Wiki extends BotComponent {
 
     async wiki_preview(command: TextBasedCommand, content: string) {
         const channel = await command.get_channel();
-        if (
-            !(
-                this.wheatley.freestanding ||
-                channel.id === this.channels.bot_spam.id ||
-                (channel.isThread() && channel.parentId === this.channels.bot_spam.id) ||
-                channel.isDMBased()
-            )
-        ) {
+        if (!(
+            this.wheatley.freestanding ||
+            channel.id === this.channels.bot_spam.id ||
+            (channel.isThread() && channel.parentId === this.channels.bot_spam.id) ||
+            channel.isDMBased()
+        )) {
             await command.reply(
                 `!wiki-preview must be used in <#${this.channels.bot_spam.id}>, a bot-spam thread, or a DM`,
                 true,