Skip cloning packet, for performance reasons

PaulBGD · PaulBGD · commit 4941893bf377 · 2021-05-07T14:32:02.000-05:00
diff --git a/Plugin/src/main/java/com/gmail/filoghost/holographicdisplays/bridge/protocollib/current/ProtocolLibHookImpl.java b/Plugin/src/main/java/com/gmail/filoghost/holographicdisplays/bridge/protocollib/current/ProtocolLibHookImpl.java
@@ -123,7 +123,7 @@ public void onPacketSending(PacketEvent event) {
 							return;
 						}
 						
-						spawnEntityPacket = new WrapperPlayServerSpawnEntityLiving(packet.deepClone());
+						spawnEntityPacket = new WrapperPlayServerSpawnEntityLiving(packet);
 						WrappedWatchableObject customNameWatchableObject = metadataHelper.getCustomNameWacthableObject(spawnEntityPacket.getMetadata());
 						
 						if (customNameWatchableObject == null) {
@@ -164,7 +164,7 @@ public void onPacketSending(PacketEvent event) {
 							return;
 						}
 						
-						entityMetadataPacket = new WrapperPlayServerEntityMetadata(packet.deepClone());
+						entityMetadataPacket = new WrapperPlayServerEntityMetadata(packet);
 						WrappedWatchableObject customNameWatchableObject = metadataHelper.getCustomNameWatchableObject(entityMetadataPacket.getEntityMetadata());
 						
 						if (customNameWatchableObject == null) {

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public void onPacketSending(PacketEvent event) {`
`123`	`123`	`return;`
`124`	`124`	`}`
`125`	`125`
`126`		`- spawnEntityPacket = new WrapperPlayServerSpawnEntityLiving(packet.deepClone());`
	`126`	`+ spawnEntityPacket = new WrapperPlayServerSpawnEntityLiving(packet);`
`127`	`127`	`WrappedWatchableObject customNameWatchableObject = metadataHelper.getCustomNameWacthableObject(spawnEntityPacket.getMetadata());`
`128`	`128`
`129`	`129`	`if (customNameWatchableObject == null) {`
`@@ -164,7 +164,7 @@ public void onPacketSending(PacketEvent event) {`
`164`	`164`	`return;`
`165`	`165`	`}`
`166`	`166`
`167`		`- entityMetadataPacket = new WrapperPlayServerEntityMetadata(packet.deepClone());`
	`167`	`+ entityMetadataPacket = new WrapperPlayServerEntityMetadata(packet);`
`168`	`168`	`WrappedWatchableObject customNameWatchableObject = metadataHelper.getCustomNameWatchableObject(entityMetadataPacket.getEntityMetadata());`
`169`	`169`
`170`	`170`	`if (customNameWatchableObject == null) {`