Annotation scroll to time broken

[geourjoa]

Use this manifest sample : https://files.tetras-libre.fr/dev/vertical_video_with_annot.json

The annotation with the link is set to 4 to 12s.

If my time is zero and I clik on the annotation I move to 4.
If I'm on any other time than zero I dont move

Comportment seem working in 1.0.21 = ad2f060

[Drilio]

The issue look more like when you are at a time of the video BEFORE the starting time of the annotation it works but not the overway

[Drilio]

I have a fix but I noticed some weird behavior when video is running, This behaviors were present before my fix. I'll try to fix this and then implement the fix

[Drilio]

Ok I think I have fix this but I removed some of your code @geourjoa and I'm sure it was there for some good reasons, can you review this and explain why this code was there : https://github.com/TETRAS-IIIF/mirador-video/tree/61-annotation-scroll-to-time-broken

[geourjoa]

@Drilio
I test and dont find any problem.
I find the commit where I add this code 01419bf.

The problem fixed was not appearing after removing it. Fixed was done like it was working before. As the commit was done on march and we have switch a lot of code since, the fix is probably no longer useful. I merge like that

EDIT I reply on change in AnnotationOverlay

For Change in CanvasAnnotations : 69c19f6

I was coming from a merge commit. It's no longer present in upstream. So good to removed it also