fix(ci): satisfy shell quality checks

Author: reacher-z

.github/workflows/ci.yml

@@ -19,10 +19,10 @@ jobs:
     name: Static quality and data integrity
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-depth: 0
-      - uses: actions/setup-python@v5
+      - uses: actions/setup-python@v6
         with:
           python-version: "3.10"
           cache: pip
@@ -52,10 +52,10 @@ jobs:
         python-version: ["3.10", "3.11", "3.12"]
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
           cache: pip
@@ -77,10 +77,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Set up Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.10"
           cache: pip

.github/workflows/release.yml

@@ -11,8 +11,8 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
+      - uses: actions/checkout@v5
+      - uses: actions/setup-python@v6
         with:
           python-version: "3.10"
       - run: python -m pip install -r requirements-dev.txt

scripts/_kill_vllm.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 # Kill vLLM processes safely without affecting parent
 trap '' TERM HUP

scripts/_launch_all_vllm.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 # Launch one vLLM instance per GPU and keep the script alive.
 # Respects the same env-var conventions as scripts/serve_vllm_multi.sh:

scripts/check_links.sh

@@ -11,11 +11,12 @@
 #   bash scripts/check_links.sh             # local file checks only (fast)
 #   bash scripts/check_links.sh --external  # also curl every external URL
 
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
-cd "$PROJECT_ROOT"
+cd "$PROJECT_ROOT" || exit
 
 CHECK_EXTERNAL=0
 [ "${1:-}" = "--external" ] && CHECK_EXTERNAL=1

scripts/download_data.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
 # download_data.sh — Download datasets for RewardHarness pipeline
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

scripts/lib/common.sh

@@ -5,6 +5,7 @@ set -Eeuo pipefail
 
 RH_PROJECT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
 RH_PYTHON="${VLLM_PYTHON:-python}"
+export RH_PROJECT_ROOT RH_PYTHON
 readonly RH_PROJECT_ROOT RH_PYTHON
 
 rh_log() {

scripts/reproduce.sh

@@ -1,11 +1,12 @@
 #!/usr/bin/env bash
 # reproduce.sh — End-to-end reproducibility script for RewardHarness
 # Runs setup → download → serve → evolution → benchmark → print results
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
-cd "$PROJECT_ROOT"
+cd "$PROJECT_ROOT" || exit
 
 VLLM_PIDS=()
 
@@ -20,7 +21,9 @@ cleanup() {
         while IFS= read -r url; do
             [[ -z "$url" || "$url" =~ ^# ]] && continue
             port=$(echo "$url" | sed -nE 's#.*:([0-9]+).*#\1#p')
-            [ -n "$port" ] && fuser -k "$port/tcp" 2>/dev/null || true
+            if [ -n "$port" ]; then
+                fuser -k "$port/tcp" 2>/dev/null || true
+            fi
         done < configs/endpoints.txt
     fi
     wait 2>/dev/null || true

scripts/run_all_benchmarks.sh

@@ -2,6 +2,7 @@
 # Run benchmarks on ALL checkpoints (iter_0 through iter_9) sequentially.
 # Each benchmark takes ~7 min, total ~70 min.
 # Results saved to results/benchmark_iter_N.json
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 
 PYTHON="${VLLM_PYTHON:-python}"

scripts/run_evolution_seed.sh

@@ -1,6 +1,7 @@
 #!/usr/bin/env bash
 # Run evolution with a specific seed. Creates isolated library + results.
 # Usage: bash scripts/run_evolution_seed.sh <seed> [max_iters]
+# shellcheck source=scripts/lib/common.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/common.sh"
 
 SEED="${1:?Usage: $0 <seed> [max_iters]}"