Move solve and svd into nda::linalg namespace

Author: Thoemi09

c++/nda/linalg/matmul.hpp

@@ -57,9 +57,9 @@ namespace nda {
     static constexpr bool is_valid_gemm_triple = []() {
       using blas::has_F_layout;
       if constexpr (has_F_layout<C>) {
-        return !(conj_A and has_F_layout<A>)and!(conj_B and has_F_layout<B>);
+        return !(conj_A and has_F_layout<A>) and !(conj_B and has_F_layout<B>);
       } else {
-        return !(conj_B and !has_F_layout<B>)and!(conj_A and !has_F_layout<A>);
+        return !(conj_B and !has_F_layout<B>) and !(conj_A and !has_F_layout<A>);
       }
     }();
 

c++/nda/linalg/solve.hpp

@@ -36,7 +36,7 @@
 
 #include <type_traits>
 
-namespace nda {
+namespace nda::linalg {
 
   /**
    * @addtogroup linalg_tools
@@ -107,4 +107,4 @@ namespace nda {
 
   /** @} */
 
-} // namespace nda
+} // namespace nda::linalg

c++/nda/linalg/svd.hpp

@@ -36,7 +36,7 @@
 #include <tuple>
 #include <type_traits>
 
-namespace nda {
+namespace nda::linalg {
 
   /**
    * @addtogroup linalg_tools
@@ -49,7 +49,7 @@ namespace nda {
     template <MemoryMatrix A>
       requires(is_blas_lapack_v<get_value_t<A>>)
     auto svd_in_place(A &&a) { // NOLINT (temporary views are allowed here)
-      using layout_policy       = detail::layout_to_policy<typename std::remove_cvref_t<A>::layout_t>::type;
+      using layout_policy       = nda::detail::layout_to_policy<typename std::remove_cvref_t<A>::layout_t>::type;
       constexpr auto addr_space = mem::get_addr_space<A>;
 
       // vector s and matrices U and V^H
@@ -95,4 +95,4 @@ namespace nda {
 
   /** @} */
 
-} // namespace nda
+} // namespace nda::linalg

test/c++/nda_linear_algebra.cpp

@@ -407,12 +407,12 @@ void test_solve() {
   EXPECT_ARRAY_NEAR(matrix_t{A * X}, B);
 
   // solve A * X = B using solve
-  auto X2 = nda::solve(A, B);
+  auto X2 = nda::linalg::solve(A, B);
   EXPECT_ARRAY_NEAR(matrix_t{A * X2}, B);
   EXPECT_ARRAY_NEAR(X, X2);
 
   // solve A * x = b using solve
-  auto x = nda::solve(A, B(nda::range::all, 0));
+  auto x = nda::linalg::solve(A, B(nda::range::all, 0));
   EXPECT_ARRAY_NEAR(A * x, B(nda::range::all, 0));
   EXPECT_ARRAY_NEAR(X(nda::range::all, 0), x);
 }
@@ -433,7 +433,7 @@ void test_svd() {
   auto s = nda::vector<double>{12, 3};
 
   // compute the SVD of A
-  auto [U_1, s_1, VH_1] = nda::svd(A);
+  auto [U_1, s_1, VH_1] = nda::linalg::svd(A);
   auto S_1              = matrix_t::zeros(A.shape());
   diagonal(S_1)         = s_1;
   EXPECT_ARRAY_NEAR(s_1, s, 1e-14);