Skip to content

gen.cruise and gen.complete error in parameter documentation #32

@yecarri

Description

@yecarri

cruise and completefunctions documentation states that range_cr is expressed in kilometers.

def cruise(self, **kwargs) -> pd.DataFrame:
        """Generate descent trajectory based on WRAP model.

        Args:
            **dt (int): Time step in seconds.
            **range_cr (int): Cruise range (km).
            **alt_cr (int): Cruise altitude (ft).
            **mach_cr (float): Cruise Mach number (-).
            **random (bool): Generate trajectory with random parameters.

        """

Nevertheless, if I do

import pandas as pd
from openap.gen import FlightGenerator
fgen = FlightGenerator('B789')
cruise = fgen.cruise(dt=60, range_cr=1000)
print(cruise)

I get:

   t        h  s           v  vs  altitude  vertical_rate  groundspeed   alt_cr  mach_cr
0  0  11582.4  0  250.809069   0     38000              0          487  38000.0     0.85

That makes no sense. 1000 kilometers at a ground speed of 487 kt takes around 1.1 hours but I am getting ONE time frame (dt=60) which means the function takes range_cr as meters.

Moreover, in the code I can see that, whenever range_cr is defaulted or random, it is multiplied times 1000. WASP is returning the default in meters. This is consistent with the assumptiuon that range_cr should indeed be in meters, against what the documentation says.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions