Do not assign global logger variable in getLogger

peterhellberg · peterhellberg · commit 38c3c4980bed · 2018-03-09T10:33:16.000+01:00
Issue reported by @SpComb in 1e16ac3#r28010982
diff --git a/graceful.go b/graceful.go
@@ -218,8 +218,8 @@ func shutdown(s Shutdowner, logger Logger) {
 
 func getLogger(loggers ...Logger) Logger {
 	if len(loggers) > 0 {
-		if logger = loggers[0]; logger != nil {
-			return logger
+		if loggers[0] != nil {
+			return loggers[0]
 		}
 
 		return log.New(ioutil.Discard, "", 0)

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ func shutdown(s Shutdowner, logger Logger) {`
`218`	`218`
`219`	`219`	`func getLogger(loggers ...Logger) Logger {`
`220`	`220`	`if len(loggers) > 0 {`
`221`		`- if logger = loggers[0]; logger != nil {`
`222`		`- return logger`
	`221`	`+ if loggers[0] != nil {`
	`222`	`+ return loggers[0]`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`return log.New(ioutil.Discard, "", 0)`