[assembler] Clippy: enable, fix manual_assert.

Author: youngman-g

assembler/src/asmlib/ast.rs

@@ -1870,7 +1870,7 @@ impl InstructionSequence {
             }
 
             if self.local_symbols.is_some() {
-                panic!(
+                unimplemented!(
                     "InstructionSequence::build_binary_block: evaluation with local symbol tables is not yet implemented"
                 );
             }

assembler/src/asmlib/driver/output.rs

@@ -146,7 +146,7 @@ fn create_begin_block(
             // should closely examine what appear to be the original
             // (TX-2 assembly language) programmer's assumptions about
             // what will happen.
-            panic!(
+            unimplemented!(
                 "PUNCH directive specifies deferred start address {start:o}; this is (deliberately) not yet supported - check carefully!"
             );
         }

assembler/src/asmlib/driver/tests.rs

@@ -54,11 +54,10 @@ fn assemble_check_symbols(
         let scope = ScopeIdentifier::global();
         match evaluate_symbol(&sym, Script::Normal, span, &mut ctx, scope) {
             Ok(got) => {
-                if got != *expected_value {
-                    panic!(
-                        "incorrect value for symbol {name}; expected {expected_value:?}, got {got:?}"
-                    );
-                }
+                assert_eq!(
+                    got, *expected_value,
+                    "incorrect value for symbol {name}; expected {expected_value:?}, got {got:?}"
+                );
             }
             Err(e) => {
                 panic!("unexpected error looking up value for symbol {name}: {e:?}");

assembler/src/asmlib/eval.rs

@@ -506,12 +506,11 @@ impl RcAllocator for RcBlock {
 
 impl RcUpdater for RcBlock {
     fn update(&mut self, address: Address, value: Unsigned36Bit) {
-        if address < self.address {
-            panic!(
-                "out of range access to address {address} of RC-block starting at {}",
-                self.address
-            );
-        }
+        assert!(
+            address >= self.address,
+            "out of range access to address {address} of RC-block starting at {}",
+            self.address
+        );
         match Unsigned18Bit::from(address).checked_sub(Unsigned18Bit::from(self.address)) {
             Some(offset) => match self.words.get_mut(usize::from(offset)) {
                 Some((_source, spot)) => {

assembler/src/asmlib/lib.rs

@@ -21,7 +21,6 @@
 #![allow(clippy::default_trait_access)] // fix later
 #![allow(clippy::match_wild_err_arm)] // fix later
 #![allow(clippy::verbose_bit_mask)] // fix later
-#![allow(clippy::manual_assert)] // fix soon
 #![allow(clippy::if_not_else)] // fix soon
 #![allow(clippy::doc_markdown)] // fix soon
 #![allow(clippy::needless_pass_by_value)] // fix soon

assembler/src/asmlib/parser/tests.rs

@@ -1453,11 +1453,10 @@ fn test_subs() {
             parse_multi_syllable_symex(SymexSyllableRule::Multiple, Script::Normal),
             no_state_setup,
         );
-        if got != expected {
-            panic!(
-                "Parsing '{input}' with parse_multi_syllable_symex, expected '{expected}', got '{got}'"
-            );
-        }
+        assert_eq!(
+            got, expected,
+            "Parsing '{input}' with parse_multi_syllable_symex, expected '{expected}', got '{got}'"
+        );
     }
 
     check("@beta@", "β");
@@ -1485,11 +1484,10 @@ fn test_greek_letters() {
             parse_multi_syllable_symex(SymexSyllableRule::Multiple, Script::Normal),
             no_state_setup,
         );
-        if got != input {
-            panic!(
-                "Parsing '{input}' with parse_multi_syllable_symex, expected '{input}', got '{got}'"
-            );
-        }
+        assert_eq!(
+            got, input,
+            "Parsing '{input}' with parse_multi_syllable_symex, expected '{input}', got '{got}'"
+        );
     }
     check("β");
     check("γ");
@@ -2699,11 +2697,11 @@ fn test_make_bit_designator_literal() {
                     BitDesignatorValidation::Good(literal) => {
                         dbg!(&literal);
                         let n = literal.unshifted_value();
-                        if (n & (!MASK)) != 0 {
-                            panic!(
-                                "bit designator {what} produced output {n:o} but that has bits set outside the allowed mask {MASK:o}"
-                            );
-                        }
+                        assert_eq!(
+                            (n & (!MASK)),
+                            0,
+                            "bit designator {what} produced output {n:o} but that has bits set outside the allowed mask {MASK:o}"
+                        );
                         if let Some((prevq, prevb)) = seen.insert(n, (q, bit)) {
                             panic!(
                                 "two distinct bit designators both evaluate to {n}: {what} and {}",

assembler/src/asmlib/readerleader.rs

@@ -14,9 +14,7 @@ fn bit_index(q: u8, bitnum: u8) -> Unsigned6Bit {
             panic!("invalid quarter number {q}");
         }
     };
-    if bitnum > 12 {
-        panic!("invalid bit number {bitnum}");
-    }
+    assert!(bitnum <= 12, "invalid bit number {bitnum}");
     Unsigned6Bit::try_from((quarter << 4) | bitnum).unwrap()
 }