Skip to content

Commit f55be92

Browse files
committed
Eliminate less-efficient (because separate) CI jobs.
1 parent 210f52c commit f55be92

File tree

1 file changed

+7
-45
lines changed

1 file changed

+7
-45
lines changed

.github/workflows/quickstart.yml

Lines changed: 7 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@ jobs:
1818

1919
# These "X_and_Y" jobs each combine some steps that previously
2020
# existed in separate jobs, because combining them is more
21-
# efficient.
21+
# resource-efficient.
22+
#
23+
# The two remaining jobs are still separate because it's useful to
24+
# be able easily to see that a change passes all tests but just has
25+
# clippy issues.
26+
2227
build_and_test:
2328
# Combines previous Check, Build (stable), Test Suite (Rust stable)
2429
name: Check, Build and Test (Rust stable)
@@ -32,53 +37,10 @@ jobs:
3237

3338
fmt_and_clippy:
3439
# Combines previous Rustfmt (stable) and Clippy (stable) jobs
35-
name: Format and Lint Checks
40+
name: Format and Lint Checks (Rust stable)
3641
runs-on: ubuntu-latest
3742
steps:
3843
- uses: actions/checkout@v4
3944
- uses: dtolnay/rust-toolchain@stable
4045
- run: cargo fmt --all --check
4146
- run: cargo clippy --workspace -- -D warnings
42-
43-
# The following jobs are not combined, and so are less efficient.
44-
# We plan to remove these if the combined jobs above work OK.
45-
46-
check:
47-
name: Check
48-
runs-on: ubuntu-latest
49-
steps:
50-
- uses: actions/checkout@v4
51-
- uses: dtolnay/rust-toolchain@stable
52-
- run: cargo check --workspace --all-features
53-
54-
build:
55-
name: Build (stable)
56-
runs-on: ubuntu-latest
57-
steps:
58-
- uses: actions/checkout@v4
59-
- uses: dtolnay/rust-toolchain@stable
60-
- run: cargo build --workspace --all-features
61-
62-
test:
63-
name: Test Suite (Rust stable)
64-
runs-on: ubuntu-latest
65-
steps:
66-
- uses: actions/checkout@v4
67-
- uses: dtolnay/rust-toolchain@stable
68-
- run: cargo test --workspace --all-features
69-
70-
fmt:
71-
name: Rustfmt (stable)
72-
runs-on: ubuntu-latest
73-
steps:
74-
- uses: actions/checkout@v4
75-
- uses: dtolnay/rust-toolchain@stable
76-
- run: cargo fmt --all --check
77-
78-
clippy:
79-
name: Clippy (stable)
80-
runs-on: ubuntu-latest
81-
steps:
82-
- uses: actions/checkout@v4
83-
- uses: dtolnay/rust-toolchain@stable
84-
- run: cargo clippy --workspace -- -D warnings

0 commit comments

Comments
 (0)