[BUGFIX] Avoid wrongly detected class names (#691)

resolves #686

Author: linawolf

Documentation-rendertest/PhpInline/Index.rst

@@ -40,3 +40,13 @@ In short:
 *   :php-short:`\TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper`
 *   :php-short:`\MyVendor\MyExtension\FooBar`
 *   :php-short:`\Foo\Bar\Something`
+
+A new PSR-14 event :php:`TYPO3\CMS\Backend\RecordList\Event\BeforeRecordDownloadIsExecutedEvent`
+has been introduced to modify the result of a download / export initiated via
+the :guilabel:`Web > List` module.
+
+This replaces the
+:php:`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList']['customizeCsvHeader']`
+and
+:php:`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList']['customizeCsvRow']`,
+hooks, which have been :ref:`deprecated <changelog:deprecation-102337-1715591179>`.

packages/typo3-docs-theme/src/TextRoles/PhpTextRole.php

@@ -5,15 +5,19 @@
 use phpDocumentor\Guides\Nodes\Inline\InlineNode;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\TextRoles\TextRole;
-use T3Docs\GuidesPhpDomain\PhpDomain\FullyQualifiedNameService;
 use T3Docs\Typo3DocsTheme\Api\Typo3ApiService;
 use T3Docs\Typo3DocsTheme\Inventory\Typo3VersionService;
 use T3Docs\Typo3DocsTheme\Nodes\Inline\CodeInlineNode;
 
 final class PhpTextRole implements TextRole
 {
+    /**
+     * @see https://regex101.com/r/LN5Ick/1
+     */
+    final public const CLASS_NAME_PATTERN_REGEX = '/^(\\\\)?[A-Za-z_][A-Za-z0-9_]*(\\\\[A-Za-z_][A-Za-z0-9_]*)*$/';
+
+
     public function __construct(
-        private readonly FullyQualifiedNameService $fullyQualifiedNameService,
         private readonly Typo3ApiService $typo3ApiService,
         private readonly Typo3VersionService $typo3VersionService,
     ) {}
@@ -34,7 +38,7 @@ public function processNode(DocumentParserContext $documentParserContext, string
     {
         $fqn = [];
         $rawContent = trim($rawContent);
-        if (str_contains($rawContent, '\\') && $this->fullyQualifiedNameService->isFullyQualifiedName($rawContent, $fqn)) {
+        if (str_contains($rawContent, '\\') && $this->isClassName($rawContent, $fqn)) {
             if (!str_starts_with($rawContent, '\\')) {
                 $rawContent = '\\' . $rawContent;
             }
@@ -134,7 +138,11 @@ private function getClassCodeNode(string $fqn, array $apiInfo, string $role, str
             }
             $modifiers[] = $apiInfo['type'];
             $infoArray = [];
-            $infoArray[] = '<code>' . implode(' ', $modifiers) . ' ' . $apiInfo['short'] . '</code>: <code>' . $apiInfo['fqn'] . '</code>';
+            $infoArray[] = '<code>' . implode(' ', $modifiers) . ' ' . $apiInfo['short'] . '</code>';
+
+            if ($role === 'php-short') {
+                $infoArray[] =  '<code>' . $apiInfo['fqn'] . '</code>';
+            }
             if ($apiInfo['internal']) {
                 $infoArray[] = 'internal!';
             }
@@ -145,6 +153,7 @@ private function getClassCodeNode(string $fqn, array $apiInfo, string $role, str
                 $infoArray[] = '<em>' . $apiInfo['summary'] . '</em>';
             }
             $info = implode('<br>', $infoArray);
+            $info = str_replace('\\', '&#8203;\\', $info);
             return new CodeInlineNode($name, 'PHP ' . $type, $info, $apiInfo);
         } elseif(str_starts_with($fqn, '\\TYPO3Fluid')) {
             $info = 'This PHP class or interface belongs to Fluid. ';
@@ -177,4 +186,11 @@ private function getClassCodeNode(string $fqn, array $apiInfo, string $role, str
             []
         );
     }
+    /**
+     * @param list<string> $matches
+     */
+    private function isClassName(string $name, array &$matches): bool
+    {
+        return (bool)preg_match(self::CLASS_NAME_PATTERN_REGEX, $name, $matches);
+    }
 }

tests/Integration/tests-full/changelog/expected/Changelog/12.0/Breaking-87616-RemovedHookForAlteringPageLinks.html

@@ -169,7 +169,7 @@ <h2>Description<a class="headerlink" href="#description" data-bs-toggle="modal"
                 settings stored in a global array called $GLOBALS['TYPO3_CONF_VARS'].
                 They are commonly set in config/system/settings.php, config/system/additional.php,
                 or the ext_localconf.php file of an extension. " data-bs-html="true"><a href="https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/Configuration/Typo3ConfVars/Index.html" target="_blank">$GLOBALS[&#039;TYPO3_CONF_VARS&#039;][&#039;SC_OPTIONS&#039;][&#039;typolinkProcessing&#039;][&#039;typolinkModifyParameterForPageLinks&#039;] <span class="text-secondary"><i class="fa-regular fa-circle-question"></i></span></a></code>
-has been removed in favor of a new PSR-14 event <code class="code-inline" translate="no" aria-description="PHP class" aria-details="<code>final class ModifyPageLinkConfigurationEvent</code>: <code>\TYPO3\CMS\Frontend\Event\ModifyPageLinkConfigurationEvent</code><br><em>A generic PSR 14 Event to allow modifying the incoming (and resolved) page when building a &quot;page link&quot;.</em>" data-bs-html="true"><a href="https://api.typo3.org/main/classes/TYPO3-CMS-Frontend-Event-ModifyPageLinkConfigurationEvent.html" target="_blank">\TYPO3\CMS\Frontend\Event\ModifyPageLinkConfigurationEvent <span class="text-secondary"><i class="fa-regular fa-circle-question"></i></span></a></code>.</p>
+has been removed in favor of a new PSR-14 event <code class="code-inline" translate="no" aria-description="PHP class" aria-details="<code>final class ModifyPageLinkConfigurationEvent</code><br><em>A generic PSR 14 Event to allow modifying the incoming (and resolved) page when building a &quot;page link&quot;.</em>" data-bs-html="true"><a href="https://api.typo3.org/main/classes/TYPO3-CMS-Frontend-Event-ModifyPageLinkConfigurationEvent.html" target="_blank">\TYPO3\CMS\Frontend\Event\ModifyPageLinkConfigurationEvent <span class="text-secondary"><i class="fa-regular fa-circle-question"></i></span></a></code>.</p>
 
 
     <p>The event is called after TYPO3 has already prepared some functionality