[BUGFIX] Compare project_issues correctly (#675)

Author: linawolf

packages/typo3-docs-theme/src/Twig/TwigExtension.php

@@ -296,7 +296,7 @@ public function getReportIssueLink(array $context): string
         $reportButton = $this->themeSettings->getSettings('project_issues');
         $reportButton = rtrim($reportButton, '/');
 
-        if (str_starts_with($reportButton, '')) {
+        if ($reportButton === '') {
             return '';
         }
         if (str_starts_with($reportButton, 'https://forge.typo3.org/')) {

tests/Integration/tests-full/changelog/expected/Changelog/12.0/Breaking-87616-RemovedHookForAlteringPageLinks.html

@@ -134,7 +134,11 @@
         <li class="breadcrumb-item"><a href="Index.html">12.0 Changes</a></li>
                     <li aria-current="page"  class="breadcrumb-item  active">Breaking: #87616 - Removed hook for altering page links</li>
         </ol>
-        <div class="breadcrumb-additions">    <a class="btn btn-sm btn-light" href="../../_sources/Changelog/12.0/Breaking-87616-RemovedHookForAlteringPageLinks.rst.txt" rel="nofollow noopener" target="_blank">
+        <div class="breadcrumb-additions">        <a class="btn btn-sm btn-light" href="https://forge.typo3.org/projects/typo3cms-core/issues/new?issue[category_id]=1004&amp;issue[subject]=Problem+on+https%3A%2F%2Fextensions.typo3.org%2Fextension%2Fcore%2F%2FChangelog%2F12.0%2FBreaking-87616-RemovedHookForAlteringPageLinks.html&amp;issue[custom_field_values][4]=main" id="btnReportIssue" rel="nofollow noopener" target="_blank">
+            <span class="btn-icon"><i class="fas fa-bug"></i></span>
+            <span class="btn-text">Report issue</span>
+        </a>
+        <a class="btn btn-sm btn-light" href="../../_sources/Changelog/12.0/Breaking-87616-RemovedHookForAlteringPageLinks.rst.txt" rel="nofollow noopener" target="_blank">
         <span class="btn-icon"><span class="fas fa-code"></span></span>
         <span class="btn-text">View source</span>
     </a>

tests/Integration/tests-full/changelog/expected/Changelog/12.0/Index.html

@@ -134,7 +134,11 @@
         <li class="breadcrumb-item"><a href="../../Changelog-12.html">ChangeLog v12</a></li>
                     <li aria-current="page"  class="breadcrumb-item  active">12.0 Changes</li>
         </ol>
-        <div class="breadcrumb-additions">    <a class="btn btn-sm btn-light" href="../../_sources/Changelog/12.0/Index.rst.txt" rel="nofollow noopener" target="_blank">
+        <div class="breadcrumb-additions">        <a class="btn btn-sm btn-light" href="https://forge.typo3.org/projects/typo3cms-core/issues/new?issue[category_id]=1004&amp;issue[subject]=Problem+on+https%3A%2F%2Fextensions.typo3.org%2Fextension%2Fcore%2F%2FChangelog%2F12.0%2FIndex.html&amp;issue[custom_field_values][4]=main" id="btnReportIssue" rel="nofollow noopener" target="_blank">
+            <span class="btn-icon"><i class="fas fa-bug"></i></span>
+            <span class="btn-text">Report issue</span>
+        </a>
+        <a class="btn btn-sm btn-light" href="../../_sources/Changelog/12.0/Index.rst.txt" rel="nofollow noopener" target="_blank">
         <span class="btn-icon"><span class="fas fa-code"></span></span>
         <span class="btn-text">View source</span>
     </a>

tests/Integration/tests-full/changelog/expected/Index.html

@@ -130,7 +130,11 @@
 <ol class="breadcrumb">
                 <li aria-current="page"  class="breadcrumb-item  active">TYPO3 Core</li>
         </ol>
-        <div class="breadcrumb-additions">    <a class="btn btn-sm btn-light" href="_sources/Index.rst.txt" rel="nofollow noopener" target="_blank">
+        <div class="breadcrumb-additions">        <a class="btn btn-sm btn-light" href="https://forge.typo3.org/projects/typo3cms-core/issues/new?issue[category_id]=1004&amp;issue[subject]=Problem+on+https%3A%2F%2Fextensions.typo3.org%2Fextension%2Fcore%2F%2FIndex.html&amp;issue[custom_field_values][4]=main" id="btnReportIssue" rel="nofollow noopener" target="_blank">
+            <span class="btn-icon"><i class="fas fa-bug"></i></span>
+            <span class="btn-text">Report issue</span>
+        </a>
+        <a class="btn btn-sm btn-light" href="_sources/Index.rst.txt" rel="nofollow noopener" target="_blank">
         <span class="btn-icon"><span class="fas fa-code"></span></span>
         <span class="btn-text">View source</span>
     </a>

tests/Integration/tests-full/changelog/expected/Sitemap.html

@@ -132,7 +132,11 @@
     <li class="breadcrumb-item"><a href="Index.html">TYPO3 Core</a></li>
                     <li aria-current="page"  class="breadcrumb-item  active">Sitemap</li>
         </ol>
-        <div class="breadcrumb-additions">    <a class="btn btn-sm btn-light" href="_sources/Sitemap.rst.txt" rel="nofollow noopener" target="_blank">
+        <div class="breadcrumb-additions">        <a class="btn btn-sm btn-light" href="https://forge.typo3.org/projects/typo3cms-core/issues/new?issue[category_id]=1004&amp;issue[subject]=Problem+on+https%3A%2F%2Fextensions.typo3.org%2Fextension%2Fcore%2F%2FSitemap.html&amp;issue[custom_field_values][4]=main" id="btnReportIssue" rel="nofollow noopener" target="_blank">
+            <span class="btn-icon"><i class="fas fa-bug"></i></span>
+            <span class="btn-text">Report issue</span>
+        </a>
+        <a class="btn btn-sm btn-light" href="_sources/Sitemap.rst.txt" rel="nofollow noopener" target="_blank">
         <span class="btn-icon"><span class="fas fa-code"></span></span>
         <span class="btn-text">View source</span>
     </a>

tests/Integration/tests-full/report-issue/project-issue-github/expected/index.html

@@ -105,7 +105,11 @@
 <ol class="breadcrumb">
                 <li aria-current="page"  class="breadcrumb-item  active">Document Title</li>
         </ol>
-        <div class="breadcrumb-additions">    <a class="btn btn-sm btn-light" href="_sources/index.rst.txt" rel="nofollow noopener" target="_blank">
+        <div class="breadcrumb-additions">        <a class="btn btn-sm btn-light" href="https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/issues/new/choose?title=Problem+on+%2Findex.html" id="btnReportIssue" rel="nofollow noopener" target="_blank">
+            <span class="btn-icon"><i class="fas fa-bug"></i></span>
+            <span class="btn-text">Report issue</span>
+        </a>
+        <a class="btn btn-sm btn-light" href="_sources/index.rst.txt" rel="nofollow noopener" target="_blank">
         <span class="btn-icon"><span class="fas fa-code"></span></span>
         <span class="btn-text">View source</span>
     </a>
@@ -220,7 +224,7 @@ <h5 class="modal-title" id="generalModalLabel"></h5>
         <div class="frame-container">
             <div class="frame-inner">
                 <ul class="footer-simplemenu">
-                                                                        <li><a href="https://github.com/TYPO3-Documentation/render-guides/issues/new" rel="nofollow noopener" title="Issues"><span>Issues</span></a></li>
+                                                                        <li><a href="https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/issues" rel="nofollow noopener" title="Issues"><span>Issues</span></a></li>
                                                                     </ul>                <div class="footer-additional">
                     <p class="text-center">Last rendered: Jan 01, 2023 12:00</p>
                 </div>

tests/Integration/tests-full/report-issue/project-issue-github/input/guides.xml

@@ -7,6 +7,6 @@
 
     <project title="Lorem Ipsum"/>
     <extension class="\T3Docs\Typo3DocsTheme\DependencyInjection\Typo3DocsThemeExtension"
-               project-issues="https://github.com/TYPO3-Documentation/render-guides/issues/new"
+               project-issues="https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/issues"
     />
 </guides>