refactor(linux): A4 driver_id helper + A5 StatusKind enum

Two High-tier audit items the per-day sprint slices missed.

A4 (latent SQL-quoting bug):
The fallback `current_driver_id.clone().unwrap_or_else(|| "postgres".to_string())`
was duplicated at 7 call sites across browse.rs and row_ops.rs. If anything
ever produced a non-Postgres connection without setting current_driver_id,
quote_ident would silently corrupt SQL.

Collapsed to a single `App::driver_id(&self) -> &str` helper in app/mod.rs
that logs `tracing::warn!` on the fallback path so the bug becomes visible
the first time it triggers. Call sites now just `self.driver_id().to_string()`.

A5 (i18n correctness):
`set_status_page` reverse-engineered caller intent by sniffing localised
title strings:

    if title.eq_ignore_ascii_case("failed") || title.to_lowercase().contains("error")

Breaks the moment a translation uses different vocabulary for "Failed" /
"Error" / "No connection". Replaced with an explicit `StatusKind` enum
(Info / Error / Disconnected) and `kind.icon()` returning the symbolic
icon name. All 4 callers updated to pass the kind explicitly:
- browse.rs `on_load_failed` → Error
- connection.rs `on_connected` → Info
- editor_tabs.rs `on_open_editor` → Disconnected
- editor_tabs.rs `show_welcome_or_grid_after_editor_close` → Info

Verification:
- cargo clippy --workspace --all-targets -- -D warnings: zero warnings
- cargo test --workspace --lib: 43 pass, 1 ignored
- cargo fmt --all -- --check: clean

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: datlechin

linux/crates/app/src/ui/app/browse.rs

@@ -8,7 +8,7 @@ use crate::services::database_service;
 use crate::ui::editor::update_schema_buffer;
 use crate::ui::grid::build_column_view;
 
-use super::{App, AppMsg, ExportFormat, clear_box, qualified_label, render_csv, render_json};
+use super::{App, AppMsg, ExportFormat, StatusKind, clear_box, qualified_label, render_csv, render_json};
 
 impl App {
     pub(super) fn on_select_table(&mut self, schema: Option<String>, name: String, sender: ComponentSender<Self>) {
@@ -33,7 +33,7 @@ impl App {
         let Some(conn) = database_service::instance().active() else {
             return;
         };
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let table_for_async = table.clone();
         let sender_clone = sender.clone();
         sender.command(move |_, shutdown| {
@@ -206,7 +206,7 @@ impl App {
     pub(super) fn on_load_failed(&self, msg: String) {
         tracing::warn!(error = %msg, "load failed");
         self.set_row_op_in_flight(false);
-        self.set_status_page(&crate::tr!("Failed"), &msg);
+        self.set_status_page(StatusKind::Error, &crate::tr!("Failed"), &msg);
     }
 
     pub(super) fn fetch_current_page(&self, sender: ComponentSender<App>) {
@@ -220,7 +220,7 @@ impl App {
             sender.input(AppMsg::LoadFailed("no active connection".into()));
             return;
         };
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let order_by = self.current_sort.and_then(|(idx, asc)| {
             self.current_columns.get(idx).map(|c| {
                 let name = tablepro_core::sql_dialect::quote_ident(&driver_id, &c.name);

linux/crates/app/src/ui/app/connection.rs

@@ -9,7 +9,7 @@ use crate::services::database_service::ConnectionHealth;
 use crate::services::{connection_service, database_service};
 use crate::ui::connect_dialog::{ConnectDialog, ConnectDialogInit, ConnectDialogOutput};
 
-use super::{App, AppMsg, qualified_label};
+use super::{App, AppMsg, StatusKind, qualified_label};
 
 impl App {
     pub(super) fn on_open_connect(&mut self, sender: ComponentSender<Self>) {
@@ -41,6 +41,7 @@ impl App {
         self.push_schema_words();
         self.refresh_window_title();
         self.set_status_page(
+            StatusKind::Info,
             &crate::tr!("Select a table"),
             &crate::tr!("Connected to {driver}. Pick a table from the left to load up to 100,000 rows.")
                 .replace("{driver}", &driver_id),

linux/crates/app/src/ui/app/editor_tabs.rs

@@ -8,12 +8,13 @@ use crate::services::database_service;
 use crate::ui::editor::{SqlEditorInput, derive_tab_label};
 use crate::ui::history_dialog::{HistoryDialog, HistoryDialogInit, HistoryDialogOutput};
 
-use super::{App, AppMsg, create_editor_tab_slot, default_tab_label, read_tab_id};
+use super::{App, AppMsg, StatusKind, create_editor_tab_slot, default_tab_label, read_tab_id};
 
 impl App {
     pub(super) fn on_open_editor(&mut self, sender: ComponentSender<Self>) {
         if database_service::instance().active().is_none() {
             self.set_status_page(
+                StatusKind::Disconnected,
                 &crate::tr!("No connection"),
                 &crate::tr!("Connect to a database first to run SQL."),
             );
@@ -191,6 +192,7 @@ impl App {
     pub(super) fn show_welcome_or_grid_after_editor_close(&mut self, sender: ComponentSender<Self>) {
         if self.connected {
             self.set_status_page(
+                StatusKind::Info,
                 &crate::tr!("Select a table"),
                 &crate::tr!("Pick a table from the left to load rows."),
             );

linux/crates/app/src/ui/app/mod.rs

@@ -187,6 +187,46 @@ pub struct UndoBatch {
     pub statements: Vec<(String, Vec<Value>)>,
 }
 
+/// Determines which icon and styling adw::StatusPage uses.
+///
+/// Replaces the previous title-string sniffing in `set_status_page`,
+/// which broke the moment a translation used different vocabulary
+/// for "Failed" / "Error" / "No connection".
+#[derive(Debug, Clone, Copy)]
+pub(super) enum StatusKind {
+    Info,
+    Error,
+    Disconnected,
+}
+
+impl StatusKind {
+    fn icon(self) -> &'static str {
+        match self {
+            StatusKind::Info => "view-grid-symbolic",
+            StatusKind::Error => "dialog-error-symbolic",
+            StatusKind::Disconnected => "network-server-symbolic",
+        }
+    }
+}
+
+impl App {
+    /// The active driver id, or "postgres" if no connection is active.
+    ///
+    /// Single fallback site (was duplicated at 7 call sites). The
+    /// tracing::warn! makes the latent bug visible if anything ever
+    /// asks for the driver id without an active connection — today
+    /// that would silently corrupt SQL quoting on non-Postgres drivers.
+    pub(super) fn driver_id(&self) -> &str {
+        match self.current_driver_id.as_deref() {
+            Some(id) => id,
+            None => {
+                tracing::warn!("driver_id called without active connection; falling back to postgres");
+                "postgres"
+            }
+        }
+    }
+}
+
 #[relm4::component(pub)]
 impl SimpleComponent for App {
     type Init = Arc<DriverRegistry>;

linux/crates/app/src/ui/app/row_ops.rs

@@ -31,7 +31,7 @@ impl App {
         if self.current_columns.is_empty() {
             return;
         }
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let dialog = InsertDialog::builder()
             .launch(InsertDialogInit {
                 table: table.clone(),
@@ -74,7 +74,7 @@ impl App {
             return;
         }
         let row = result.rows[position].clone();
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let dialog = EditDialog::builder()
             .launch(EditDialogInit {
                 table,
@@ -123,7 +123,7 @@ impl App {
             );
             return;
         }
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
 
         let preview = if positions.len() == 1 {
             let row = &result.rows[positions[0] as usize];
@@ -383,7 +383,7 @@ impl App {
             );
             return;
         }
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let preview = result
             .rows
             .get(row_position as usize)
@@ -413,7 +413,7 @@ impl App {
         let Some(row) = result.rows.get(row_position as usize) else {
             return;
         };
-        let driver_id = self.current_driver_id.clone().unwrap_or_else(|| "postgres".to_string());
+        let driver_id = self.driver_id().to_string();
         let cols: Vec<String> = self
             .current_columns
             .iter()

linux/crates/app/src/ui/app/status_pages.rs

@@ -1,7 +1,7 @@
 use relm4::adw::prelude::*;
 use relm4::{ComponentController, ComponentSender, adw, gtk};
 
-use super::{App, AppMsg, UndoBatch, build_shortcuts_window};
+use super::{App, AppMsg, StatusKind, UndoBatch, build_shortcuts_window};
 
 impl App {
     pub(super) fn show_welcome_page(&self, _sender: ComponentSender<Self>) {
@@ -39,18 +39,11 @@ impl App {
         self.content_holder.set_content(Some(&outer));
     }
 
-    pub(super) fn set_status_page(&self, title: &str, description: &str) {
-        let icon = if title.eq_ignore_ascii_case("failed") || title.to_lowercase().contains("error") {
-            "dialog-error-symbolic"
-        } else if title.contains("No connection") {
-            "network-server-symbolic"
-        } else {
-            "view-grid-symbolic"
-        };
+    pub(super) fn set_status_page(&self, kind: StatusKind, title: &str, description: &str) {
         let page = adw::StatusPage::builder()
             .title(title)
             .description(description)
-            .icon_name(icon)
+            .icon_name(kind.icon())
             .build();
         self.content_holder.set_content(Some(&page));
     }