Merge remote-tracking branch 'origin/main' into fix/createdb-server-driven

# Conflicts:
#	CHANGELOG.md
#	Plugins/PostgreSQLDriverPlugin/PostgreSQLPluginDriver.swift

Author: datlechin

CHANGELOG.md

@@ -16,15 +16,30 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Click a focused cell to start editing without a second click
 - Data grid focus ring follows the system accent color and contrast settings
 - Data grid cells expose accessibility row and column index ranges to VoiceOver on all dataset sizes
+- Data grid column headers announce sort direction and multi-sort priority to VoiceOver
 - Multi-cell paste: paste TSV data from the clipboard into the grid starting from the focused cell, grouped as a single undo action
 - Shift+Tab navigates to the previous cell in the data grid
 - Copy rows writes TSV, HTML table, and plain text to the clipboard for richer paste in spreadsheet apps
 - Row drag adds TSV and HTML representations alongside the internal drag type
+- AI provider settings allow manually entering a model name when the provider does not return one
 
 ### Changed
 
 - Create Database dialog is now driver-driven. Each driver discovers its own valid options (PostgreSQL queries `pg_collation` and `pg_database`, MySQL/MariaDB query `information_schema.character_sets`/`collations`). The hardcoded macOS-flavored locale list is gone. Engines that don't support creation hide the Create button instead of failing on click.
 - Introduced TableRows, Row, and Delta value types in TablePro/Models/Query/ as the foundation for the data grid row model rewrite. No callers migrated yet (Phase C.1 of the DataGrid refactor).
+- DataGrid columns and cells refactored to use a persistent column pool and typed cell view hierarchy. CPU usage on table switch reduced significantly through proper NSTableView reuse pool retention.
+- Data grid column identifiers are now the column name (with positional fallback for duplicate names), so saved widths follow the column across schema changes that shift its position. Identifier resolution moved from static `DataGridView` helpers to a `ColumnIdentitySchema` value type owned by the coordinator.
+- `ColumnLayoutStorage` singleton replaced by a `ColumnLayoutPersisting` protocol with an injectable `FileColumnLayoutPersister` default. The coordinator depends on the protocol, not the concrete class, so tests can substitute a fake.
+- Column layout save/restore on table-switch (`saveColumnLayoutForTable` / `restoreColumnLayoutForTable`) folded into the data grid coordinator's lifecycle (load on column build, persist on resize/move/dismantle). The standalone `MainContentCoordinator+ColumnLayout` extension is gone; only the visibility orchestration remains. Removes the redundant `hasUserResizedColumns` flag and the external save trigger from the binding setter.
+- Data grid header sort indicators are drawn inside a custom `NSTableHeaderCell` instead of overlay `NSImageView` subviews, replacing Unicode arrows that were embedded in the column title string. The cell renders ascending/descending chevrons via SF Symbols (`chevron.up`/`chevron.down`) with a hierarchical tint, so they pick up the correct color in light and dark mode. Removing the overlay subviews lets `NSTableHeaderView`'s native cursor management run unimpeded, so the column resize cursor on hover works without any custom cursor handling. The primary sorted column gets the system header tint via `highlightedTableColumn`, and secondary sort columns show a small priority number to the left of the chevron.
+- Data grid header divider taps trigger a column resize instead of sorting the adjacent column. `SortableHeaderView` checks if the click landed within 4 pt of a column edge and forwards the event to `NSTableHeaderView`'s native resize handling.
+- Data grid column layout persistence routes through a coordinator callback fired from outside SwiftUI's update cycle, removing the `Task`-based `@Binding` mutation inside `updateNSView` and the `isWritingColumnLayout` re-entry guard.
+- Data grid cell reuse resets foreign-key arrow and dropdown chevron button context (target, action, row, column) when the button hides, preventing a stale handler from firing the wrong row if the column toggles between FK-eligible and not.
+- `applyColumnOrder` scans only the unsettled tail of the column array per move, halving the constant cost on reorders with many columns.
+- Replaced RowBuffer / InMemoryRowProvider / RowDataStore with TableRows / TableRowsStore / TableRowsController. Mutations emit Delta events; the controller drives NSTableView via insertRows / removeRows / reloadData(forRowIndexes:). Sort and the display cache moved off the row provider into the data grid coordinator, keyed by Row.id.
+- Routed every TableRows mutation through `mutateActiveTableRows` on MainContentCoordinator so the active ResultSet's snapshot stays in sync with the store. The snapshot now refreshes only when the user switches result sets (saving the outgoing tab, loading the incoming one), so each insert / undo / paste no longer triggers an `@Observable` re-render of the whole editor. Fixes empty cells on Load More and CPU spikes when adding or undoing rows.
+- Undo of a cell edit clears the modified-cell highlight: `DataChangeManager.applyDataUndo` now bumps `reloadVersion` so the data grid rebuilds its visual state cache.
+- Reloading a table tab keeps cached column metadata (defaults, foreign keys, nullability, enum values) when no fresh schema fetch was needed, so the FK arrow and dropdown chevron stay visible across reloads instead of toggling.
 - DataChangeManager extracted a PendingChanges value type that owns cross-collection invariants for cell edits, row insertions, and deletions. DataChangeManager kept undo/redo registration, plugin SQL generation, and the `@Observable` boundary, dropping from ~960 to ~190 lines. The serialization DTO `TabPendingChanges` is renamed to `TabChangeSnapshot` to distinguish it from the live tracker.
 - AnyChangeManager uses ChangeManaging protocol instead of closure-based type erasure, removing all runtime `[Any]` downcasts
 - Row selection state moved from MainContentView @State to GridSelectionState @Observable class, preventing full view tree invalidation on every row click
@@ -44,6 +59,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Date picker popover font follows the data grid font setting
 - Data grid undo/redo uses the window's UndoManager instead of a private instance, unifying Cmd+Z across editor and grid
 - Right-click during cell editing shows the native text context menu instead of the row menu
+- Multiline cell overlay editor discards the in-progress edit when a column resize fires, instead of silently committing partial text
+- Data grid cell focus ring redraws when the user toggles Light or Dark mode mid-session, picking up the system's appearance-aware focus indicator color
+- Data grid keeps sortedIDs and cachedRowCount paired by calling updateCache() immediately after the SwiftUI bridge writes new sortedIDs to the coordinator, removing a window where the cached count and the sort permutation could disagree
+- Display formats memoized per tab on MainContentCoordinator keyed by schema version, smart-detection setting, and format-overrides version, so ValueDisplayDetector.detect runs once per result schema instead of on every SwiftUI body evaluation
 
 ### Fixed
 

TablePro/Core/ChangeTracking/AnyChangeManager.swift

@@ -7,6 +7,7 @@ protocol ChangeManaging: AnyObject {
     var reloadVersion: Int { get }
     var canRedo: Bool { get }
     var rowChanges: [RowChange] { get }
+    var insertedRowIndices: Set<Int> { get }
     func isRowDeleted(_ rowIndex: Int) -> Bool
     func recordCellChange(
         rowIndex: Int,
@@ -18,7 +19,6 @@ protocol ChangeManaging: AnyObject {
     )
     func undoRowDeletion(rowIndex: Int)
     func undoRowInsertion(rowIndex: Int)
-    func consumeChangedRowIndices() -> Set<Int>
 }
 
 @Observable
@@ -30,6 +30,7 @@ final class AnyChangeManager {
     var reloadVersion: Int { wrapped.reloadVersion }
     var canRedo: Bool { wrapped.canRedo }
     var rowChanges: [RowChange] { wrapped.rowChanges }
+    var insertedRowIndices: Set<Int> { wrapped.insertedRowIndices }
 
     func isRowDeleted(_ rowIndex: Int) -> Bool {
         wrapped.isRowDeleted(rowIndex)
@@ -61,10 +62,6 @@ final class AnyChangeManager {
         wrapped.undoRowInsertion(rowIndex: rowIndex)
     }
 
-    func consumeChangedRowIndices() -> Set<Int> {
-        wrapped.consumeChangedRowIndices()
-    }
-
     init(_ manager: any ChangeManaging) {
         self.wrapped = manager
     }

TablePro/Core/ChangeTracking/DataChangeManager.swift

@@ -17,6 +17,21 @@ struct UndoResult {
     let needsRowRemoval: Bool
     let needsRowRestore: Bool
     let restoreRow: [String?]?
+    let delta: Delta
+
+    init(
+        action: UndoAction,
+        needsRowRemoval: Bool,
+        needsRowRestore: Bool,
+        restoreRow: [String?]?,
+        delta: Delta = .none
+    ) {
+        self.action = action
+        self.needsRowRemoval = needsRowRemoval
+        self.needsRowRestore = needsRowRestore
+        self.restoreRow = restoreRow
+        self.delta = delta
+    }
 }
 
 /// Manager for tracking and applying data changes
@@ -63,12 +78,6 @@ final class DataChangeManager: ChangeManaging {
         undoManager.setActionName(actionName)
     }
 
-    // MARK: - Helper Methods
-
-    func consumeChangedRowIndices() -> Set<Int> {
-        pending.consumeChangedRowIndices()
-    }
-
     // MARK: - Configuration
 
     func clearChanges() {
@@ -259,7 +268,10 @@ final class DataChangeManager: ChangeManaging {
                 originalDBValue: newValue, newValue: previousValue, originalRow: originalRow
             )
         }
-        lastUndoResult = UndoResult(action: action, needsRowRemoval: false, needsRowRestore: false, restoreRow: nil)
+        lastUndoResult = UndoResult(
+            action: action, needsRowRemoval: false, needsRowRestore: false, restoreRow: nil,
+            delta: .cellChanged(row: rowIndex, column: columnIndex)
+        )
     }
 
     private func applyRowInsertionUndo(rowIndex: Int, action: UndoAction) {
@@ -274,12 +286,14 @@ final class DataChangeManager: ChangeManaging {
         if pending.isRowInserted(rowIndex) {
             _ = pending.undoRowInsertion(rowIndex: rowIndex)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil
+                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil,
+                delta: .rowsRemoved(IndexSet(integer: rowIndex))
             )
         } else {
             pending.reinsertRow(rowIndex: rowIndex, columns: columns, savedValues: savedValues)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: savedValues
+                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: savedValues,
+                delta: .rowsInserted(IndexSet(integer: rowIndex))
             )
         }
     }
@@ -292,12 +306,14 @@ final class DataChangeManager: ChangeManaging {
         if pending.isRowDeleted(rowIndex) {
             _ = pending.undoRowDeletion(rowIndex: rowIndex)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: originalRow
+                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: originalRow,
+                delta: .fullReplace
             )
         } else {
             pending.reapplyRowDeletion(rowIndex: rowIndex, originalRow: originalRow)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil
+                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil,
+                delta: .fullReplace
             )
         }
     }
@@ -315,14 +331,16 @@ final class DataChangeManager: ChangeManaging {
                 _ = pending.undoRowDeletion(rowIndex: rowIndex)
             }
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: nil
+                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: nil,
+                delta: .fullReplace
             )
         } else {
             for (rowIndex, originalRow) in rows {
                 pending.reapplyRowDeletion(rowIndex: rowIndex, originalRow: originalRow)
             }
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil
+                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil,
+                delta: .fullReplace
             )
         }
     }
@@ -335,15 +353,18 @@ final class DataChangeManager: ChangeManaging {
         }
 
         let firstInserted = rowIndices.first.map { pending.isRowInserted($0) } ?? false
+        let indices = IndexSet(rowIndices)
         if firstInserted {
             _ = pending.undoBatchRowInsertion(rowIndices: rowIndices, columnCount: columns.count)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil
+                action: action, needsRowRemoval: true, needsRowRestore: false, restoreRow: nil,
+                delta: .rowsRemoved(indices)
             )
         } else {
             pending.reinsertBatch(rowIndices: rowIndices, rowValues: rowValues, columns: columns)
             lastUndoResult = UndoResult(
-                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: nil
+                action: action, needsRowRemoval: false, needsRowRestore: true, restoreRow: nil,
+                delta: .rowsInserted(indices)
             )
         }
     }

TablePro/Core/ChangeTracking/PendingChanges.swift

@@ -17,7 +17,6 @@ struct PendingChanges: Equatable {
     private(set) var insertedRowIndices: Set<Int> = []
     private(set) var modifiedCells: [Int: Set<Int>] = [:]
     private(set) var insertedRowData: [Int: [String?]] = [:]
-    private(set) var changedRowIndices: Set<Int> = []
 
     private var changeIndex: [RowChangeKey: Int] = [:]
 
@@ -77,7 +76,6 @@ struct PendingChanges: Equatable {
         if let insertIdx = changeIndex[RowChangeKey(rowIndex: rowIndex, type: .insert)] {
             updateInsertedCell(at: insertIdx, columnIndex: columnIndex,
                                columnName: columnName, newValue: newValue)
-            changedRowIndices.insert(rowIndex)
             return true
         }
 
@@ -93,7 +91,6 @@ struct PendingChanges: Equatable {
             changeIndex[updateKey] = changes.count - 1
             modifiedCells[rowIndex, default: []].insert(columnIndex)
         }
-        changedRowIndices.insert(rowIndex)
         return true
     }
 
@@ -103,7 +100,6 @@ struct PendingChanges: Equatable {
         modifiedCells.removeValue(forKey: rowIndex)
         appendChange(RowChange(rowIndex: rowIndex, type: .delete, originalRow: originalRow))
         deletedRowIndices.insert(rowIndex)
-        changedRowIndices.insert(rowIndex)
     }
 
     mutating func recordRowInsertion(rowIndex: Int, values: [String?]) {
@@ -114,7 +110,6 @@ struct PendingChanges: Equatable {
         insertedRowData[rowIndex] = values
         appendChange(RowChange(rowIndex: rowIndex, type: .insert, cellChanges: []))
         insertedRowIndices.insert(rowIndex)
-        changedRowIndices.insert(rowIndex)
     }
 
     // MARK: - Mutate (cancelling pending edits)
@@ -123,7 +118,6 @@ struct PendingChanges: Equatable {
         guard deletedRowIndices.contains(rowIndex) else { return false }
         removeChange(rowIndex: rowIndex, type: .delete)
         deletedRowIndices.remove(rowIndex)
-        changedRowIndices.insert(rowIndex)
         return true
     }
 
@@ -135,7 +129,6 @@ struct PendingChanges: Equatable {
         insertedRowData.removeValue(forKey: rowIndex)
 
         shiftRowIndicesDown(at: rowIndex)
-        changedRowIndices.insert(rowIndex)
         return true
     }
 
@@ -159,7 +152,6 @@ struct PendingChanges: Equatable {
             removeChange(rowIndex: rowIndex, type: .insert)
             insertedRowIndices.remove(rowIndex)
             insertedRowData.removeValue(forKey: rowIndex)
-            changedRowIndices.insert(rowIndex)
         }
 
         let sortedRemoved = validRows.sorted()
@@ -188,7 +180,6 @@ struct PendingChanges: Equatable {
         modifiedCells.removeValue(forKey: rowIndex)
         appendChange(RowChange(rowIndex: rowIndex, type: .delete, originalRow: originalRow))
         deletedRowIndices.insert(rowIndex)
-        changedRowIndices.insert(rowIndex)
     }
 
     /// Re-apply a cell edit during undo replay (skips undo registration).
@@ -213,7 +204,6 @@ struct PendingChanges: Equatable {
         if let insertIdx = changeIndex[RowChangeKey(rowIndex: rowIndex, type: .insert)] {
             updateInsertedCell(at: insertIdx, columnIndex: columnIndex,
                                columnName: columnName, newValue: newValue)
-            changedRowIndices.insert(rowIndex)
             return
         }
 
@@ -229,7 +219,6 @@ struct PendingChanges: Equatable {
             changeIndex[updateKey] = changes.count - 1
             modifiedCells[rowIndex, default: []].insert(columnIndex)
         }
-        changedRowIndices.insert(rowIndex)
     }
 
     /// Replace an inserted row's cell value during undo replay (no shift, no undo).
@@ -241,7 +230,6 @@ struct PendingChanges: Equatable {
     ) {
         guard let insertIdx = changeIndex[RowChangeKey(rowIndex: rowIndex, type: .insert)] else { return }
         updateInsertedCell(at: insertIdx, columnIndex: columnIndex, columnName: columnName, newValue: newValue)
-        changedRowIndices.insert(rowIndex)
     }
 
     /// Restore a cell's value during undo replay when an existing change matches.
@@ -274,7 +262,6 @@ struct PendingChanges: Equatable {
                 newValue: previousValue
             )
         }
-        changedRowIndices.insert(rowIndex)
     }
 
     /// Insert a synthetic .insert RowChange for undo replay (e.g., after redoing a deletion's undo).
@@ -291,7 +278,6 @@ struct PendingChanges: Equatable {
         if let savedValues {
             insertedRowData[rowIndex] = savedValues
         }
-        changedRowIndices.insert(rowIndex)
     }
 
     /// Insert a batch of rows (for undo replay of a batch deletion's undo).
@@ -314,7 +300,6 @@ struct PendingChanges: Equatable {
             changes.append(RowChange(rowIndex: rowIndex, type: .insert, cellChanges: cellChanges))
             insertedRowIndices.insert(rowIndex)
             insertedRowData[rowIndex] = values
-            changedRowIndices.insert(rowIndex)
         }
         rebuildChangeIndex()
     }
@@ -338,23 +323,14 @@ struct PendingChanges: Equatable {
         insertedRowIndices.removeAll()
         modifiedCells.removeAll()
         insertedRowData.removeAll()
-        changedRowIndices.removeAll()
     }
 
-    mutating func consumeChangedRowIndices() -> Set<Int> {
-        let indices = changedRowIndices
-        changedRowIndices.removeAll()
-        return indices
-    }
-
-    /// Replace internal state from a serialized snapshot.
     mutating func restore(from snapshot: TabChangeSnapshot) {
         changes = snapshot.changes
         deletedRowIndices = snapshot.deletedRowIndices
         insertedRowIndices = snapshot.insertedRowIndices
         modifiedCells = snapshot.modifiedCells
         insertedRowData = snapshot.insertedRowData
-        changedRowIndices = []
         rebuildChangeIndex()
     }
 
@@ -471,7 +447,6 @@ struct PendingChanges: Equatable {
         if changes[updateIdx].cellChanges.isEmpty {
             removeChangeAt(updateIdx)
         }
-        changedRowIndices.insert(rowIndex)
         return true
     }
 
@@ -494,7 +469,6 @@ struct PendingChanges: Equatable {
         }
         modifiedCells = newModifiedCells
 
-        changedRowIndices = Set(changedRowIndices.map { $0 >= insertionPoint ? $0 + 1 : $0 })
         rebuildChangeIndex()
     }