fix(inspector): add resize call site, refresh base size, fix animation race, add test

Author: J2TeamNNL

TablePro/Core/Services/Infrastructure/MainSplitViewController.swift

@@ -40,7 +40,6 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
     private var detailHosting: NSHostingController<AnyView>!
     private var inspectorHosting: NSHostingController<AnyView>!
     private var hasMaterializedInspector = false
-    private var baseWindowContentMinSize: NSSize?
 
     // MARK: - Toolbar
 
@@ -195,10 +194,7 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
     ) {
         guard let window = view.window else { return }
 
-        if baseWindowContentMinSize == nil {
-            baseWindowContentMinSize = window.contentRect(forFrameRect: NSRect(origin: .zero, size: window.minSize)).size
-        }
-        guard let baseWindowContentMinSize else { return }
+        let baseWindowContentMinSize = window.contentRect(forFrameRect: NSRect(origin: .zero, size: window.minSize)).size
 
         let resolvedMinSize = Self.resolvedContentMinSize(
             base: baseWindowContentMinSize,
@@ -289,6 +285,10 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
         removeObservers()
     }
 
+    override func splitViewDidResizeSubviews(_ notification: Notification) {
+        recomputeWindowMinimumSize()
+    }
+
     // MARK: - Observers
 
     private func installObservers() {
@@ -542,7 +542,9 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
     }
 
     func hideInspector() {
-        setCollapsed(true, for: inspectorSplitItem)
+        setCollapsed(true, for: inspectorSplitItem) { [weak self] in
+            self?.recomputeWindowMinimumSize(inspectorCollapsed: true)
+        }
         UserDefaults.standard.set(false, forKey: Self.inspectorPresentedKey)
     }
 

TableProTests/Core/Services/Infrastructure/MainSplitViewControllerWindowMinimumSizeTests.swift

@@ -53,4 +53,20 @@ struct MainSplitViewControllerWindowMinimumSizeTests {
         #expect(size.width == 720)
         #expect(size.height == 448)
     }
+
+    @Test("Uses the pane sum when detail and inspector exceed the base floor")
+    func usesPaneSumWhenItExceedsBaseWithSidebarCollapsed() {
+        let size = MainSplitViewController.resolvedContentMinSize(
+            base: NSSize(width: 720, height: 448),
+            panes: [
+                .init(minimumThickness: 280, isCollapsed: true),
+                .init(minimumThickness: 400, isCollapsed: false),
+                .init(minimumThickness: 400, isCollapsed: false)
+            ],
+            dividerThickness: 2
+        )
+
+        #expect(size.width == 802)
+        #expect(size.height == 448)
+    }
 }