bugfix in WS upgrade logic

thelamer · thelamer · commit 423a793cf417 · 2019-05-24T23:55:03.000-07:00
diff --git a/index.js b/index.js
@@ -100,7 +100,7 @@ proxyServer.on('upgrade', function (req, socket) {
     var subdomain = req.headers.host.split('.')[0];
     // make sure port is ok
     if(isNaN(parseFloat(subdomain)) || parseInt(subdomain) <= 0 || parseInt(subdomain) >= 65536){
-      res.end('Not a valid SubDomain');
+      socket.end('Not a valid SubDomain');
     }
     else{
       var endpoint = 'http://' + ip + ':' + subdomain;
@@ -110,9 +110,9 @@ proxyServer.on('upgrade', function (req, socket) {
     }
   }
   else{
-    res.statusCode = 401;
-    res.setHeader('WWW-Authenticate', 'Basic realm="Login"');
-    res.end('<html><body>You shall not pass</body></html>');
+    socket.statusCode = 401;
+    socket.setHeader('WWW-Authenticate', 'Basic realm="Login"');
+    socket.end('<html><body>You shall not pass</body></html>');
   }
 });
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ proxyServer.on('upgrade', function (req, socket) {`
`100`	`100`	`var subdomain = req.headers.host.split('.')[0];`
`101`	`101`	`// make sure port is ok`
`102`	`102`	`if(isNaN(parseFloat(subdomain)) \|\| parseInt(subdomain) <= 0 \|\| parseInt(subdomain) >= 65536){`
`103`		`- res.end('Not a valid SubDomain');`
	`103`	`+ socket.end('Not a valid SubDomain');`
`104`	`104`	`}`
`105`	`105`	`else{`
`106`	`106`	`var endpoint = 'http://' + ip + ':' + subdomain;`
`@@ -110,9 +110,9 @@ proxyServer.on('upgrade', function (req, socket) {`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`	`else{`
`113`		`- res.statusCode = 401;`
`114`		`- res.setHeader('WWW-Authenticate', 'Basic realm="Login"');`
`115`		`- res.end('<html><body>You shall not pass</body></html>');`
	`113`	`+ socket.statusCode = 401;`
	`114`	`+ socket.setHeader('WWW-Authenticate', 'Basic realm="Login"');`
	`115`	`+ socket.end('<html><body>You shall not pass</body></html>');`
`116`	`116`	`}`
`117`	`117`	`});`
`118`	`118`