Merge pull request #134 from TaloDev/develop

Release 0.33.0

Author: tudddorrr

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
         with:
           lfs: true
 
-      - uses: chickensoft-games/setup-godot@v1
+      - uses: chickensoft-games/setup-godot@v2
         name: Set up Godot
         with:
           version: 4.4.1

.github/workflows/claude-code-review.yml

@@ -0,0 +1,81 @@
+name: Claude Code Review
+
+on:
+  pull_request:
+    types: [opened, synchronize]
+    # Optional: Only run on specific file changes
+    # paths:
+    #   - "src/**/*.ts"
+    #   - "src/**/*.tsx"
+    #   - "src/**/*.js"
+    #   - "src/**/*.jsx"
+
+jobs:
+  claude-review:
+    # Optional: Filter by PR author
+    # if: |
+    #   github.event.pull_request.user.login == 'external-contributor' ||
+    #   github.event.pull_request.user.login == 'new-developer' ||
+    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
+    
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+    
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code Review
+        id: claude-review
+        uses: anthropics/claude-code-action@beta
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+
+          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4.1)
+          # model: "claude-opus-4-1-20250805"
+
+          # Direct prompt for automated review (no @claude mention needed)
+          direct_prompt: |
+            Please review this pull request and provide feedback on:
+            - Code quality and best practices
+            - Potential bugs or issues
+            - Performance considerations
+            - Security concerns
+            - Backwards compatibility
+            - Documentation: public methods (not prefixed with _) should generally have docstrings (##) and classes should contain the @tutorial tag
+
+            For each of the points above, do not point out what works well, only what could be improved (if anything).
+            Be constructive and helpful in your feedback but do not repeat yourself - only summarise potential issues.
+            Test coverage is currently not a priority.
+            Prefix section headers with emojis and use dividers for better readability.
+
+          use_sticky_comment: true
+          
+          # Optional: Customize review based on file types
+          # direct_prompt: |
+          #   Review this PR focusing on:
+          #   - For TypeScript files: Type safety and proper interface usage
+          #   - For API endpoints: Security, input validation, and error handling
+          #   - For React components: Performance, accessibility, and best practices
+          #   - For tests: Coverage, edge cases, and test quality
+          
+          # Optional: Different prompts for different authors
+          # direct_prompt: |
+          #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' && 
+          #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
+          #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
+          
+          # Optional: Add specific tools for running tests or linting
+          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
+          
+          # Optional: Skip review for certain conditions
+          # if: |
+          #   !contains(github.event.pull_request.title, '[skip-review]') &&
+          #   !contains(github.event.pull_request.title, '[WIP]')
+

README.md

@@ -1,6 +1,6 @@
 # Talo Godot plugin: self-hostable game dev tools
 
-Talo is the easiest way to add leaderboards, player authentication, socket-based multiplayer and more to your game. Using the Talo Dashboard, you can visualise and analyse your game data to make data-driven decisions.
+Talo is the easiest way to add leaderboards, player authentication, peer-to-peer multiplayer and more to your game. Using the Talo Dashboard, you can visualise and analyse your game data to make data-driven decisions.
 
 ## Get the plugin
 

addons/talo/apis/players_api.gd

@@ -14,23 +14,33 @@ signal identification_started()
 ## Emitted when identification fails.
 signal identification_failed()
 
+func _handle_identify_success(alias: TaloPlayerAlias, socket_token: String = "") -> TaloPlayer:
+	if not await Talo.is_offline():
+		Talo.socket.reset_connection()
+
+	Talo.current_alias = alias
+
+	if not socket_token.is_empty():
+		Talo.socket.set_socket_token(socket_token)
+
+	identified.emit(Talo.current_player)
+	return Talo.current_player
+
 ## Identify a player using a service (e.g. "username") and identifier (e.g. "bob").
 func identify(service: String, identifier: String) -> TaloPlayer:
 	identification_started.emit()
 
+	if await Talo.is_offline():
+		return await identify_offline(service, identifier)
+
 	var res := await client.make_request(HTTPClient.METHOD_GET, "/identify?service=%s&identifier=%s" % [service, identifier])
 	match res.status:
 		200:
-			Talo.socket.reset_connection()
-
-			Talo.current_alias = TaloPlayerAlias.new(res.body.alias)
-			Talo.socket.set_socket_token(res.body.socketToken)
-			identified.emit(Talo.current_player)
-			return Talo.current_player
+			var alias = TaloPlayerAlias.new(res.body.alias)
+			alias.write_offline_alias()
+			return await _handle_identify_success(alias, res.body.socketToken)
 		_:
-			if not await Talo.is_offline():
-				Talo.player_auth.session_manager.clear_session()
-
+			Talo.player_auth.session_manager.clear_session()
 			identification_failed.emit()
 			return null
 
@@ -50,6 +60,8 @@ func update() -> TaloPlayer:
 				Talo.current_alias.player.update_from_raw_data(res.body.player)
 			else:
 				Talo.current_alias.player = TaloPlayer.new(res.body.player)
+
+			Talo.current_alias.write_offline_alias()
 			return Talo.current_player
 		_:
 			return null
@@ -82,3 +94,12 @@ func generate_identifier() -> String:
 	var size := 12
 	var split_start := RandomNumberGenerator.new().randi_range(0, time_hash.length() - size)
 	return time_hash.substr(split_start, size)
+
+## Attempt to identify a player when they're offline
+func identify_offline(service: String, identifier: String) -> TaloPlayer:
+	var offline_alias := TaloPlayerAlias.get_offline_alias()
+	if offline_alias != null and offline_alias.matches_identify_request(service, identifier):
+		return await _handle_identify_success(offline_alias)
+	else:
+		identification_failed.emit()
+		return null

addons/talo/entities/player.gd

@@ -4,6 +4,8 @@ class_name TaloPlayer extends TaloEntityWithProps
 var id: String
 var groups: Array[TaloPlayerGroupStub] = []
 
+var _offline_data: Dictionary
+
 func _init(data: Dictionary):
 	super._init([])
 	update_from_raw_data(data)
@@ -14,6 +16,7 @@ func update_from_raw_data(data: Dictionary) -> void:
 
 	id = data.id
 	groups.assign(data.groups.map(func (group): return TaloPlayerGroupStub.new(group.id, group.name)))
+	_offline_data = data
 
 ## Set a property by key and value. Optionally sync the player (default true) with Talo.
 func set_prop(key: String, value: String, update: bool = true) -> void:
@@ -34,3 +37,7 @@ func is_in_talo_group_id(group_id: String) -> bool:
 ## Check if the player is in a group with the given name.
 func is_in_talo_group_name(group_name: String) -> bool:
 	return not groups.filter(func (group: TaloPlayerGroupStub): return group.name == group_name).is_empty()
+
+## Get the offline data for the player
+func get_offline_data() -> Dictionary:
+	return _offline_data

addons/talo/entities/player_alias.gd

@@ -1,5 +1,7 @@
 class_name TaloPlayerAlias extends RefCounted
 
+const _OFFLINE_DATA_PATH = "user://ta.bin"
+
 var id: int
 var service: String
 var identifier: String
@@ -8,6 +10,8 @@ var last_seen_at: String
 var created_at: String
 var updated_at: String
 
+var _offline_data: Dictionary
+
 func _init(data: Dictionary):
 	id = data.id
 	service = data.service
@@ -16,3 +20,37 @@ func _init(data: Dictionary):
 	last_seen_at = data.lastSeenAt
 	created_at = data.createdAt
 	updated_at = data.updatedAt
+	_offline_data = data
+
+## Cache the offline alias data
+func write_offline_alias():
+	if Talo.settings.cache_player_on_identify:
+		_offline_data.player = player.get_offline_data()
+		var file := FileAccess.open_encrypted_with_pass(_OFFLINE_DATA_PATH, FileAccess.WRITE, Talo.crypto_manager.get_key())
+		file.store_line(JSON.stringify(_offline_data))
+		file.close()
+
+## Get the offline alias data
+static func get_offline_alias() -> TaloPlayerAlias:
+	if not Talo.settings.cache_player_on_identify or not FileAccess.file_exists(_OFFLINE_DATA_PATH):
+		return null
+
+	var file := FileAccess.open_encrypted_with_pass(_OFFLINE_DATA_PATH, FileAccess.READ, Talo.crypto_manager.get_key())
+	if file == null:
+		TaloCryptoManager.handle_undecryptable_file(_OFFLINE_DATA_PATH, "offline alias file")
+		return null
+
+	var json := JSON.new()
+	json.parse(file.get_as_text())
+	file.close()
+
+	return TaloPlayerAlias.new(json.data)
+
+## Check if this alias matches the identify request
+func matches_identify_request(service: String, identifier: String) -> bool:
+	var match = self.service == service and self.identifier == identifier
+	if not match:
+		var dir := DirAccess.open("user://")
+		dir.remove(_OFFLINE_DATA_PATH)
+
+	return match

addons/talo/plugin.cfg

@@ -3,5 +3,5 @@
 name="Talo Game Services"
 description="Talo (https://trytalo.com) is an open-source game backend. Talo's Godot plugin is the easiest way to add leaderboards, player authentication, socket-based multiplayer and more to your game."
 author="trytalo"
-version="0.32.0"
+version="0.33.0"
 script="talo_autoload.gd"

addons/talo/samples/authentication/scripts/authentication.gd

@@ -15,6 +15,10 @@ func _ready() -> void:
 	_configure_signals()
 	_make_state_visible(login)
 
+	# identified signal emitted before the connection were made
+	if Talo.current_alias:
+		_make_state_visible(in_game)
+
 func _make_state_visible(state: Node2D):
 	for child in all_states.get_children():
 		child.visible = child == state

addons/talo/samples/authentication/scripts/in_game.gd

@@ -9,6 +9,9 @@ signal logout_success
 
 func _ready() -> void:
 	Talo.players.identified.connect(_on_player_identified)
+	# identified signal emitted before the connection were made
+	if Talo.current_player:
+		_on_player_identified(Talo.current_player)
 
 func _on_player_identified(player: TaloPlayer) -> void:
 	username.text = "What would you like to do,\n%s?" % Talo.current_alias.identifier

addons/talo/samples/multiscene_saves/scripts/player_controller.gd

@@ -24,9 +24,12 @@ func _clear_username() -> void:
 func get_username() -> String:
 	if FileAccess.file_exists(_username_file_path):
 		var file := FileAccess.open(_username_file_path, FileAccess.READ)
-		return file.get_as_text()
+		var content := file.get_as_text()
+		file.close()
+		return content
 	else:
 		var file := FileAccess.open(_username_file_path, FileAccess.WRITE)
 		var username := Talo.players.generate_identifier()
 		file.store_string(username)
+		file.close()
 		return username