Merge pull request #171 from TaloDev/preserve-leaderboard-positions

Preserve leaderboard positions in entry cache

Author: tudddorrr

addons/talo/apis/leaderboards_api.gd

@@ -84,8 +84,8 @@ func add_entry(internal_name: String, score: float, props: Dictionary[String, Va
 
 	match res.status:
 		200:
-			var entry = TaloLeaderboardEntry.new(res.body.entry)
-			_entries_manager.upsert_entry(internal_name, entry)
+			var entry := TaloLeaderboardEntry.new(res.body.entry)
+			_entries_manager.upsert_entry(internal_name, entry, true)
 
 			return AddEntryResult.new(entry, res.body.updated)
 		_:

addons/talo/utils/leaderboard_entries_manager.gd

@@ -31,16 +31,19 @@ func _find_insert_position(entries: Array[TaloLeaderboardEntry], entry: TaloLead
 
 	return left
 
-func upsert_entry(internal_name: String, entry: TaloLeaderboardEntry) -> void:
+func upsert_entry(internal_name: String, entry: TaloLeaderboardEntry, bump_positions: bool = false) -> void:
 	var named_entries: Array[TaloLeaderboardEntry] = []
 	named_entries = _current_entries.get_or_add(internal_name, named_entries).filter(
 		func (e: TaloLeaderboardEntry) -> bool: return e.id != entry.id
 	)
 
-	var insert_pos = _find_insert_position(named_entries, entry)
+	var insert_pos: int = _find_insert_position(named_entries, entry)
 	named_entries.insert(insert_pos, entry)
-	
-	for idx in range(named_entries.size()):
-		named_entries[idx].position = idx
+
+	# bump positions when this is called via add_entry()
+	if bump_positions:
+		for e in named_entries:
+			if e.id != entry.id and e.position >= entry.position:
+				e.position += 1
 
 	_current_entries[internal_name] = named_entries