preserve leaderboard positions in entry cache

Author: tudddorrr

addons/talo/apis/leaderboards_api.gd

@@ -84,7 +84,7 @@ func add_entry(internal_name: String, score: float, props: Dictionary[String, Va
 
 	match res.status:
 		200:
-			var entry = TaloLeaderboardEntry.new(res.body.entry)
+			var entry := TaloLeaderboardEntry.new(res.body.entry)
 			_entries_manager.upsert_entry(internal_name, entry)
 
 			return AddEntryResult.new(entry, res.body.updated)

addons/talo/utils/leaderboard_entries_manager.gd

@@ -31,16 +31,18 @@ func _find_insert_position(entries: Array[TaloLeaderboardEntry], entry: TaloLead
 
 	return left
 
-func upsert_entry(internal_name: String, entry: TaloLeaderboardEntry) -> void:
+func upsert_entry(internal_name: String, new_entry: TaloLeaderboardEntry) -> void:
 	var named_entries: Array[TaloLeaderboardEntry] = []
 	named_entries = _current_entries.get_or_add(internal_name, named_entries).filter(
-		func (e: TaloLeaderboardEntry) -> bool: return e.id != entry.id
+		func (e: TaloLeaderboardEntry) -> bool: return e.id != new_entry.id
 	)
 
-	var insert_pos = _find_insert_position(named_entries, entry)
-	named_entries.insert(insert_pos, entry)
-	
-	for idx in range(named_entries.size()):
-		named_entries[idx].position = idx
+	var insert_pos := _find_insert_position(named_entries, new_entry)
+	named_entries.insert(insert_pos, new_entry)
+
+	# bump positions for entries at or after the new entry's position
+	for entry in named_entries:
+		if entry.id != new_entry.id and entry.position >= new_entry.position:
+			entry.position += 1
 
 	_current_entries[internal_name] = named_entries