Skip to content

In-place-dropping setters for UnmanagedSignalCell #10

Description

@Tamschi

Is your feature request related to a problem? Please describe.
I'd like to have additional setters that are guaranteed to drop the previous value in place, both unconditional variants (like replace) and ones that use PartialEq (like change). Returning the previous value makes unconditional …_eager Futures larger than they'd otherwise need to be.

Describe the solution you'd like
The implementation can be just about the same as that of the replace and change methods, but without returning the value.
(The current implementation of the deferred versions of these accessors in fact already does that, but doesn't guarantee it.)

Describe alternatives you've considered
-

Additional context
I forgot this somewhere along the way 😬
Most likely when I decided that I didn't want an accessor called set for cells, as I want to encourage use of change instead.

Since this is a breaking change, it should be developed against the flourish-next branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breakingIntroduces or requests a breaking change.domain: RustInvolves Rust code.effort: 2Relative effort required. There's no specific unit of measurement.good first issueGood for newcomersstate: questionFurther information is requestedtype: featureBrand new functionality, features, pages, workflows, endpoints, etc.work: clearA known solution is (to be) implemented.

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions