Fixing failing tasks in ci workflow (#394)

* fixing jest config

* fixing eslint errors for react-form

* fixing script lints

* configuring prettier to ignore built files

* updating eslint deps

* updating pnpm lockfile

* updating dep install step in pr workflow

* rm reference to custom validatePackages script

* fixing code sandbox failure

* attempting to fix frozen locfile issue

* fixing install:csb step

* removing unnecessary type assignment

Author: ZackDeRose

.github/workflows/pr.yml

@@ -22,7 +22,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - name: Run Tests
         uses: nick-fields/retry@v2.8.3
         with:
@@ -48,7 +48,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - run: pnpm run test:eslint --base=${{ github.event.pull_request.base.sha }}
   typecheck:
     name: 'Typecheck'
@@ -67,7 +67,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - run: pnpm run test:types --base=${{ github.event.pull_request.base.sha }}
   format:
     name: 'Format'
@@ -86,7 +86,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - run: pnpm run test:format --base=${{ github.event.pull_request.base.sha }}
   test-react-17:
     name: 'Test React 17'
@@ -105,7 +105,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - name: Run Tests
         uses: nick-fields/retry@v2.8.3
         with:
@@ -127,7 +127,7 @@ jobs:
           node-version: 16.14.2
           cache: 'pnpm'
       - name: Install dependencies
-        run: pnpm --filter "./packages/**" --filter form --prefer-offline install
+        run: pnpm --filter "./packages/**" --filter form --prefer-offline install --no-frozen-lockfile
       - run: pnpm run test:build
         env:
           BUNDLEWATCH_GITHUB_TOKEN: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}

.prettierignore

@@ -1 +1,2 @@
 /packages/svelte-form/.svelte-kit
+/packages/*/build

package.json

@@ -6,7 +6,7 @@
     "nx-reset": "nx reset",
     "clean": "pnpm --filter \"./packages/**\" run clean",
     "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...'); process.exit(1)}\" || npx -y only-allow pnpm",
-    "install:csb": "pnpm install --frozen-lockfile",
+    "install:csb": "pnpm --filter \"./packages/**\" --prefer-offline install --no-frozen-lockfile",
     "test": "pnpm run test:ci",
     "test:ci": "nx affected --targets=test:lib,test:types,test:eslint,test:format --parallel=5",
     "test:react:17": "nx affected --target=test:lib --parallel=5",
@@ -66,21 +66,21 @@
     "chalk": "^4.1.2",
     "concurrently": "^7.1.0",
     "current-git-branch": "^1.1.0",
-    "eslint": "7.x",
-    "eslint-config-prettier": "^6.11.0",
-    "eslint-config-react-app": "^5.2.1",
-    "eslint-config-standard": "^14.1.1",
-    "eslint-config-standard-react": "^9.2.0",
-    "eslint-import-resolver-typescript": "^2.7.1",
-    "eslint-plugin-flowtype": "5.x",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jsx-a11y": "6.x",
+    "eslint": "8.34.0",
+    "eslint-config-prettier": "^8.6.0",
+    "eslint-config-react-app": "^7.0.1",
+    "eslint-config-standard": "^17.0.0",
+    "eslint-config-standard-react": "^13.0.0",
+    "eslint-import-resolver-typescript": "^3.5.3",
+    "eslint-plugin-flowtype": "8.0.3",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.1.3",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-react": "7.20.0",
-    "eslint-plugin-react-hooks": "^4.3.0",
-    "eslint-plugin-standard": "^4.0.1",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-react": "7.32.2",
+    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-standard": "^5.0.0",
     "git-log-parser": "^1.2.0",
     "jest": "^27.5.1",
     "jsonfile": "^6.1.0",

packages/react-form/.eslintrc

@@ -0,0 +1,13 @@
+// @ts-check
+
+/** @type {import('eslint').Linter.Config} */
+const config = {
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    tsconfigRootDir: __dirname,
+    project: './tsconfig.eslint.json',
+    sourceType: 'module',
+  },
+}
+
+module.exports = config

packages/react-form/.eslintrc.cjs

@@ -1,6 +1,5 @@
 export default {
   displayName: 'react-form',
   preset: '../../jest-preset.js',
-  setupFilesAfterEnv: ['./jest.setup.ts'],
   testMatch: ['<rootDir>/src/**/*.test.tsx', '<rootDir>/codemods/**/*.test.js'],
 }

packages/react-form/jest.config.ts

@@ -1,7 +1,7 @@
-import { FormApi } from '@tanstack/form-core'
+import type { FormApi } from '@tanstack/form-core'
 import * as React from 'react'
 
-export const formContext = React.createContext<FormApi<any>>(null!)
+export const formContext = React.createContext<FormApi<any> | null>(null)
 
 export function useFormContext(customFormApi?: FormApi<any>) {
   const formApi = React.useContext(formContext)

packages/react-form/src/formContext.ts

@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": true
+  },
+  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+}