Skip to content

Commit f99c105

Browse files
authored
test(lit-query): replace 'toBeDefined'/'toBeGreaterThan' with exact-value assertions (#11122)
test(lit-query): assert exact values instead of loose matchers
1 parent e330cee commit f99c105

4 files changed

Lines changed: 13 additions & 10 deletions

File tree

packages/lit-query/src/tests/counters-and-state.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,9 @@ describe('useIsFetching/useIsMutating/useMutationState', () => {
272272
await waitFor(() => consumer.isMutating() === 0)
273273

274274
expect(
275-
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }),
276-
).toBeDefined()
275+
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey })
276+
?.state.data,
277+
).toBe('query-ok')
277278
expect(
278279
providerClient.getQueryCache().find({ queryKey: consumer.queryKey }),
279280
).toBeUndefined()

packages/lit-query/src/tests/infinite-and-options.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,9 @@ describe('createInfiniteQueryController', () => {
118118
await waitFor(() => consumer.infinite().isSuccess)
119119
expect(consumer.infinite().data?.pages).toEqual([0])
120120
expect(
121-
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }),
122-
).toBeDefined()
121+
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey })
122+
?.state.data,
123+
).toEqual({ pages: [0], pageParams: [0] })
123124
expect(
124125
providerClient.getQueryCache().find({ queryKey: consumer.queryKey }),
125126
).toBeUndefined()

packages/lit-query/src/tests/queries-controller.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,9 @@ describe('createQueriesController', () => {
179179
)
180180

181181
expect(
182-
explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }),
183-
).toBeDefined()
182+
explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! })
183+
?.state.data,
184+
).toBe('alpha')
184185
expect(
185186
providerClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }),
186187
).toBeUndefined()

packages/lit-query/src/tests/query-controller.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,7 +1154,7 @@ describe('createQueryController', () => {
11541154
await waitFor(() => query().isSuccess)
11551155

11561156
const cacheQuery = client.getQueryCache().find({ queryKey })
1157-
expect(cacheQuery).toBeDefined()
1157+
expect(cacheQuery?.state.data).toEqual(['a', 'b'])
11581158
expect(cacheQuery?.getObserversCount()).toBe(1)
11591159

11601160
host.disconnect()
@@ -1196,8 +1196,8 @@ describe('createQueryController', () => {
11961196
await consumer.updateComplete
11971197

11981198
await waitFor(() => consumer.query().isSuccess)
1199-
expect(consumer.query().data).toBeDefined()
1200-
expect(consumer.queryCalls).toBeGreaterThan(0)
1199+
expect(consumer.queryCalls).toBe(1)
1200+
expect(consumer.query().data).toBe('value-1')
12011201

12021202
consumer.query.destroy()
12031203
provider.remove()
@@ -1232,7 +1232,7 @@ describe('createQueryController', () => {
12321232
await consumer.updateComplete
12331233
await waitFor(() => consumer.query().isSuccess)
12341234

1235-
expect(consumer.query().data).toBeDefined()
1235+
expect(consumer.query().data).toBe('value-1')
12361236

12371237
consumer.query.destroy()
12381238
provider.remove()

0 commit comments

Comments
 (0)