Skip to content

Commit 8ea2df4

Browse files
committed
pr feedback
1 parent 89e8385 commit 8ea2df4

111 files changed

Lines changed: 1919 additions & 1767 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ TanStack Table ships [TanStack Intent](https://github.com/TanStack/intent) skill
5757
npx @tanstack/intent@latest install
5858
```
5959

60-
to add skill-loading guidance for your agent (Claude Code, Cursor, Copilot, etc.). Then `npx @tanstack/intent@latest list` shows available skills and `npx @tanstack/intent@latest load <skill>` prints one for inspection. Skills version with the library — your agent gets guidance that matches the version of `@tanstack/<framework>-table` you installed. Only available for v9 and above.
60+
to add skill-loading guidance for your agent (Claude Code, Cursor, Copilot, etc.). The same CLI also exposes `intent list` to browse available skills and `intent load <skill>` to print one for inspection. Skills version with the library — your agent gets guidance that matches the version of `@tanstack/<framework>-table` you installed. Only available for v9 and above.
6161

6262
## Get Involved
6363

_artifacts/domain_map.yaml

Lines changed: 44 additions & 44 deletions
Large diffs are not rendered by default.

_artifacts/scratch/cluster-b-row-model-features.yaml

Lines changed: 45 additions & 45 deletions
Large diffs are not rendered by default.

_artifacts/scratch/cluster-e-lifecycle-composition.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Cluster E — Lifecycle & Composition skills for TanStack Table v9.0.0-alpha.47
22
# Sources: docs/framework/{react,angular,preact}/guide/*.md, docs/devtools.md,
33
# docs/installation.md, docs/guide/virtualization.md, examples/* (primary)
4-
# Maintainer: Kevin Vandy (kevinvandy656@gmail.com)
4+
# Maintainer: Kevin Vandy
55
# Date: 2026-05-16
66

77
version: 1

_artifacts/scratch/cluster-f-issues-failure-modes.yaml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -502,8 +502,26 @@ issue_findings:
502502
status: 'active'
503503
version_context: 'v8.21.3 bug, likely inherited in v9 alpha'
504504

505-
- |-
506-
skill_slugs: ['filtering', 'state-management'] mistake: 'Global filter silently ignores columns with object accessors' mechanism: | If `accessorKey` (or `accessorFn`) resolves to an object/array, the built-in global filter coerces it to string via `String(value)` — which gives `[object Object]` — and the filter function shortcuts to false. Users see their `filterFn` never being called and assume their custom function is broken. wrong_pattern: | // ❌ accessorFn returns an object — global filter never calls fuzzyFilter columnHelper.accessor((row) => row.user, { id: 'user', filterFn: fuzzyFilter }) correct_pattern: | // ✅ Flatten the value to a primitive in accessorFn, do the rich match in filterFn columnHelper.accessor((row) => `${row.user.firstName} ${row.user.lastName}`, { id: 'user', filterFn: fuzzyFilter, }) // OR explicitly set columnDef.getCanGlobalFilter: () => true source: 'https://github.com/TanStack/table/issues/4673 (Global filter doesn't run when accessor key points to an object, 16 comments), https://github.com/TanStack/table/issues/4942 (Cell's filterFn never gets called)' priority: 'HIGH' status: 'active' version_context: 'v8 behavior — silent failure makes this a high-priority skill teaching point'
505+
- skill_slugs: ['filtering', 'state-management']
506+
mistake: 'Global filter silently ignores columns with object accessors'
507+
mechanism: |
508+
If `accessorKey` (or `accessorFn`) resolves to an object/array, the built-in
509+
global filter coerces it to string via `String(value)` — which gives
510+
`[object Object]` — and the filter function shortcuts to false. Users see
511+
their `filterFn` never being called and assume their custom function is broken.
512+
wrong_pattern: |
513+
// ❌ accessorFn returns an object — global filter never calls fuzzyFilter
514+
columnHelper.accessor((row) => row.user, { id: 'user', filterFn: fuzzyFilter })
515+
correct_pattern: |
516+
// ✅ Flatten the value to a primitive in accessorFn, do the rich match in filterFn
517+
columnHelper.accessor((row) => `${row.user.firstName} ${row.user.lastName}`, {
518+
id: 'user', filterFn: fuzzyFilter,
519+
})
520+
// OR explicitly set columnDef.getCanGlobalFilter: () => true
521+
source: "https://github.com/TanStack/table/issues/4673 (Global filter doesn't run when accessor key points to an object, 16 comments); https://github.com/TanStack/table/issues/4942 (Cell's filterFn never gets called)"
522+
priority: 'HIGH'
523+
status: 'active'
524+
version_context: 'v8 behavior — silent failure makes this a high-priority skill teaching point'
507525
- skill_slugs: ['filtering', 'column-definitions']
508526
mistake: 'Column filter returns no matches when first row has null in that column'
509527
mechanism: |

_artifacts/skill_spec.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ From Phase 4 (2026-05-17). Full Q&A is in `domain_map.yaml :: maintainer_intervi
174174

175175
## Recommended Skill File Structure
176176

177-
```
177+
```text
178178
_artifacts/
179179
domain_map.yaml # this domain map
180180
skill_spec.md # this human-readable companion

0 commit comments

Comments
 (0)