OrderByFn -> Always sorting Asc.

[Sernom]

Problem: The sort function that is passed via parameters to the provided orderByFn always sorts the data Asc. Is this correct, and if so how do I make it so it responds to the desc flag?

Reading through the code I found this comment above the returned sort function from React-Table. This is returned as an array and passed through as the first parameter of orderByFn.

       // This function should always return in ascending order


          return function (a, b) {
            return sortMethod(a, b, sort.id, sort.desc);
          };

So on each click the column is always sorted Asc, instead of switching between the two. What should I do differently or am I missing something?

Here is my custom sort function that is memoized and consumed by React-Table as orderByFn.

  const sortFunction = (rows, sortFunction, isSortedDesc) => {
    console.log(sortFunction, isSortedDesc[0])
    // we split the rows. One for parents, the other for children.
    const newRowOrder = [],
      subRows = []

    // loop through the rows and separate parents and children like ICE
    for (const row of rows) {
      if (row.original.parent) subRows.push(row)
      else newRowOrder.push(row)
    }

    // sort the parents
    newRowOrder.sort(sortFunction[0])
    // create a new array to re-unite the parents and children
    const combinedRows = []

    // loop through all of the sorted parents
    for (const row of newRowOrder) {
      // push the parent into the new array
      combinedRows.push(row)

      // find all the children and push them into the new array
      combinedRows.push(
        ...subRows.filter(
          (item) => item.original.parent.appNum === row.original.appNum
        )
      )
    }

    // return the sorted parents and children
    return combinedRows
  }

[Sernom]

A fix that I am using to incorporate the isSortedDesc flag was to use .reverse() on the sorted array if it exists.

// if the sort descending flag is true, reverse the array
    if (isSortedDesc[0]) newRowOrder.reverse()