fix: stabilize job IDs to resolve duplicate job display bugs

Author: Tanq16

internal/jobs/git-clone/job.go

@@ -14,6 +14,7 @@ import (
 )
 
 type GitCloneJob struct {
+	id         string
 	URL        string
 	OutputPath string
 	Depth      int
@@ -30,7 +31,12 @@ type gitCloneJobState struct {
 }
 
 func New(url, outputPath string, depth int, token, sshKey string) *GitCloneJob {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &GitCloneJob{
+		id:         id,
 		URL:        url,
 		OutputPath: outputPath,
 		Depth:      depth,
@@ -40,10 +46,7 @@ func New(url, outputPath string, depth int, token, sshKey string) *GitCloneJob {
 }
 
 func (j *GitCloneJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *GitCloneJob) Type() string { return "git-clone" }

internal/jobs/github-release/ghrelease_test.go

@@ -3,6 +3,8 @@ package ghrelease
 import (
 	"runtime"
 	"testing"
+
+	"github.com/tanq16/danzo/utils"
 )
 
 func TestParseGitHubURLAcceptsSupportedRepositoryForms(t *testing.T) {
@@ -64,3 +66,15 @@ func TestSelectGitHubLatestAssetIgnoresChecksumsAndMatchesRuntimePlatform(t *tes
 		t.Fatalf("expected platform asset, got url=%q size=%d", url, size)
 	}
 }
+
+func TestGHReleaseJobIDIsStable(t *testing.T) {
+	job := New("tanq16/danzo", "", false, utils.HTTPClientConfig{})
+	initialID := job.ID()
+	
+	// Simulate what happens in Run() when output path is resolved
+	job.OutputPath = "danzo_resolved.tar.gz"
+	
+	if job.ID() != initialID {
+		t.Fatalf("expected ID to be stable (%q), but got %q", initialID, job.ID())
+	}
+}

internal/jobs/github-release/job.go

@@ -14,6 +14,7 @@ import (
 )
 
 type GHReleaseJob struct {
+	id            string
 	URL           string
 	OutputPath    string
 	Manual        bool
@@ -32,7 +33,12 @@ type ghReleaseJobState struct {
 }
 
 func New(url, outputPath string, manual bool, httpConfig utils.HTTPClientConfig) *GHReleaseJob {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &GHReleaseJob{
+		id:         id,
 		URL:        url,
 		OutputPath: outputPath,
 		Manual:     manual,
@@ -41,10 +47,7 @@ func New(url, outputPath string, manual bool, httpConfig utils.HTTPClientConfig)
 }
 
 func (j *GHReleaseJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *GHReleaseJob) Type() string { return "github-release" }

internal/jobs/google-drive/job.go

@@ -15,6 +15,7 @@ import (
 )
 
 type GDriveJob struct {
+	id              string
 	URL             string
 	OutputPath      string
 	APIKey          string
@@ -35,7 +36,12 @@ type gdriveJobState struct {
 }
 
 func New(url, outputPath, apiKey, credentialsFile string, httpConfig utils.HTTPClientConfig) *GDriveJob {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &GDriveJob{
+		id:              id,
 		URL:             url,
 		OutputPath:      outputPath,
 		APIKey:          apiKey,
@@ -45,10 +51,7 @@ func New(url, outputPath, apiKey, credentialsFile string, httpConfig utils.HTTPC
 }
 
 func (j *GDriveJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *GDriveJob) Type() string { return "google-drive" }

internal/jobs/http/job.go

@@ -46,6 +46,7 @@ type HTTPDownloadJob struct {
 }
 
 type HTTPJob struct {
+	id          string
 	URL         string
 	OutputPath  string
 	Connections int
@@ -62,7 +63,12 @@ type httpJobState struct {
 }
 
 func New(url, outputPath string, connections int, httpConfig utils.HTTPClientConfig) *HTTPJob {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &HTTPJob{
+		id:          id,
 		URL:         url,
 		OutputPath:  outputPath,
 		Connections: connections,
@@ -71,19 +77,7 @@ func New(url, outputPath string, connections int, httpConfig utils.HTTPClientCon
 }
 
 func (j *HTTPJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	parsedURL, err := url.Parse(j.URL)
-	if err != nil {
-		return j.URL
-	}
-	parts := strings.Split(parsedURL.Path, "/")
-	name := parts[len(parts)-1]
-	if name == "" {
-		return j.URL
-	}
-	return name
+	return j.id
 }
 
 func (j *HTTPJob) Type() string { return "http" }

internal/jobs/live-stream/job.go

@@ -15,6 +15,7 @@ import (
 )
 
 type LiveStreamJob struct {
+	id          string
 	URL         string
 	OutputPath  string
 	Connections int
@@ -33,7 +34,12 @@ type liveStreamJobState struct {
 }
 
 func New(urlStr, outputPath string, connections int, extractor string, httpConfig utils.HTTPClientConfig) *LiveStreamJob {
+	id := outputPath
+	if id == "" {
+		id = urlStr
+	}
 	return &LiveStreamJob{
+		id:          id,
 		URL:         urlStr,
 		OutputPath:  outputPath,
 		Connections: connections,
@@ -43,10 +49,7 @@ func New(urlStr, outputPath string, connections int, extractor string, httpConfi
 }
 
 func (j *LiveStreamJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *LiveStreamJob) Type() string { return "live-stream" }

internal/jobs/s3/job.go

@@ -14,6 +14,7 @@ import (
 )
 
 type S3Job struct {
+	id          string
 	URL         string
 	OutputPath  string
 	Connections int
@@ -28,7 +29,12 @@ type s3JobState struct {
 }
 
 func New(url, outputPath string, connections int, profile string) *S3Job {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &S3Job{
+		id:          id,
 		URL:         url,
 		OutputPath:  outputPath,
 		Connections: connections,
@@ -37,10 +43,7 @@ func New(url, outputPath string, connections int, profile string) *S3Job {
 }
 
 func (j *S3Job) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *S3Job) Type() string { return "s3" }

internal/jobs/torrent/job.go

@@ -16,6 +16,7 @@ import (
 )
 
 type TorrentJob struct {
+	id          string
 	URI         string
 	OutputPath  string
 	Connections int
@@ -32,7 +33,16 @@ type torrentJobState struct {
 }
 
 func New(uri, outputPath string, connections int, httpConfig utils.HTTPClientConfig) *TorrentJob {
+	id := outputPath
+	if id == "" || id == "." {
+		if strings.HasPrefix(uri, "magnet:") {
+			id = "magnet-link"
+		} else {
+			id = filepath.Base(uri)
+		}
+	}
 	return &TorrentJob{
+		id:          id,
 		URI:         uri,
 		OutputPath:  outputPath,
 		Connections: connections,
@@ -41,13 +51,7 @@ func New(uri, outputPath string, connections int, httpConfig utils.HTTPClientCon
 }
 
 func (j *TorrentJob) ID() string {
-	if j.OutputPath != "" && j.OutputPath != "." {
-		return j.OutputPath
-	}
-	if strings.HasPrefix(j.URI, "magnet:") {
-		return "magnet-link"
-	}
-	return filepath.Base(j.URI)
+	return j.id
 }
 
 func (j *TorrentJob) Type() string { return "torrent" }

internal/jobs/ytdlp/job.go

@@ -31,24 +31,27 @@ type YTDLPProgress struct {
 }
 
 type YTDLPJob struct {
+	id         string
 	URL        string
 	OutputPath string
 	HTTPConfig utils.HTTPClientConfig
 }
 
 func New(url, outputPath string, httpConfig utils.HTTPClientConfig) *YTDLPJob {
+	id := outputPath
+	if id == "" {
+		id = url
+	}
 	return &YTDLPJob{
+		id:         id,
 		URL:        url,
 		OutputPath: outputPath,
 		HTTPConfig: httpConfig,
 	}
 }
 
 func (j *YTDLPJob) ID() string {
-	if j.OutputPath != "" {
-		return j.OutputPath
-	}
-	return j.URL
+	return j.id
 }
 
 func (j *YTDLPJob) Type() string { return "ytdlp" }